Add tests for Angular package #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luismiramirez
force-pushed
the
add-packages-missing-tests
branch
from
818c8ff
to
386273f
Compare
tombruijn
requested changes
Oct 14, 2021
| bump: "patch" | ||
| --- | ||
|
|
||
| Add tests for Angular error handler |
There was a problem hiding this comment.
We don't need a changeset for this. We wouldn't release a new version of the package after adding tests.
Remind me to write a page/blog post about how changesets and changelogs work :)
| framework: "Angular" | ||
| }) | ||
|
|
||
| expect(appsignal.send).toBeCalled() |
There was a problem hiding this comment.
Suggested change
| expect(appsignal.send).toBeCalled() | |
| expect(appsignal.send).toBeCalledWith(mock) |
Would something like this work?
Angular package had no tests. This commits adds a simple one to test the error handler class with mocks to see if AppSignal is called properly
luismiramirez
force-pushed
the
add-packages-missing-tests
branch
from
386273f
to
f617116
Compare
tombruijn
approved these changes
Oct 14, 2021
jeffkreeftmeijer
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular package had no tests. This commits adds a simple one to test the
error handler class with mocks to see if AppSignal is called properly.
[skip changeset]