Appsignal is not stopping correctly #418
Comments
|
I'm experiencing the same issue. Did you find a solution @janhalama? |
|
No i did not find solution. |
|
Hi there, do you want to use AppSignal in the test environment? If not, I recommend disabling AppSignal in the test env like described on this page: https://docs.appsignal.com/nodejs/configuration/#disable-appsignal-for-tests Alternatively you could call the |
|
Thanks for reaching back. Skipping AppSignal is possible, but not desired as we want run e2e test including AppSignal. And calling stop in global callback (Jest's afterAll) doesn't work either. |
|
Basically the issue is that the |
|
I had a quick look. I ran it with If I add this config to the example linked above, it will not enable the minutely probes and work around this issue. The diff --git app.js app.js
index 037c00a..228ea8e 100644
--- app.js
+++ app.js
@@ -7,6 +7,7 @@ function startApp() {
active: true,
name: "express-test",
apiKey: process.env.APPSIGNAL_PUSH_API_KEY,
+ enableMinutelyProbes: false
});I hope that works for everyone for now. We'll discuss this issue with the team to figure out the best way to shut down the minutely probes process on |
Implement a `.stop` method on the `BaseProbes` class and on the
`Probes` interface, along with a read-only `.isStopped` property.
The new `BaseProbes` object handles only the stopping logic. The
actual behaviour of the probes is delegated to two private classes:
`StartedProbes` (which used to be `BaseProbes`) and `StoppedProbes`
(which used to be `NoopProbes`). Both of these implement the
`InternalProbes` private interface. Stopping the probes permanently
switches the implementation used.
`NoopProbes` no longer exists, but `BaseProbes({ stopped: true })`
can be used to initialise it in the stopped state, which is
functionally equivalent.
Call `metrics().probes().stop()` from the `BaseClient.stop()`
method, ensuring the probes system is stopped when AppSignal is
stopped.
Fixes #418 and closes #569.
Implement a `.stop` method on the `BaseProbes` class and on the
`Probes` interface, along with a read-only `.isRunning` property.
The new `BaseProbes` object handles only the stopping logic. The
actual behaviour of the probes is delegated to two private classes:
`BaseProbeRunner` (which used to be `BaseProbes`) and
`NoopProbeRunner` (which used to be `NoopProbes`). Both of these
implement the `ProbeRunner` private interface. Stopping the probes
permanently switches the implementation used.
`NoopProbes` no longer exists, but `BaseProbes({ run: false })`
can be used to initialise it in the stopped state, which is
functionally equivalent.
Call `metrics().probes().stop()` from the `BaseClient.stop()`
method, ensuring the probes system is stopped when AppSignal is
stopped.
Fixes #418 and closes #569.
Implement a `.stop` method on the `BaseProbes` class and on the
`Probes` interface, along with a read-only `.isRunning` property.
The new `BaseProbes` object handles only the stopping logic. The
actual behaviour of the probes is delegated to two private classes:
`BaseProbeRunner` (which used to be `BaseProbes`) and
`NoopProbeRunner` (which used to be `NoopProbes`). Both of these
implement the `ProbeRunner` private interface. Stopping the probes
permanently switches the implementation used.
`NoopProbes` no longer exists, but `BaseProbes({ run: false })`
can be used to initialise it in the stopped state, which is
functionally equivalent.
Call `metrics().probes().stop()` from the `BaseClient.stop()`
method, ensuring the probes system is stopped when AppSignal is
stopped.
Fixes #418 and closes #569.
Implement a `.stop` method on the `BaseProbes` class and on the
`Probes` interface, along with a read-only `.isRunning` property.
The new `BaseProbes` object handles only the stopping logic. The
actual behaviour of the probes is delegated to two private classes:
`BaseProbeRunner` (which used to be `BaseProbes`) and
`NoopProbeRunner` (which used to be `NoopProbes`). Both of these
implement the `ProbeRunner` private interface. Stopping the probes
permanently switches the implementation used.
`NoopProbes` no longer exists, but `BaseProbes({ run: false })`
can be used to initialise it in the stopped state, which is
functionally equivalent.
Call `metrics().probes().stop()` from the `BaseClient.stop()`
method, ensuring the probes system is stopped when AppSignal is
stopped.
Fixes #418 and closes #569.
Implement a `.stop` method on the `BaseProbes` class and on the
`Probes` interface, along with a read-only `.isRunning` property.
The new `BaseProbes` object handles only the stopping logic. The
actual behaviour of the probes is delegated to two private classes:
`BaseProbeRunner` (which used to be `BaseProbes`) and
`NoopProbeRunner` (which used to be `NoopProbes`). Both of these
implement the `ProbeRunner` private interface. Stopping the probes
permanently switches the implementation used.
`NoopProbes` no longer exists, but `BaseProbes({ run: false })`
can be used to initialise it in the stopped state, which is
functionally equivalent.
Call `metrics().probes().stop()` from the `BaseClient.stop()`
method, ensuring the probes system is stopped when AppSignal is
stopped.
Fixes #418 and closes #569.
|
Hi @janhalama @ErfanEbrahimnia @freaz! This issue should be fixed in version 2.3.2 of the Please let us know if you run into any further issues with the package. |
Hi there,
Appsignal is not stopping correctly which is causing jest tests to hang. You can reproduce this issue in following repository https://github.com/janhalama/appsignal-test by running
yarn testcommand.This is screenshot of the running test:
I tried to find answer in existing issues, found this one related #398 but answers did not help me much.
The text was updated successfully, but these errors were encountered: