Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect custom AppSignal client files from diagnose command #887

Closed
2 tasks done
luismiramirez opened this issue May 15, 2023 · 0 comments · Fixed by #925
Closed
2 tasks done

Detect custom AppSignal client files from diagnose command #887

luismiramirez opened this issue May 15, 2023 · 0 comments · Fixed by #925
Assignees

Comments

@luismiramirez
Copy link
Member

luismiramirez commented May 15, 2023

From a leftover of #882

Even tho we don't recommend it, some users might initialize the AppSignal client with other methods instead of the recommended appsignal.cjs. If that happens, the diagnose command won't be able to detect the client initialization file.

We tried to use the --config flag, but with the current implementation, that means we need to share information between the diagnose command and the Config class which is not ideal. In order to make the --config flag to work, more significant changes are required.

ToDo

  • Provide users with the ability of telling where the custom AppSignal client initialization file is when using the diagnose command
  • Check the presence of this file and load it as we do with appsignal.cjs or src/appsignal.cjs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant