Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add incoming HTTP instrumentation, plugin system #48

Merged
merged 14 commits into from
Mar 4, 2020
Merged

Add incoming HTTP instrumentation, plugin system #48

merged 14 commits into from
Mar 4, 2020

Conversation

adamyeats
Copy link
Contributor

@adamyeats adamyeats commented Feb 25, 2020 •
edited

This PR got a bit long and joined together, but covers the following things:

  • Adds a plugin system for creating custom instrumentation
  • Adds custom instrumentation for incoming (not outgoing) HTTP requests
  • Updates the ScopeManager to bind functions and EventEmitters to the current scope
  • Removes Span creation functionality from @appsignal/express, this is superseded by the HTTP integration
  • Renames some types and interfaces
  • Removes tracer.withSpanSync(), as we now handle AsyncResources better, this is no longer necessary

@adamyeats adamyeats self-assigned this Feb 25, 2020
@backlog-helper
Copy link

backlog-helper bot commented Feb 25, 2020 •
edited

✔️ All good!

New issue guide | Backlog management | Rules | Feedback

@adamyeats adamyeats linked an issue Feb 26, 2020 that may be closed by this pull request
Generic HTTP/HTTPS instrumentation #22
Closed
6 tasks
@adamyeats adamyeats marked this pull request as ready for review February 27, 2020 14:55
@adamyeats adamyeats removed a link to an issue Feb 27, 2020
Generic HTTP/HTTPS instrumentation #22
Closed
6 tasks
@adamyeats adamyeats mentioned this pull request Feb 27, 2020
Closed
6 tasks
@adamyeats adamyeats changed the title Add http instrumentation, plugin system Add incoming HTTP instrumentation, plugin system Feb 27, 2020
@backlog-helper

This comment has been minimized.

Sign in to view
@backlog-helper

This comment has been minimized.

Sign in to view
1 similar comment
@backlog-helper

This comment has been minimized.

Sign in to view
thijsc
thijsc approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@thijsc thijsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

@backlog-helper
Copy link

backlog-helper bot commented Mar 4, 2020

While performing the daily checks some issues were found with this Pull Request.

  • This Pull Request has been approved. Can it be merged @xadamy? - (More info)

New issue guide | Backlog management | Rules | Feedback

@adamyeats adamyeats merged commit 65f37bc into master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thijsc thijsc thijsc approved these changes

@jeffkreeftmeijer jeffkreeftmeijer jeffkreeftmeijer approved these changes

Assignees

@adamyeats adamyeats

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adamyeats @thijsc @jeffkreeftmeijer