Add config options of the list type #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 tasks
tombruijn
force-pushed
the
list-config-options
branch
from
f24e69d
to
b622819
Compare
luismiramirez
approved these changes
May 3, 2023
unflxw
approved these changes
May 3, 2023
tombruijn
force-pushed
the
boolean-config-options
branch
3 times, most recently
from
dafe175
to
44210ce
Compare
Parse lists from environment variables, and format them again when set as private env vars for the agent. I left out request_headers, because we should check what the default for that should be in more detail. This is more the general structure of parsing and setting config options that the client does not directly use (right now).
tombruijn
force-pushed
the
list-config-options
branch
from
b622819
to
cc5b00d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse lists from environment variables, and format them again when set as private env vars for the agent.
I left out request_headers, because we should check what the default for that should be in more detail. This is more the general structure of parsing and setting config options that the client does not directly use (right now).
[skip changeset]
Part of #16
Based on #28