-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement install command #38
Conversation
✔️ All good! |
Figured out how to test it locally: Is the package configured through the same method to expose an "appsignal" executable when the package is installed?
I do not mind the lack of flair or emojis. I don't need a circus of emoji and colorized output when running an installer. |
Sorry, forgot to mention how to test it locally 🙃 And, well, today I learned! The way I've been testing it myself is by running So, yes, it exposes an "appsignal" executable when the package is installed, like the Ruby gem does. |
Implement an installation command that asks the user to input the necessary information to generate an `appsignal_config.py` file.
It's short, it's not as ugly as `appsignal_config.py`, it's vaguely Pythonic and it doesn't lead to circular imports like `appsignal.py`.
Instead, make it part of the default config.
If the user presses CTRL+C to close the current process, don't throw an exception in their face.
Added the instructions as suggested by @tombruijn, as well as some "next step" instructions on how to actually use the file that was just created. Also some emojis.
Implement an installation command that asks the user to input the necessary information to generate an
appsignal_config.py
file.Closes #18. [skip changeset]
The installer is functional, but it's missing "flair" -- emojis, links to the docs, friendliness, that sort of stuff. Suggestions welcome. I could also just copy what some other integration's installer does.