Add params, path and method to errors reported via Rails #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdewater-thatch
force-pushed
the
rails-error-report-controller
branch
from
3694955
to
fe3e1ff
Compare
|
Thank you for your contribution @bdewater-thatch! Don't worry about the CI failures, we will take over and address those. |
This data was not extracted from the current Appsignal transaction. This partially fixes appsignal#1051 as the headers are still missing.
bdewater-thatch
force-pushed
the
rails-error-report-controller
branch
from
fe3e1ff
to
2748b3b
Compare
|
@unflxw all fixed up! |
|
This is a message from the daily scheduled checks. |
|
Thank you! Merged with an additional precaution on top. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1051
This closes most of the gaps between our previous usage of
Appsignal.set_errorand using the Rails error reporter interface. The only thing missing are the headers (environment), I'm getting a bit lost in howAppsignal::Transactionhas various ways to set/read things when trying to add it myself. FFT take this over and improve it.