Don't crash on non-writable logger file #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombruijn
force-pushed
the
catch-logger-file-permission-errors
branch
from
59b602e
to
cc85a7a
Compare
jeffkreeftmeijer
requested changes
Sep 22, 2016
| begin | ||
| @logger = Logger.new(path) | ||
| @logger.formatter = log_formatter | ||
| rescue Exception => error |
There was a problem hiding this comment.
Although I agree that we should be careful here, we probably don't want to rescue Exception and turn it into a warning.
There was a problem hiding this comment.
I'm not quite sure what all the errors that can be thrown here, so I'll change it to StandardError using rescue => e.
Not sure why I thought rescuing Exception was a good thing, especially since we discussed it earlier.. 🤔
tombruijn
force-pushed
the
catch-logger-file-permission-errors
branch
2 times, most recently
from
a39dfbd
to
c4a355a
Compare
tombruijn
force-pushed
the
log_file_path-improvements
branch
from
9228bb6
to
8e8de22
Compare
tombruijn
force-pushed
the
catch-logger-file-permission-errors
branch
from
c4a355a
to
7e871c9
Compare
tombruijn
changed the base branch from
log_file_path-improvements
to
master
|
Rebased on updated master |
tombruijn
force-pushed
the
catch-logger-file-permission-errors
branch
2 times, most recently
from
724e7b2
to
05119f9
Compare
|
Updated to rescue on SystemCallError. Seems to encapsulate most IO errors we can trigger |
thijsc
approved these changes
Sep 23, 2016
jeffkreeftmeijer
approved these changes
Sep 26, 2016
When the parent path is writable, but the logger file itself is not, do no longer crash. Also updated specs to be more descriptive and cover more cases.
tombruijn
force-pushed
the
catch-logger-file-permission-errors
branch
from
05119f9
to
bd90694
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the parent path is writable, but the logger file itself is not, do no longer crash.
Also updated specs to be more descriptive and cover more cases.
Based on #158
Part of fix for #153