Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support namespaces in Grape #189

Merged
merged 1 commit into from
Oct 14, 2016
Merged

Support namespaces in Grape #189

merged 1 commit into from
Oct 14, 2016

Conversation

tombruijn
Copy link
Member

Only the path was used which does not include the namespace. This is
only available on the Grape::Endpoint.

Namespaces and paths can be anything, Symbols or Strings, prefixed with
a / or not.

Brain dump about thoughts on the integration and tests:

I kept the fallback on the request data the same right now, but I think we can take that out at some point. Same as with the Sinatra integration. If env["api.endpoint"] doesn't exist the integration provides poorly structured data and it's of not much use. We should perform some tests later to see if there can ever not be api.endpoint in the env. Also see if we can take a different testing approach, something a bit more full stack approach with Rake::Test. Now we control how the middleware is created, something which we don't in grape.

As reported in https://app.intercom.io/a/apps/yzor8gyw/inbox/conversation/5431615974

Only the path was used which does not include the namespace. This is
only available on the Grape::Endpoint.

Namespaces and paths can be anything, Symbols or Strings, prefixed with
a / or not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants