Fix support for Rails 5.1 apps #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thijsc
approved these changes
May 10, 2017
|
Let's ship this straight away. |
|
Oh I see I aimed this at develop. Will rebase on master branch. @jeffkreeftmeijer can you review so we can release a 2.2.1 release? |
The ActionDispatch::DebugExceptions middleware returns a rack response in v5.1.0 instead of an exception as in < v5.1.0. Change the location where we inject the middleware, namely before the exception is caught and an error page is rendered.
tombruijn
force-pushed
the
rails-5.1-support
branch
from
1202e3b
to
dcffddc
Compare
jeffkreeftmeijer
approved these changes
May 10, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ActionDispatch::DebugExceptions middleware returns a rack response
in v5.1.0 instead of an exception as in < v5.1.0. Change the location
where we inject the middleware, namely before the exception is caught
and an error page is rendered.