Skip to content

Commit

Permalink
chore: Use default repo methods when possible (#32997)
Browse files Browse the repository at this point in the history
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced new functionalities to count and retrieve Git-connected
applications within a specific workspace.
  
- **Bug Fixes**
- Removed outdated method for counting applications by workspace ID to
enhance performance and accuracy.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
sharat87 committed Apr 29, 2024
1 parent 4b1ef98 commit 0d03411
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ public interface ApplicationRepositoryCE extends BaseRepository<Application, Str

Flux<Application> findByWorkspaceId(String workspaceId);

Mono<Long> countByWorkspaceId(String workspaceId);

Flux<IdOnly> findIdsByWorkspaceId(String workspaceId);

Flux<Application> findByClonedFromApplicationId(String clonedFromApplicationId);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,6 @@ Mono<Application> getApplicationByGitBranchAndDefaultApplicationId(
Mono<Integer> setAppTheme(
String applicationId, String editModeThemeId, String publishedModeThemeId, AclPermission aclPermission);

Mono<Long> countByWorkspaceId(String workspaceId);

Mono<Long> getGitConnectedApplicationWithPrivateRepoCount(String workspaceId);

Flux<Application> getGitConnectedApplicationByWorkspaceId(String workspaceId);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -163,13 +163,6 @@ public Flux<Application> getApplicationByGitDefaultApplicationId(
.all();
}

@Override
public Mono<Long> countByWorkspaceId(String workspaceId) {
return queryBuilder()
.criteria(Bridge.equal(Application.Fields.workspaceId, workspaceId))
.count();
}

@Override
public Mono<Long> getGitConnectedApplicationWithPrivateRepoCount(String workspaceId) {
return queryBuilder()
Expand Down

0 comments on commit 0d03411

Please sign in to comment.