refactor: Apply getter at field level

appsmithorg · Apr 29, 2024 · bc9836e · bc9836e
1 parent ec3d10f
commit bc9836e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 8 deletions.
diff --git a/...rver/src/main/java/com/appsmith/server/fork/internal/ApplicationForkingServiceCEImpl.java b/...rver/src/main/java/com/appsmith/server/fork/internal/ApplicationForkingServiceCEImpl.java
@@ -596,7 +596,7 @@ private Mono<Boolean> checkPermissionsForForking(
                     .findIdsAndPoliciesByApplicationIdIn(List.of(application.getId()))
                     .map(idPoliciesOnly -> {
                         NewPage newPage = new NewPage();
-                        newPage.setId(idPoliciesOnly.getId());
+                        newPage.setId(idPoliciesOnly.id());
                         newPage.setPolicies(idPoliciesOnly.getPolicies());
                         return newPage;
                     })
@@ -606,7 +606,7 @@ private Mono<Boolean> checkPermissionsForForking(
                     .findIdsAndPoliciesByApplicationIdIn(List.of(application.getId()))
                     .map(idPoliciesOnly -> {
                         NewAction newAction = new NewAction();
-                        newAction.setId(idPoliciesOnly.getId());
+                        newAction.setId(idPoliciesOnly.id());
                         newAction.setPolicies(idPoliciesOnly.getPolicies());
                         return newAction;
                     })

diff --git a/app/server/appsmith-server/src/main/java/com/appsmith/server/projections/IdPoliciesOnly.java b/app/server/appsmith-server/src/main/java/com/appsmith/server/projections/IdPoliciesOnly.java
@@ -6,5 +6,4 @@
 
 import java.util.Set;
 
-@Getter
-public record IdPoliciesOnly(@NonNull String id, Set<Policy> policies) {}
+public record IdPoliciesOnly(@NonNull String id, @Getter Set<Policy> policies) {}
diff --git a/...th-server/src/main/java/com/appsmith/server/services/ce/ApplicationPageServiceCEImpl.java b/...th-server/src/main/java/com/appsmith/server/services/ce/ApplicationPageServiceCEImpl.java
@@ -1470,7 +1470,7 @@ private Mono<Boolean> validateAllObjectsForPermissions(
                 .findIdsAndPoliciesByApplicationIdIn(List.of(application.getId()))
                 .map(idPoliciesOnly -> {
                     NewPage newPage = new NewPage();
-                    newPage.setId(idPoliciesOnly.getId());
+                    newPage.setId(idPoliciesOnly.id());
                     newPage.setPolicies(idPoliciesOnly.getPolicies());
                     return newPage;
                 })
@@ -1479,7 +1479,7 @@ private Mono<Boolean> validateAllObjectsForPermissions(
                 .findIdsAndPoliciesByApplicationIdIn(List.of(application.getId()))
                 .map(idPoliciesOnly -> {
                     NewAction newAction = new NewAction();
-                    newAction.setId(idPoliciesOnly.getId());
+                    newAction.setId(idPoliciesOnly.id());
                     newAction.setPolicies(idPoliciesOnly.getPolicies());
                     return newAction;
                 })
@@ -1488,7 +1488,7 @@ private Mono<Boolean> validateAllObjectsForPermissions(
                 .findIdsAndPoliciesByApplicationIdIn(List.of(application.getId()))
                 .map(idPoliciesOnly -> {
                     ActionCollection actionCollection = new ActionCollection();
-                    actionCollection.setId(idPoliciesOnly.getId());
+                    actionCollection.setId(idPoliciesOnly.id());
                     actionCollection.setPolicies(idPoliciesOnly.getPolicies());
                     return actionCollection;
                 })
@@ -1538,7 +1538,7 @@ private Mono<Boolean> validateDatasourcesForCreatePermission(Mono<Application> a
                         .findIdsAndPoliciesByIdIn(datasourceIds)
                         .flatMap(idPolicy -> {
                             Datasource datasource = new Datasource();
-                            datasource.setId(idPolicy.getId());
+                            datasource.setId(idPolicy.id());
                             datasource.setPolicies(idPolicy.getPolicies());
                             return datasourceRepository.setUserPermissionsInObject(datasource);
                         }));