Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Auto-complete does not work when multiple bindings exists on the same line #16288

Closed
1 task done
btsgh opened this issue Aug 25, 2022 · 2 comments · Fixed by #16314
Closed
1 task done

[Bug]: Auto-complete does not work when multiple bindings exists on the same line #16288

btsgh opened this issue Aug 25, 2022 · 2 comments · Fixed by #16314
Assignees
@rishabhrathod01 @satbir121
Labels
Autocomplete Issues related to the autocomplete Bug Something isn't working FE Coders Pod Issues related to users writing javascript in appsmith High This issue blocks a user from building or impacts a lot of users Verified When issue is retested post its fixed

Comments

@btsgh
Copy link

btsgh commented Aug 25, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Description

When I try to use a binding in an INSERT statement of Snowflake DB, though the widgets already exist on the page, the Autocomplete does not work to complete the widget names and action.

Steps To Reproduce

Create a snowflake datasource and create an INSERT query to the same.

Refer following video to reproduce:
https://www.loom.com/share/91a7957ccc0b45c295685eb8faf388f2

Public Sample App

No response

Version

Release
@btsgh btsgh added Bug Something isn't working Autocomplete Issues related to the autocomplete Needs Triaging Needs attention from maintainers to triage snowflake Issues related to the snowflake Integration labels Aug 25, 2022
@github-actions github-actions bot added BE Coders Pod Issues related to users writing code to fetch and update data FE Coders Pod Issues related to users writing javascript in appsmith labels Aug 25, 2022
@rishabhrathod01 rishabhrathod01 removed the BE Coders Pod Issues related to users writing code to fetch and update data label Aug 25, 2022
@github-actions github-actions bot added the BE Coders Pod Issues related to users writing code to fetch and update data label Aug 25, 2022
@Nikhil-Nandagopal
Copy link
Contributor

@btsgh I don't think this will be snowflake specific. Can you verify whether this is happening in other plugins too?

@Nikhil-Nandagopal Nikhil-Nandagopal added the High This issue blocks a user from building or impacts a lot of users label Aug 29, 2022
@rishabhrathod01
Copy link
Contributor

rishabhrathod01 commented Aug 29, 2022 •
edited

@Nikhil-Nandagopal @btsgh Yes, this is not specific to the snowflake. It is for all the cases where multiple bindings are present in the same line. for eg: {{Text.text}} ABC {{Input1.text}}

This PR #16314 has fixes for the new logic which had the issue for this case.

@rishabhrathod01 rishabhrathod01 mentioned this issue Aug 29, 2022
Merged
9 tasks
@rohan-arthur rohan-arthur removed snowflake Issues related to the snowflake Integration BE Coders Pod Issues related to users writing code to fetch and update data labels Aug 29, 2022
@ramsaptami ramsaptami changed the title [Bug]: Auto-complete does not work in some scenarios in Snowflake DB [Bug]: Auto-complete does not work when multiple bindings exists on the same line Sep 16, 2022
@close-label close-label bot added the QA Needs QA attention label Sep 19, 2022
mohanarpit pushed a commit that referenced this issue Sep 19, 2022
@rishabhrathod01
fix: Autocomplete now works with multiple bindings (#16314)
9a1fa98 
Fixes #16288
Fixes #16158
Fixes #16188
Fixes #15859
@ramsaptami ramsaptami added Verified When issue is retested post its fixed and removed QA Needs QA attention Needs Triaging Needs attention from maintainers to triage labels Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rishabhrathod01 rishabhrathod01

@satbir121 satbir121

Labels
Autocomplete Issues related to the autocomplete Bug Something isn't working FE Coders Pod Issues related to users writing javascript in appsmith High This issue blocks a user from building or impacts a lot of users Verified When issue is retested post its fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: autocomplete-regress appsmithorg/appsmith
7 participants
@Nikhil-Nandagopal @pranavkanade @rishabhrathod01 @satbir121 @ramsaptami @rohan-arthur @btsgh