[Bug]: Even without editing the user is displayed with Pop up in Auth API #18962
Assignees
Labels
Bug
Something isn't working
Datasources
Issues related to configuring datasource on appsmith
Integrations Pod
Issues related to a specific integration
Medium
Issues that frustrate users due to poor UX
Needs Triaging
Needs attention from maintainers to triage
Release
Comments
prapullac
added
Bug
github-actions
bot
added
the
Integrations Pod
|
should ideally have been fixed with #18761 ? |
sharat87
pushed a commit
that referenced
this issue
Dec 30, 2022
This PR includes following changes: - With latest datasource autosave improvements, we do not save the datasource immediately but save it on explicit click of save button, so in case user has not saved any changes and tries to leave the page, we have added a popup to inform users that they have unsaved changes and whether they would like to save them or not. - The issue was in case of postgres and authenticated API datasource, this popup was getting seen even when the user has not made any changes in the datasource configuration. This PR solves that issue. - The unsaved changes popup needs to be shown only when user has made any new changes in the datasource form TL;DR - We have used redux form's isDirty method to check if user has made any new updates to the form or not. This isDirty compares initial value of datasource form with current form value and if current form value is different it shows the unsaved changes popup - The issue occurred because in case of postgres and authenticated API datasource, we initialise 1 default pair of host address and port (postgres), and default pairs of headers and query parameters (Authenticated API). These initial default changes made the form dirty and so user used to see the popup even when they have not explicitly made any changes. - This PR fixes the issue by setting initial form value with these defaults so they do not make the form dirty. Fixes #18962 , #18998 https://user-images.githubusercontent.com/30018882/208931098-b570e3c4-10bc-4b76-bd54-531ccf869436.mov Co-authored-by: “sneha122” <“sneha@appsmith.com”> Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there an existing issue for this?
Description
When the user click on edit of existing Datasource it is observed that the user without making any change the pop up is displayed to the user
Steps To Reproduce
Observe that the pop up is displayed to the user
Public Sample App
No response
Issue video log
https://www.loom.com/share/ebe56e716afb4bc18a3e6e8a8c6c200f
Version
Release
The text was updated successfully, but these errors were encountered: