[Bug]-[400]:For select column type in the table widget where the options are dynamically set, the same doesn't show up during Add new row flow #20230
Assignees
Labels
App Viewers Pod
This label assigns issues to the app viewers pod
Bug
Something isn't working
High
This issue blocks a user from building or impacts a lot of users
Needs Triaging
Needs attention from maintainers to triage
Production
Table Widget V2
Issues related to Table Widget V2
Verified
When issue is retested post its fixed
Comments
kamakshibhat-appsmith
added
Bug
github-actions
bot
added
the
App Viewers Pod
kamakshibhat-appsmith
added
Production
and removed
App Viewers Pod
github-actions
bot
added
the
App Viewers Pod
kamakshibhat-appsmith
assigned dilippitchika, somangshu and kamakshibhat-appsmith and unassigned kamakshibhat-appsmith
|
We need to add support for |
|
Another user reported this issue. |
somangshu
added
the
High
|
Another user reported this bug. |
1 task
Stats
|
Nikhil-Nandagopal
changed the title
dilippitchika
assigned souma-ghosh and unassigned somangshu, keyurparalkar and dilippitchika
|
This happens because the options property today only looks at data to create options today. We need to add support for new row here. Solution Show 2 new fields in the select column type, when the allow add new row is turned on in table
|
|
Hi All, will this bug be solved soon? For now my team will use a modal approach to overcome this when adding a new table row, skipping the add new row feature in the table widget. It's a step back for our business on the ui design and we would really appreciate if this gets some attention. Thank you. :) |
|
Same issue for me. Clearly I can work around it with a Modal, but it would be nice for the feature to work as intended. |
13 tasks
|
Hey folks, we have almost closed the development. Please keep an eye out in the PR linked to the issue. |
Aishwarya-U-R
pushed a commit
that referenced
this issue
Apr 6, 2023
## Description
This PR introduces new two new properties: `Same options in new row` and
`New row options` for the select column type.
We show these two fields when the allow add new row is turned on in
table
- SameOptionsInNewRow -- Boolean field ; When turned on the option for
the first row is used in the new row. Default is true
- Label : Use same options in new row
- Tooltip : Toggle to display same choices for new row and editing
existing row in column.
- NewRowOptions -- Array field; when the above boolean is turned off we
show this option to let people add options specifically for new row.
Supports static and dynamic data, but doesn't support currentRow
- Label: New row options
- Tooltip : Options exclusively displayed in the column for new row
addition.
Fixes #20230
## Type of change
- Bug fix (non-breaking change which fixes an issue)
## How Has This Been Tested?
- Cypress:
- When allowAddNewRow is turned on, same new option should be true and
new row option should be invisible.
- When turned on same option, options of the first row should appear
while editing as well as adding new row.
- When turned off, New row option should be visible
- Fill new row options, the new row options should appear while adding
new row in select field.
- New row options should not have access to the currentRow
- Both the options should only be visible only when allowNewRow is true.
- Should support static and dynamic values in new row options
- Manual
- For the new DnD Tables. Check if the above functionality is working as
expected.
- For Existing tables, Check if the above functionality is working as
expected. This needed to be tested from migration standpoint
### Test Plan
> https://github.com/appsmithorg/TestSmith/issues/2367
### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
|
Folks @markomedin @adrian-stephens this will be available in our on 17 Apr in production. Please keep an eye out. The way it works is listed here - #20230 (comment) |
|
Thank you for taking quick action on this issue. Big thumbs up for the AppSmith support team. :) |
chandannkumar
added
Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there an existing issue for this?
Description
For select column type in the table widget where the options are dynamically set, the same doesn't show up during Add new row flow
https://www.loom.com/share/0d9fbce9249d4445b57a231b0f0ad9e9
Steps To Reproduce
Public Sample App
No response
Issue video log
No response
Version
Production
The text was updated successfully, but these errors were encountered: