Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Switch Widget #2999

Merged
merged 15 commits into from Feb 16, 2021
Merged

Feature Switch Widget #2999

merged 15 commits into from Feb 16, 2021

Conversation

marks0351
Copy link
Member

@marks0351 marks0351 commented Feb 12, 2021 •
edited

Pull Request Template

New Switch widget or Toggle button

Description

Adding new widget - Switch

Fixes #1760

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@marks0351 marks0351 marked this pull request as ready for review February 12, 2021 11:30
riodeuno
riodeuno previously approved these changes Feb 16, 2021
View reviewed changes
riodeuno
riodeuno requested changes Feb 16, 2021
View reviewed changes
app/client/src/widgets/SwitchWidget.tsx Outdated Show resolved Hide resolved
riodeuno
riodeuno approved these changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@riodeuno riodeuno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Nice clean code. A good example of how we should code widgets today.

@marks0351 marks0351 merged commit a55c10a into release Feb 16, 2021
@marks0351 marks0351 deleted the feature/switchWidget branch February 16, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riodeuno riodeuno riodeuno approved these changes

@jsartisan jsartisan Awaiting requested review from jsartisan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Switch Widget
2 participants
@marks0351 @riodeuno