Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Learn more documentation on create datasource takes us to basic application setup documentation page #30169

Closed
1 task done
sneha122 opened this issue Jan 9, 2024 · 7 comments · Fixed by #33123
Closed
1 task done
Assignees
Labels
Activation - datasources issues related to activation projects BE Coders Pod Issues related to users writing code to fetch and update data Bug Something isn't working Datasources Issues related to configuring datasource on appsmith Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod Issues related to a specific integration Low effort Takes 1-2 days Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Production QA Pod Issues under the QA Pod QA Needs QA attention

Comments

@sneha122
Copy link
Contributor

sneha122 commented Jan 9, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Description

We have this banner on create datasource page for whitelisting IP and we have a CTA to learn more, when clicked on learn more it takes me to this doc page, I was expecting this doc page to have info on either datasources or white listing the IP but instead this page has info on basics of application setup. We should fix this and make learn more CTA take us to respective datasource's documentation page: https://theappsmith.slack.com/archives/CGBPVEJ5C/p1704804571691129?thread_ts=1704803786.978579&cid=CGBPVEJ5C

Screenshot 2024-01-09 at 6 02 41 PM

Steps To Reproduce

  1. Create a datasource
  2. Observe the banner that appears on top
  3. Click on Learn More

Public Sample App

No response

Environment

Production

Issue video log

No response

Version

Cloud/ Self-Hosted - 1.8.4

@sneha122 sneha122 added Bug Something isn't working Datasources Issues related to configuring datasource on appsmith Needs Triaging Needs attention from maintainers to triage Medium Issues that frustrate users due to poor UX labels Jan 9, 2024
@github-actions github-actions bot added the Data Platform Pod Issues related to the underlying data platform label Jan 9, 2024
@Nikhil-Nandagopal
Copy link
Contributor

@sneha122 can you fix this? It should go to the respective datasource page

@sneha122
Copy link
Contributor Author

@Nikhil-Nandagopal Yes I will take this up

@sneha122 sneha122 added the Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. label Jan 10, 2024
@github-actions github-actions bot added BE Coders Pod Issues related to users writing code to fetch and update data Integrations Pod Issues related to a specific integration labels Jan 10, 2024
@rohan-arthur rohan-arthur added the Activation - datasources issues related to activation projects label Jan 31, 2024
@github-actions github-actions bot removed the Data Platform Pod Issues related to the underlying data platform label Feb 29, 2024
@rohan-arthur
Copy link
Contributor

@rahulbarwal
Copy link
Contributor

Adding to the above comment, lets ensure we check the click functionality on different browsers.

On Arc and firefox, it is opening 2 tabs - one of which is blank.
On Safari it works expectedly.

@NilanshBansal
Copy link
Contributor

NilanshBansal commented Apr 29, 2024

Datasource Name Documentation Link Link Configured Correctly?
Google Sheets https://docs.appsmith.com/connect-data/reference/querying-google-sheets#create-queries Yes
REST API NA NA
PostgreSQL https://docs.appsmith.com/connect-data/reference/querying-postgres No
MySQL https://docs.appsmith.com/connect-data/reference/querying-mysql No
MongoDB https://docs.appsmith.com/connect-data/reference/querying-mongodb No
GraphQL API NA NA
Authenticated API NA NA
Authenticated GraphQL API NA NA
CURL Import NA NA
Elasticsearch https://docs.appsmith.com/connect-data/reference/querying-elasticsearch No
DynamoDB https://docs.appsmith.com/connect-data/reference/querying-dynamodb No
Redis https://docs.appsmith.com/connect-data/reference/querying-redis No
Microsoft SQL Server https://docs.appsmith.com/connect-data/reference/querying-mssql No
Firestore https://docs.appsmith.com/connect-data/reference/querying-firestore No
Redshift https://docs.appsmith.com/connect-data/reference/querying-redshift No
S3 https://docs.appsmith.com/connect-data/reference/querying-amazon-s3 No
Snowflake https://docs.appsmith.com/connect-data/reference/querying-snowflake-db No
ArangoDB https://docs.appsmith.com/connect-data/reference/querying-arango-db No
SMTP https://docs.appsmith.com/connect-data/reference/using-smtp No
Oracle https://docs.appsmith.com/connect-data/reference/querying-oracle No
Databricks https://docs.appsmith.com/connect-data/reference/databricks No
Airtable NA NA
AWS Lambda NA NA
HubSpot NA NA
Twilio NA NA
Anthropic NA NA
Appsmith AI NA NA
Google AI NA NA
Open AI NA NA

*Marked NA for datasources where Learn More button is not present.

@NilanshBansal NilanshBansal removed the Good First Issue Good for newcomers label Apr 29, 2024
@NilanshBansal
Copy link
Contributor

As per the code written in the client side, the open documentation codebase is not specific to each plugin. It is a single piece of code which can take in a common link to the documentation for all plugins.
For the current scenario, we need separate links to each plugin.

Ref:

{!this.props.hiddenHeader &&
cloudHosting &&
pluginType === PluginType.DB &&
!viewMode && (
<Callout
className="mt-4"
kind="info"
links={[
{
children: "Learn more",
onClick: this.openDocumentation,
endIcon: "share-box-line",
to: "about:blank",
},
]}
>
{`Whitelist the IP ${convertArrayToSentence(
APPSMITH_IP_ADDRESSES,
)} on your database instance to connect to it. `}
</Callout>
)}

Also, the documentation link reference in the codebase is not read from the database field plugin.documentationLink rather it is hardcoded here.

@NilanshBansal
Copy link
Contributor

Deproioritising this because of a performance improvement that needs immediate attention.
https://github.com/appsmithorg/appsmith-ee/issues/4061

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Activation - datasources issues related to activation projects BE Coders Pod Issues related to users writing code to fetch and update data Bug Something isn't working Datasources Issues related to configuring datasource on appsmith Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod Issues related to a specific integration Low effort Takes 1-2 days Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Production QA Pod Issues under the QA Pod QA Needs QA attention
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

9 participants