Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Input widget's 'valid' property placeholder changes #33243

Closed
1 task done
ramsaptami opened this issue May 7, 2024 · 0 comments
Closed
1 task done

[Bug]: Input widget's 'valid' property placeholder changes #33243

ramsaptami opened this issue May 7, 2024 · 0 comments
Assignees
@KelvinOm
Labels
Anvil Pod Issue related to Anvil project Bug Something isn't working Medium Issues that frustrate users due to poor UX WDS team

Comments

@ramsaptami
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description

Input widget's placeholder contains a reference to an outdated internal property of the widget, it needs to be changed from input.text to input.pasrsedText

Steps To Reproduce

image

Public Sample App

No response

Environment

Deploy Preview

Severity

Medium (Frustrating UX)

Issue video log

No response

Version

cloud
@ramsaptami ramsaptami added Bug Something isn't working WDS team labels May 7, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added Deploy Preview Issues found in Deploy Preview Medium Issues that frustrate users due to poor UX labels May 7, 2024
@github-actions github-actions bot added the Anvil Pod Issue related to Anvil project label May 7, 2024
@ramsaptami ramsaptami removed the Deploy Preview Issues found in Deploy Preview label May 8, 2024
@KelvinOm KelvinOm self-assigned this Jun 21, 2024
@KelvinOm KelvinOm mentioned this issue Jun 21, 2024
Merged
2 tasks
KelvinOm added a commit that referenced this issue Jun 24, 2024
@KelvinOm
fix: wds widgets (#34387)
70398df 
## Description
- Remove click event from Stats
- Remove validation section from SwitchGroup
- Fix Inline button variant for added button
- Fix paragraph default text
- Fix inputs placeholders

Fixes:
#34189 
#34002
#33753 
#33242
#33243
#33186
#32509

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9615117095>
> Commit: 15420c1
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9615117095&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Anvil`

<!-- end of auto-generated comment: Cypress test results  -->




## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Updated the placeholder text for input fields to provide more concise
and specific guidance.

- **Bug Fixes**
    - Adjusted button variant naming for better consistency.
- Improved text in `WDSParagraphWidget` to emphasize understanding
mysteries.

- **Refactor**
    - Removed unnecessary `onClick` prop from `StatsComponent`.
    - Simplified `getWidgetView` function in `WDSStatsWidget`.

- **Chores**
- Cleaned up redundant validation and required properties in
`WDSSwitchGroupWidget`.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this issue Jul 10, 2024
@KelvinOm @Shivam-z
fix: wds widgets (appsmithorg#34387)
7b2ff19 
## Description
- Remove click event from Stats
- Remove validation section from SwitchGroup
- Fix Inline button variant for added button
- Fix paragraph default text
- Fix inputs placeholders

Fixes:
appsmithorg#34189 
appsmithorg#34002
appsmithorg#33753 
appsmithorg#33242
appsmithorg#33243
appsmithorg#33186
appsmithorg#32509

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9615117095>
> Commit: 15420c1
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9615117095&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Anvil`

<!-- end of auto-generated comment: Cypress test results  -->




## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Updated the placeholder text for input fields to provide more concise
and specific guidance.

- **Bug Fixes**
    - Adjusted button variant naming for better consistency.
- Improved text in `WDSParagraphWidget` to emphasize understanding
mysteries.

- **Refactor**
    - Removed unnecessary `onClick` prop from `StatsComponent`.
    - Simplified `getWidgetView` function in `WDSStatsWidget`.

- **Chores**
- Cleaned up redundant validation and required properties in
`WDSSwitchGroupWidget`.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KelvinOm KelvinOm

Labels
Anvil Pod Issue related to Anvil project Bug Something isn't working Medium Issues that frustrate users due to poor UX WDS team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Nikhil-Nandagopal @KelvinOm @ramsaptami