Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WDS Toolbar Buttons polish #33395

Closed
KelvinOm opened this issue May 13, 2024 · 0 comments · Fixed by #33544
Closed

WDS Toolbar Buttons polish #33395

KelvinOm opened this issue May 13, 2024 · 0 comments · Fixed by #33544
Assignees
@KelvinOm
Labels
Anvil Pod Issue related to Anvil project High This issue blocks a user from building or impacts a lot of users potential-duplicate This label marks issues that are potential duplicates of already open issues Task A simple Todo WDS team
Milestone
R1 - Polish

Comments

@KelvinOm
Copy link
Collaborator

KelvinOm commented May 13, 2024 •
edited
Loading

  1. Add a default thumbup icon for a new button
  2. Add the ability to remove separators
@KelvinOm KelvinOm added Anvil Pod Issue related to Anvil project High This issue blocks a user from building or impacts a lot of users WDS team labels May 13, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added the Task A simple Todo label May 13, 2024
@github-actions github-actions bot added the potential-duplicate This label marks issues that are potential duplicates of already open issues label May 13, 2024
@appsmithorg appsmithorg deleted a comment from github-actions bot May 13, 2024
@appsmithorg appsmithorg deleted a comment from github-actions bot May 14, 2024
@KelvinOm KelvinOm self-assigned this May 14, 2024
@somangshu somangshu added this to the R1 - Polish milestone May 14, 2024
@jsartisan jsartisan mentioned this issue May 17, 2024
Merged
jsartisan added a commit that referenced this issue May 17, 2024
@jsartisan
chore: allow deleting toolbar + add icon for toolbar creation (#33544)
095524c 
Fixes: #33395 

/ok-to-test tags="@tag.Anvil"<!-- This is an auto-generated comment:
Cypress test results -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9127232599>
> Commit: 70759b8
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9127232599&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KelvinOm KelvinOm

Labels
Anvil Pod Issue related to Anvil project High This issue blocks a user from building or impacts a lot of users potential-duplicate This label marks issues that are potential duplicates of already open issues Task A simple Todo WDS team
Projects
None yet
Milestone
R1 - Polish
Development

Successfully merging a pull request may close this issue.

chore: allow deleting toolbar + add icon for toolbar creation appsmithorg/appsmith
3 participants
@Nikhil-Nandagopal @somangshu @KelvinOm