Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Fix Side by Side flag features for airgapped #33655

Closed
2 tasks
hetunandu opened this issue May 22, 2024 · 0 comments · Fixed by #33653
Closed
2 tasks

[Task]: Fix Side by Side flag features for airgapped #33655

hetunandu opened this issue May 22, 2024 · 0 comments · Fixed by #33653
Assignees
@hetunandu
Labels
IDE Navigation Issues/feature requests related to IDE navigation, and context switching New Developers Pod Issues that new developers face while exploring the IDE Task A simple Todo

Comments

@hetunandu
Copy link
Member

SubTasks

  • Add pane should have close button to close it without tabs
  • Remove the Edit actions in the header from the feature flag rules
@hetunandu hetunandu added Task A simple Todo IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod https://app.zenhub.com/workspaces/new-developers-pod-60507ad1d4b98d00150a2858/board labels May 22, 2024
@hetunandu hetunandu self-assigned this May 22, 2024
@github-actions github-actions bot added New Developers Pod Issues that new developers face while exploring the IDE and removed IDE Pod https://app.zenhub.com/workspaces/new-developers-pod-60507ad1d4b98d00150a2858/board labels May 22, 2024
@hetunandu hetunandu mentioned this issue May 22, 2024
Merged
2 tasks
NilanshBansal pushed a commit that referenced this issue May 24, 2024
@hetunandu
fix: Close button for Add pane when tabs are disabled (#33653)
228b40d 
## Description

- Segment add header gets a close button if the side by side flag is not
enabled
- Remove the edit menu item from header (not just for feature flag)

Fixes #33655

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9218769515>
> Commit: f92c783
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9218769515&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->


















## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hetunandu hetunandu

Labels
IDE Navigation Issues/feature requests related to IDE navigation, and context switching New Developers Pod Issues that new developers face while exploring the IDE Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Close button for Add pane when tabs are disabled appsmithorg/appsmith
1 participant
@hetunandu