Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Binding issue with insert data building block #33658

Closed
rahulbarwal opened this issue May 22, 2024 · 0 comments · Fixed by #33674
Closed

Bug: Binding issue with insert data building block #33658

rahulbarwal opened this issue May 22, 2024 · 0 comments · Fixed by #33674
Assignees
@rahulbarwal
Labels
Bug Something isn't working Building blocks Building blocks on cavas, on templates listing or drag and drop of building blocks. Low An issue that is neither critical nor breaks a user flow Medium Issues that frustrate users due to poor UX QA Pod Issues under the QA Pod QA Needs QA attention Templates Pod Issues related to Templates

Comments

@rahulbarwal
Copy link
Contributor

When we drop multiple Insert data building blocks, UI bindings(i.e. from one widget to another) are not getting updated correctly.
@rahulbarwal rahulbarwal added Bug Something isn't working Building blocks Building blocks on cavas, on templates listing or drag and drop of building blocks. Low An issue that is neither critical nor breaks a user flow Templates Pod Issues related to Templates labels May 22, 2024
@rahulbarwal rahulbarwal self-assigned this May 22, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added Critical This issue needs immediate attention. Drop everything else High This issue blocks a user from building or impacts a lot of users Medium Issues that frustrate users due to poor UX labels May 22, 2024
@rahulbarwal rahulbarwal removed Critical This issue needs immediate attention. Drop everything else High This issue blocks a user from building or impacts a lot of users labels May 22, 2024
@rahulbarwal rahulbarwal mentioned this issue May 23, 2024
Merged
2 tasks
rahulbarwal added a commit that referenced this issue May 29, 2024
@rahulbarwal @marks0351
fix: Handles button binding during buildingblock pasting (#33674)
bb39e4f 
## Description
This pull request adds the handleButtonDynamicTriggerPathList function
to the BuildingBlockAdditionSagas.ts file. This function is responsible
for handling the dynamic trigger path list for button widgets. It
iterates over the widgetNameMap and updates the dynamicTriggerPathList
of each button widget with the newWidgetName.

Additionally, unit tests have been added to ensure the correct
functionality of the handleButtonDynamicTriggerPathList function. This
change improves the functionality of button widgets when pasting
building block widgets.


Fixes #33658 
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Widget"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9268894716>
> Commit: a675a5c
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9268894716&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->




## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No

---------

Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
@appsmith-bot appsmith-bot added the QA Needs QA attention label May 29, 2024
@github-actions github-actions bot added the QA Pod Issues under the QA Pod label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahulbarwal rahulbarwal

Labels
Bug Something isn't working Building blocks Building blocks on cavas, on templates listing or drag and drop of building blocks. Low An issue that is neither critical nor breaks a user flow Medium Issues that frustrate users due to poor UX QA Pod Issues under the QA Pod QA Needs QA attention Templates Pod Issues related to Templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Handles button binding during buildingblock pasting appsmithorg/appsmith
3 participants
@Nikhil-Nandagopal @rahulbarwal @appsmith-bot