-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add PROPERTY
color constant in CodeEditorColors
#33699
chore: add PROPERTY
color constant in CodeEditorColors
#33699
Conversation
WalkthroughThe recent updates primarily focus on consolidating and centralizing the color definitions for syntax elements in the code editor by introducing a new constant object Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected. |
@hetunandu could you take a look in this PR as well? |
Ran this locally and it is building successfully. Merging the PR |
Description
The color for a code property is being used more than once but not available as a constant. This PR changes that.
I also moved the
CodeEditorColors
enum to a file where it's less likely to cause circular dependencies. It was moved from{...}/CodeEditor/styledComponents.ts
to{...}/CodeEditor/constants.ts
.Not related to an existing issue.
Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Caution
If you modify the content in this section, you are likely to disrupt the CI result for your PR.
Communication
Should the DevRel and Marketing teams inform users about this change?