Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Drag and drop via widget name is not supported #33842

Closed
1 task done
ramsaptami opened this issue May 30, 2024 · 0 comments · Fixed by #33843
Closed
1 task done

[Bug]: Drag and drop via widget name is not supported #33842

ramsaptami opened this issue May 30, 2024 · 0 comments · Fixed by #33843
Assignees
@marks0351
Labels
Anvil Pod Issue related to Anvil project Anvil team issues related to the new layout system anvil Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Verified When issue is retested post its fixed

Comments

@ramsaptami
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description

When multiple widgets are selected, they cannot be moved via widget label component

Steps To Reproduce

  1. Select multiple widget on canvas
  2. Try and move them by their label name
  3. Observe only selected widget moves

Public Sample App

No response

Environment

Deploy Preview

Severity

High (Blocker to building or releasing)

Issue video log

https://theappsmith.slack.com/files/U01MZDG0QTA/F075RJYNV42/screen_recording_2024-05-30_at_11.55.03___am.mov

Version

cloud
@ramsaptami ramsaptami added Bug Something isn't working Anvil team issues related to the new layout system anvil labels May 30, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added Deploy Preview Issues found in Deploy Preview High This issue blocks a user from building or impacts a lot of users labels May 30, 2024
@github-actions github-actions bot added the Anvil Pod Issue related to Anvil project label May 30, 2024
@riodeuno riodeuno mentioned this issue May 30, 2024
Merged
2 tasks
riodeuno added a commit that referenced this issue May 31, 2024
@riodeuno
fix: Anvil: Drag multiple widgets from widget name component (#33843)
1406adc 
## Description
- Fixes issue where we couldn't drag multiple widgets from the widget
name component

- Previous and incorrect implementation:
- When starting a drag from the widget name component, we force selected
the widget being dragged, so even if multiple widgets were selected,
only one would drag.

- Fix approach
- When starting a drag from the widget name component, we check if the
widget being dragged is focused. If it is focused, we select the widget
before dragging. Otherwise, we directly allow dragging without any
checks.
- The widget name component only shows up when the widget is either
focused or selected. If it is selected, we don't need to select any
widgets and whichever widgets are selected, they will be dragged.
However, if a widget is only focused, we need to make sure that the
intended widget is being dragged.


Fixes #33842 
## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9312310513>
> Commit: 171b9d3
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9312310513&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->








## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
@appsmith-bot appsmith-bot added the QA Needs QA attention label May 31, 2024
@github-actions github-actions bot added the QA Pod Issues under the QA Pod label May 31, 2024
@ramsaptami ramsaptami added Verified When issue is retested post its fixed and removed QA Needs QA attention labels Jun 6, 2024
@github-actions github-actions bot removed the QA Pod Issues under the QA Pod label Jun 6, 2024
@ramsaptami ramsaptami removed the Deploy Preview Issues found in Deploy Preview label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marks0351 marks0351

Labels
Anvil Pod Issue related to Anvil project Anvil team issues related to the new layout system anvil Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Verified When issue is retested post its fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Anvil: Drag multiple widgets from widget name component appsmithorg/appsmith
4 participants
@Nikhil-Nandagopal @marks0351 @appsmith-bot @ramsaptami