Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError: Cannot convert undefined or null to object #34141

Closed
sentry-io bot opened this issue Jun 10, 2024 · 0 comments · Fixed by #34142
Closed

TypeError: Cannot convert undefined or null to object #34141

sentry-io bot opened this issue Jun 10, 2024 · 0 comments · Fixed by #34142
Assignees
@rajatagrawal
Labels
Task A simple Todo

Comments

@sentry-io
Copy link

sentry-io bot commented Jun 10, 2024

Sentry Issue: APPSMITH-99R

TypeError: Cannot convert undefined or null to object
  at Function.entries (<anonymous>)
  at setAttributesToSpan (UITelemetry/generateTraces.ts:87:8)
  at call (utils/WorkerUtil.ts:290:9)
  at Array.forEach (<anonymous>)
  at Array.forEach (<anonymous>)
...
(45 additional frame(s) were not displayed)
@Nikhil-Nandagopal Nikhil-Nandagopal added the Task A simple Todo label Jun 10, 2024
@rajatagrawal rajatagrawal mentioned this issue Jun 10, 2024
Merged
2 tasks
rajatagrawal added a commit that referenced this issue Jun 11, 2024
@rajatagrawal
chore: Add a check if span attributes is present or not (#34142)
9bd55f2 
Fix crash on empty attributes. Fixes #34141

Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9449423201>
> Commit: 57170b0
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9449423201&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->




## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Improved error handling in worker telemetry to prevent setting
attributes on a span when `__spanAttributes` is not present.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rajatagrawal rajatagrawal

Labels
Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Add a check if span attributes is present or not appsmithorg/appsmith
2 participants
@rajatagrawal @Nikhil-Nandagopal