Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat]: Update implementation of validateDatasource for snowflake along with JUnit test cases #34465

Closed
rohan-arthur opened this issue Jun 25, 2024 · 0 comments · Fixed by #34491
Closed

[Feat]: Update implementation of validateDatasource for snowflake along with JUnit test cases #34465

rohan-arthur opened this issue Jun 25, 2024 · 0 comments · Fixed by #34491
Assignees
@AmanAgarwal041
Labels
Backend This marks the issue or pull request to reference server code Datasources Issues related to configuring datasource on appsmith Integrations Product Issues related to a specific integration Query & JS Pod Issues related to the query & JS Pod snowflake Issues related to the snowflake Integration Task A simple Todo

Comments

@rohan-arthur
Copy link
Contributor

rohan-arthur commented Jun 25, 2024 •
edited by AmanAgarwal041

Validate the Snowflake datasource for both test datasource as well as save for key pair auth type selected.

  • No file is uploaded in privateKey field and if test datasource is clicked, we throw appropriate error
  • If username is empty then we should see the error

https://www.notion.so/Update-implementation-of-validateDatasource-for-snowflake-along-with-JUnit-test-cases-3ef5a978ace94f7caaf8eb8895517e36
@rohan-arthur rohan-arthur added the Task A simple Todo label Jun 25, 2024
@AmanAgarwal041 AmanAgarwal041 changed the title Update implementation of validateDatasource for snowflake along with JUnit test cases [Feat]: Update implementation of validateDatasource for snowflake along with JUnit test cases Jun 25, 2024
@AmanAgarwal041 AmanAgarwal041 added snowflake Issues related to the snowflake Integration Datasources Issues related to configuring datasource on appsmith labels Jun 25, 2024
@AmanAgarwal041 AmanAgarwal041 self-assigned this Jun 25, 2024
@AmanAgarwal041 AmanAgarwal041 added the Backend This marks the issue or pull request to reference server code label Jun 25, 2024
@github-actions github-actions bot added the Integrations Product Issues related to a specific integration label Jun 25, 2024
@AmanAgarwal041 AmanAgarwal041 mentioned this issue Jun 26, 2024
Merged
2 tasks
@coderabbitai coderabbitai bot mentioned this issue Jul 1, 2024
Merged
2 tasks
@coderabbitai coderabbitai bot mentioned this issue Jul 9, 2024
Merged
2 tasks
@Nikhil-Nandagopal Nikhil-Nandagopal added the Query & JS Pod Issues related to the query & JS Pod label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AmanAgarwal041 AmanAgarwal041

Labels
Backend This marks the issue or pull request to reference server code Datasources Issues related to configuring datasource on appsmith Integrations Product Issues related to a specific integration Query & JS Pod Issues related to the query & JS Pod snowflake Issues related to the snowflake Integration Task A simple Todo
Projects
None yet
Milestone
No milestone
3 participants
@Nikhil-Nandagopal @AmanAgarwal041 @rohan-arthur