Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old Gitlab CI build scripts #573

Closed
mohanarpit opened this issue Sep 18, 2020 · 4 comments · Fixed by #865
Closed

Remove old Gitlab CI build scripts #573

mohanarpit opened this issue Sep 18, 2020 · 4 comments · Fixed by #865
Assignees
@mohanarpit @ari-hacks
Labels
Backend This marks the issue or pull request to reference server code Enhancement New feature or request Good First Issue Good for newcomers hacktoberfest All issues that can be solved by the community during Hacktoberfest

Comments

@mohanarpit
Copy link
Member

mohanarpit commented Sep 18, 2020 •
edited
Loading

Summary

Remove older build scripts .gitlab-ci.yml from the entire code base as we no longer use Gitlab CI and have migrated to using Github Actions for building & testing Appsmith.

Motivation

Having redundant files in the codebase can lead to confusion for new contributors.
@mohanarpit mohanarpit added the Enhancement New feature or request label Sep 18, 2020
@mohanarpit mohanarpit added the Good First Issue Good for newcomers label Sep 18, 2020
@Nikhil-Nandagopal Nikhil-Nandagopal removed their assignment Sep 21, 2020
@mohanarpit mohanarpit added the Backend This marks the issue or pull request to reference server code label Sep 23, 2020
@ari-hacks
Copy link
Contributor

👋🏾 I'd like to take this one.

@Nikhil-Nandagopal Nikhil-Nandagopal added the hacktoberfest All issues that can be solved by the community during Hacktoberfest label Sep 30, 2020
@ari-hacks
Copy link
Contributor

Hey, @mohanarpit @Nikhil-Nandagopal is this issue up for grabs?

@mohanarpit
Copy link
Member Author

@ari-hacks Yes. It's still available. Would you like to have a go at it?

@ari-hacks
Copy link
Contributor

Yea, thanks!

This was referenced Oct 1, 2020
Closed
Merged
@hetunandu hetunandu linked a pull request Oct 1, 2020 that will close this issue
removed gitlab-ci #865
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mohanarpit mohanarpit

@ari-hacks ari-hacks

Labels
Backend This marks the issue or pull request to reference server code Enhancement New feature or request Good First Issue Good for newcomers hacktoberfest All issues that can be solved by the community during Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removed gitlab-ci ari-hacks/appsmith
4 participants
@mohanarpit @Nikhil-Nandagopal @ari-hacks @appsmith-bot