Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Map pin does not center when location is changed and centering option is turned on #9844

Closed
1 task done
ramsaptami opened this issue Dec 17, 2021 · 9 comments · Fixed by #10296 or #15217
Closed
1 task done
Assignees
Labels
App Viewers Pod This label assigns issues to the app viewers pod Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Map Widget Regressed Scenarios that were working before but have now regressed Release Reopen Verified When issue is retested post its fixed

Comments

@ramsaptami
Copy link
Contributor

ramsaptami commented Dec 17, 2021

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Pinned location should move when location changes on the map when Map & marker centering is turned on. Currently, the pin moves as location changes but manual intervention is needed to center or even bring the pin into view since it does not auto-adjust.

LOOM DEMO

Steps To Reproduce

  1. Open up map widget with map & marker centering turned on and bind location using watchPosition() on a button trigger as seen in the video
  2. Change user location using sensor
  3. Observe the pin position move but map view remain the same - this needs to dynamically change as per setting

Environment

Release

Version

Cloud

@somangshu
Copy link
Contributor

The functionality is actually to center the pointer on click. We have to think about another way to achieve this

@wmdev0808 @jsartisan any solution in mind?

@wmdev0808
Copy link
Contributor

@somangshu ,
I've reviewed the issue and gave it a try.
Please assign this issue to me so I can make the commit on my solution

@somangshu somangshu assigned wmdev0808 and unassigned somangshu Dec 17, 2021
@somangshu somangshu added the Low An issue that is neither critical nor breaks a user flow label Dec 17, 2021
@ramsaptami ramsaptami added the High This issue blocks a user from building or impacts a lot of users label Jan 7, 2022
@dilippitchika dilippitchika removed UI Improvement UX Improvement Low An issue that is neither critical nor breaks a user flow labels Jan 7, 2022
@close-label close-label bot added the QA Needs QA attention label Feb 9, 2022
@ramsaptami ramsaptami added Verified When issue is retested post its fixed and removed QA Needs QA attention labels Feb 10, 2022
@ramsaptami ramsaptami removed the Verified When issue is retested post its fixed label Jun 22, 2022
@ramsaptami
Copy link
Contributor Author

This isn't working again

@ramsaptami ramsaptami reopened this Jun 22, 2022
@ramsaptami ramsaptami added the Regressed Scenarios that were working before but have now regressed label Jun 22, 2022
@somangshu
Copy link
Contributor

The only change made here Approx 2 months ago was with #9714 (App theming) and #12962 (map centring issue).

Seems like the change in #12962 could be causing this. @techbhavin kindly verify this and do make sure that you add test case this time to avoid regression.

@techbhavin
Copy link
Contributor

@ramsaptami @somangshu

As per my testing, I am not able to reproduce my issue. I attached the Below video for reference.
Let me know if I am following the wrong step.

Application Link: https://release.app.appsmith.com/app/common-testing-application/page-62be8b496d836615ef8a90ac

Screen.Recording.2022-07-01.at.1.32.32.PM.mov

@ramsaptami
Copy link
Contributor Author

Seems like the issue appears when accessing lat and long values from stored value. Directly accessing it from the geolocation function works as expected

@techbhavin
Copy link
Contributor

@somangshu
any update for me on this issue?

@techbhavin
Copy link
Contributor

@ramsaptami can you plz share the step and application to reproduce this issue.

@ramsaptami
Copy link
Contributor Author

Bind lat and long from Appsmith store values - something like {{appsmith.store.lat}} {{appsmith.store.long}}
Observe that the value is read as a string and not number
image

@close-label close-label bot added the QA Needs QA attention label Jul 20, 2022
@ramsaptami ramsaptami added Verified When issue is retested post its fixed and removed QA Needs QA attention labels Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Viewers Pod This label assigns issues to the app viewers pod Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Map Widget Regressed Scenarios that were working before but have now regressed Release Reopen Verified When issue is retested post its fixed
Projects
None yet
7 participants