Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changed the marker(default) value string to number #15217

Merged
merged 1 commit into from Jul 20, 2022

Conversation

techbhavin
Copy link
Contributor

Description

Map widget is not working properly when I change the default value of lat and lang to string. so I changed the default value string to a number.

Fixes #9844

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Drop a Map widget on canvas
  • Set the default value to { "lat": "25.122", "long": "50.132", "title": "Location1" }
  • Look the map is not showing any marker on the Map widget.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@techbhavin techbhavin added the App Viewers Pod This label assigns issues to the app viewers pod label Jul 14, 2022
@vercel
Copy link

vercel bot commented Jul 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Jul 14, 2022 at 0:42AM (UTC)

@techbhavin
Copy link
Contributor Author

/ok-to-test sha=61ad345

@github-actions github-actions bot added Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Map Widget Regressed Scenarios that were working before but have now regressed Release Reopen labels Jul 14, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2670516648.
Workflow: Appsmith External Integration Test Workflow.
Commit: 61ad345.
PR: 15217.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2670516648.
Commit: 61ad345.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1215.43 1313.49 1168.98 1124.39 1135.7 1168.98 1191.6 6.44 5.76
painting 9.62 9.78 10.09 15.06 6.17 9.78 10.14 31.36 28.01
rendering 621.86 701.77 620.83 604.17 599.71 620.83 629.67 6.59 5.89
SELECT_WIDGET_SELECT_OPTION
scripting 156.94 157.44 153.1 154.78 152.63 154.78 154.98 1.41 1.26
painting 7.62 3.66 4.14 3.95 4.19 4.14 4.71 34.82 31.21
rendering 10.41 9.84 10.62 8.98 10.41 10.41 10.05 6.67 5.97

@chandannkumar
Copy link

Tested this PR and working as expected

@techbhavin techbhavin merged commit 7ecca95 into release Jul 20, 2022
@techbhavin techbhavin deleted the fix/issue-9844 branch July 20, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Viewers Pod This label assigns issues to the app viewers pod Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Map Widget Regressed Scenarios that were working before but have now regressed Release Reopen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Map pin does not center when location is changed and centering option is turned on
3 participants