Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix margin top issues with checkbox form controls #10930

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

Irongade
Copy link
Contributor

@Irongade Irongade commented Feb 7, 2022

This PR fixes the margin top property for info texts beneath Checkboxes and other form controls.

Fixes #10783

  • Bug fix (non-breaking change which fixes an issue)

Manual tests.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🔴 Total coverage has decreased
// Code coverage diff between base branch:release and head branch: fix/fix-checkbox-info-text 
Status File % Stmts % Branch % Funcs % Lines
🔴 total 54.98 (-0.01) 36.32 (0) 34.67 (-0.01) 55.37 (0)
🔴 app/client/src/components/editorComponents/form/fields/StyledFormComponents.tsx 65.38 (-2.62) 15.56 (-0.35) 0 (0) 65.38 (-2.62)
🔴 app/client/src/pages/Editor/FormControl.tsx 24.44 (-1.14) 0 (0) 0 (0) 26.83 (0)

@vercel
Copy link

vercel bot commented Feb 7, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/get-appsmith/appsmith/4jZVCdT68LGP43MV8MFpKxfp6HBq
✅ Preview: https://appsmith-git-fix-fix-checkbox-info-text-get-appsmith.vercel.app

@Irongade
Copy link
Contributor Author

Irongade commented Feb 7, 2022

/ok-to-test sha=84f3240

@github-actions github-actions bot added the Bug Something isn't working label Feb 7, 2022
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1805525796.
Workflow: Appsmith External Integration Test Workflow.
Commit: 84f3240.
PR: 10930.

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1805525796.
Commit: 84f3240.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
Click on table row
scripting 3262 2476.84 2701.53 2719.21 2637.89 2701.53 2759.49 10.75 9.62
painting 16.52 15.18 11.44 13 47.39 15.18 20.71 72.62 64.99
rendering 429.81 273.79 274.08 328.89 323.5 323.5 326.01 19.53 17.47
Edit input
scripting 395.85 456.04 334.73 331.91 326.77 334.73 369.06 15.23 13.62
painting 8.54 22.73 20.51 4.71 21.52 20.51 15.6 53.46 47.82
rendering 22.81 20.27 14.21 15.88 12.56 15.88 17.15 24.90 22.27
Clear input
scripting 850.14 1226.59 877.84 867.14 846.71 867.14 933.68 17.59 15.73
painting 7.39 8.51 5.44 14.08 6.87 7.39 8.46 39.36 35.22
rendering 197.93 229.6 221.72 199.05 195.06 199.05 208.67 7.58 6.78
Edit input again
scripting 426.68 397.72 460.4 396.3 359.96 397.72 408.21 9.20 8.23
painting 24.23 14.5 12.45 8.91 14.52 14.5 14.92 38.07 34.05
rendering 26.07 26.19 33.95 26.56 37.96 26.56 30.15 18.21 16.29

@Irongade Irongade enabled auto-merge (squash) February 7, 2022 11:50
@Irongade Irongade merged commit da655b5 into release Feb 8, 2022
@Irongade Irongade deleted the fix/fix-checkbox-info-text branch February 8, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Appropriate spacing is not displayed to user under setting page
2 participants