Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixes numbering system for dynamic bindings in evaluated popup text #11005

Merged
merged 3 commits into from
Feb 11, 2022
Merged

fix: fixes numbering system for dynamic bindings in evaluated popup text #11005

merged 3 commits into from
Feb 11, 2022

Conversation

Irongade
Copy link
Contributor

@Irongade Irongade commented Feb 8, 2022 •
edited by github-actions bot

This PR fixes the distorted numbering of evaluated values in the evaluated pop up displayed.

Description

Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation
and context. List any dependencies that are required for this change.

Before:

After:
Screen Shot 2022-02-08 at 3 03 11 PM

Fixes #10525.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

⚪ Total coverage has not changed 
// Code coverage diff between base branch:release and head branch: fix/fix-evaluated-popup-text-issues
Status File % Stmts % Branch % Funcs % Lines
🔴 app/client/src/selectors/commentsSelectors.ts 83.61 (-1.64) 61.76 (-2.95) 73.33 (0) 88.24 (-2.35)
🟢 app/client/src/utils/autocomplete/TernServer.ts 52.94 (0.23) 41.67 (0.84) 36.21 (0) 56.99 (0.25)

@vercel
Copy link

vercel bot commented Feb 8, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/get-appsmith/appsmith/6nzEULRMUGTuRob75S1Ho3bfaeSg
✅ Preview: https://appsmith-git-fix-fix-evaluated-popup-text-issues-get-appsmith.vercel.app

@github-actions github-actions bot added the Bug Something isn't working label Feb 8, 2022
@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@Irongade
Copy link
Contributor Author

Irongade commented Feb 8, 2022

/ok-to-test sha=e4974b9

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1813193566.
Workflow: Appsmith External Integration Test Workflow.
Commit: e4974b9.
PR: 11005.

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1813193566.
Commit: e4974b9.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
Click on table row
scripting 2934.3 3782.13 2855.33 2933.52 2973.12 2934.3 3095.68 12.47 11.16
painting 47.26 69.69 18.26 42.64 15.74 42.64 38.72 57.67 51.58
rendering 402.27 673.3 378.65 393.59 408.99 402.27 451.36 27.60 24.69
Edit input
scripting 502.81 524.01 468.37 360.1 383.21 468.37 447.7 16.23 14.52
painting 16.77 21.07 8.42 10.83 23.78 16.77 16.17 40.45 36.18
rendering 23.2 24.46 22.69 20.85 33.25 23.2 24.89 19.49 17.44
Clear input
scripting 995.9 958.46 978.75 995.33 1289.21 995.33 1043.53 13.24 11.84
painting 9.02 19.58 7.28 10.94 12.43 10.94 11.85 40.00 35.78
rendering 288.19 270.57 267.43 269.83 272.73 270.57 273.75 3.03 2.71
Edit input again
scripting 431.5 506.56 501.36 458.03 477.35 477.35 474.96 6.55 5.86
painting 7.46 28.89 11.26 9.62 6.6 9.62 12.77 72.04 64.45
rendering 30.32 31.92 34.28 35.4 29.91 31.92 32.37 7.45 6.67

@nidhi-nair nidhi-nair added the BE Coders Pod Issues related to users writing code to fetch and update data label Feb 9, 2022
@Irongade
Copy link
Contributor Author

Irongade commented Feb 9, 2022

/ok-to-test sha=db17398

@github-actions
Copy link

github-actions bot commented Feb 9, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1818471921.
Workflow: Appsmith External Integration Test Workflow.
Commit: db17398.
PR: 11005.

@github-actions
Copy link

github-actions bot commented Feb 9, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1818471921.
Commit: db17398.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
Click on table row
scripting 2993.74 2302.04 2270.16 2303.11 2244.57 2302.04 2422.72 13.21 11.82
painting 30.7 9.13 18.2 44.9 15.64 18.2 23.71 59.85 53.56
rendering 438.62 263.45 324.18 318.42 276.68 318.42 324.27 21.29 19.05
Edit input
scripting 294.57 410.77 290.25 293.39 332.62 294.57 324.32 15.83 14.16
painting 34.47 10.37 16.03 20.03 12.01 16.03 18.58 51.88 46.39
rendering 17.39 29.79 15.93 16.11 25.55 17.39 20.95 30.26 27.06
Clear input
scripting 756.8 789.46 772.57 772.34 759.24 772.34 770.08 1.69 1.52
painting 9.87 6.45 11.14 13.54 5.61 9.87 9.32 35.30 31.65
rendering 187.93 188.19 190.16 185.74 190.39 188.19 188.48 1.01 0.90
Edit input again
scripting 288.25 313.73 297.85 347.13 293.67 297.85 308.13 7.72 6.90
painting 6.69 11.09 5.88 7.67 7 7 7.67 26.34 23.60
rendering 22.14 27.51 21.82 22.08 19.42 22.08 22.59 13.15 11.78

@Irongade
Copy link
Contributor Author

/ok-to-test sha=8f6e2f4

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1824180538.
Workflow: Appsmith External Integration Test Workflow.
Commit: 8f6e2f4.
PR: 11005.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1824180538.
Commit: 8f6e2f4.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
Select category
scripting 1732.07 3493.64 1702.79 3515.23 1759.42 1759.42 2440.63 39.80 35.60
painting 10.32 29.7 22.78 20.44 28.42 22.78 22.33 34.66 30.99
rendering 937.41 614.84 800.55 827.72 981.53 827.72 832.41 17.16 15.35
Bind table data
scripting 1937.93 1828.16 1712.89 1832.16 1617.66 1828.16 1785.76 6.90 6.17
painting 32.21 36.55 40.35 44.53 40.39 40.35 38.81 11.96 10.69
rendering 557.05 922.33 761.37 715.59 906.49 761.37 772.57 19.44 17.38
Click on table #comments
scripting 2209.44 2275.53 2390.71 2318.31 2908.4 2318.31 2420.48 11.59 10.37
painting 30.06 23.03 26.68 26.26 35.78 26.68 28.36 17.07 15.27
rendering 368.9 367.96 364.94 358.77 353.73 364.94 362.86 1.78 1.59
Update title
scripting 7389.05 8556.55 7456.24 6439.14 6464.79 7389.05 7261.15 12.01 10.74
painting 88.29 66.91 77.06 70.38 69.73 70.38 74.47 11.51 10.30
rendering 1388.89 1541.76 1351.56 1406.64 1325.01 1388.89 1402.77 5.99 5.35
Open modal
scripting 3627.59 1696.7 2039.93 1948.62 5466.58 2039.93 2955.88 54.01 48.31
painting 35.01 27.96 33.58 22.19 40.51 33.58 31.85 22.01 19.69
rendering 613.52 592.23 606.19 606.55 615.94 606.55 606.89 1.52 1.36
Close modal
scripting 1082.68 5650.76 3662.63 3009.45 1273.82 3009.45 2935.87 63.95 57.20
painting 19.36 25.76 39.01 20.71 18.49 20.71 24.67 34.45 30.81
rendering 668.13 646.31 704.18 643.78 561.04 646.31 644.69 8.17 7.30
Click on table row
scripting 2183.33 2299.56 2228.67 2048.76 2015.44 2183.33 2155.15 5.58 4.99
painting 24.7 12.54 27.19 26.06 18.69 24.7 21.84 28.11 25.18
rendering 292.09 275.58 257.84 249.79 240.07 257.84 263.07 7.91 7.07
Edit input
scripting 341.83 327.79 364.65 381.23 343.77 343.77 351.85 5.98 5.35
painting 25.86 10.94 15.52 14.85 12.2 14.85 15.87 37.11 33.21
rendering 20.43 25.58 15.93 28.38 18.9 20.43 21.84 23.17 20.70
Clear input
scripting 822.86 808.09 788.28 790.25 759.93 790.25 793.88 2.98 2.67
painting 11.4 6.45 6.78 5.85 9.16 6.78 7.93 29.13 26.10
rendering 197.89 178.07 184.61 188.77 199.4 188.77 189.75 4.74 4.24
Edit input again
scripting 326.83 334.12 548.99 332.03 301.45 332.03 368.68 27.57 24.66
painting 14.43 5.67 17.33 13.28 5.08 13.28 11.16 49.19 44.00
rendering 20.82 20.91 21.66 23.09 20.94 20.94 21.48 4.47 4.00

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1824180538.
Commit: 8f6e2f4.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
Select category
scripting 1732.07 3493.64 1702.79 3515.23 1759.42 1759.42 2440.63 39.80 35.60
painting 10.32 29.7 22.78 20.44 28.42 22.78 22.33 34.66 30.99
rendering 937.41 614.84 800.55 827.72 981.53 827.72 832.41 17.16 15.35
Bind table data
scripting 1937.93 1828.16 1712.89 1832.16 1617.66 1828.16 1785.76 6.90 6.17
painting 32.21 36.55 40.35 44.53 40.39 40.35 38.81 11.96 10.69
rendering 557.05 922.33 761.37 715.59 906.49 761.37 772.57 19.44 17.38
Click on table #comments
scripting 2209.44 2275.53 2390.71 2318.31 2908.4 2318.31 2420.48 11.59 10.37
painting 30.06 23.03 26.68 26.26 35.78 26.68 28.36 17.07 15.27
rendering 368.9 367.96 364.94 358.77 353.73 364.94 362.86 1.78 1.59
Update title
scripting 7389.05 8556.55 7456.24 6439.14 6464.79 7389.05 7261.15 12.01 10.74
painting 88.29 66.91 77.06 70.38 69.73 70.38 74.47 11.51 10.30
rendering 1388.89 1541.76 1351.56 1406.64 1325.01 1388.89 1402.77 5.99 5.35
Open modal
scripting 3627.59 1696.7 2039.93 1948.62 5466.58 2039.93 2955.88 54.01 48.31
painting 35.01 27.96 33.58 22.19 40.51 33.58 31.85 22.01 19.69
rendering 613.52 592.23 606.19 606.55 615.94 606.55 606.89 1.52 1.36
Close modal
scripting 1082.68 5650.76 3662.63 3009.45 1273.82 3009.45 2935.87 63.95 57.20
painting 19.36 25.76 39.01 20.71 18.49 20.71 24.67 34.45 30.81
rendering 668.13 646.31 704.18 643.78 561.04 646.31 644.69 8.17 7.30
Click on table row
scripting 2183.33 2299.56 2228.67 2048.76 2015.44 2183.33 2155.15 5.58 4.99
painting 24.7 12.54 27.19 26.06 18.69 24.7 21.84 28.11 25.18
rendering 292.09 275.58 257.84 249.79 240.07 257.84 263.07 7.91 7.07
Edit input
scripting 341.83 327.79 364.65 381.23 343.77 343.77 351.85 5.98 5.35
painting 25.86 10.94 15.52 14.85 12.2 14.85 15.87 37.11 33.21
rendering 20.43 25.58 15.93 28.38 18.9 20.43 21.84 23.17 20.70
Clear input
scripting 822.86 808.09 788.28 790.25 759.93 790.25 793.88 2.98 2.67
painting 11.4 6.45 6.78 5.85 9.16 6.78 7.93 29.13 26.10
rendering 197.89 178.07 184.61 188.77 199.4 188.77 189.75 4.74 4.24
Edit input again
scripting 326.83 334.12 548.99 332.03 301.45 332.03 368.68 27.57 24.66
painting 14.43 5.67 17.33 13.28 5.08 13.28 11.16 49.19 44.00
rendering 20.82 20.91 21.66 23.09 20.94 20.94 21.48 4.47 4.00

@Irongade Irongade merged commit 8110d04 into release Feb 11, 2022
@Irongade Irongade deleted the fix/fix-evaluated-popup-text-issues branch February 11, 2022 10:54
inaseem pushed a commit to namica/appsmith that referenced this pull request Feb 11, 2022
@Irongade
fixes numbering system for dynamic bindings in evaluated popup text (a…
c06c8b8 
…ppsmithorg#11005)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmanAgarwal041 AmanAgarwal041 AmanAgarwal041 approved these changes

@rashmi-rai rashmi-rai Awaiting requested review from rashmi-rai

Assignees
No one assigned
Labels
BE Coders Pod Issues related to users writing code to fetch and update data Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Postgres queries unable to execute with more than 9 placeholders
3 participants
@Irongade @AmanAgarwal041 @nidhi-nair