Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ssh key regeneration #11018

Merged
merged 3 commits into from
Feb 16, 2022
Merged

feat: ssh key regeneration #11018

merged 3 commits into from
Feb 16, 2022

Conversation

IAmAnubhavSaini
Copy link
Contributor

@IAmAnubhavSaini IAmAnubhavSaini commented Feb 9, 2022 •
edited by github-actions bot

Description

SSH Key can be regenerated in git-sync feature.

Fixes #10299

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Open git connect modal
  • Add URL of newly created repository
  • Click generate key
  • Click on more (three vertical dots icon) on the right of SSH key
  • Click Regenerate SSH Key
  • Click Yes

In already connected repo,

  • Click git settings icon, no need to update remote URL, and rest of the flow is same.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🟢 Total coverage has increased 
// Code coverage diff between base branch:release and head branch: 10299-ssh-key-regeneration
Status File % Stmts % Branch % Funcs % Lines
🟢 total 55.54 (0.09) 37.01 (0.01) 35.76 (0.37) 55.88 (0.04)
🟢 app/client/src/ce/constants/messages.ts 77.01 (2.34) 100 (0) 31.85 (6.93) 81.9 (1.78)
🟢 app/client/src/components/ads/Icon.tsx 53.65 (0.72) 37.85 (0.86) 100 (0) 53.55 (0.73)
🔴 app/client/src/utils/WorkerUtil.ts 89.76 (0) 70.59 (-1.96) 100 (0) 93.33 (0)
🔴 app/client/src/utils/helpers.tsx 67.09 (-0.32) 34.57 (-0.54) 60.38 (0) 65.31 (-0.4)
🟢 app/client/src/utils/autocomplete/TernServer.ts 52.94 (0.23) 41.67 (0.84) 36.21 (0) 56.99 (0.25)

@vercel
Copy link

vercel bot commented Feb 9, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/get-appsmith/appsmith/7z6cajZ2k3JkiihxVz14DcHCCLpo
✅ Preview: https://appsmith-git-10299-ssh-key-regeneration-get-appsmith.vercel.app

@github-actions github-actions bot added the Enhancement New feature or request label Feb 9, 2022
@github-actions
Copy link

github-actions bot commented Feb 9, 2022

Unable to find test scripts. Please add necessary tests to the PR.

2 similar comments
@github-actions
Copy link

github-actions bot commented Feb 9, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

github-actions bot commented Feb 9, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@IAmAnubhavSaini
Copy link
Contributor Author

So far the feature looks like:

2022-02-09_15-11-57.mp4

@IAmAnubhavSaini
Copy link
Contributor Author

Recording of feature working on local:

2022-02-10_11-39-15.mp4

@IAmAnubhavSaini
Copy link
Contributor Author

Working on tests.

@IAmAnubhavSaini IAmAnubhavSaini marked this pull request as ready for review February 10, 2022 07:08
@IAmAnubhavSaini
Copy link
Contributor Author

/ok-to-test sha=:28ce868

@IAmAnubhavSaini
Copy link
Contributor Author

Updated with system notification on key regeneration.

2022-02-10_19-15-53.mp4

@IAmAnubhavSaini
Copy link
Contributor Author

/ok-to-test sha=6372ac4

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1827685342.
Workflow: Appsmith External Integration Test Workflow.
Commit: 6372ac4.
PR: 11018.

@IAmAnubhavSaini
Copy link
Contributor Author

/ok-to-test sha=6372ac4

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1827909301.
Workflow: Appsmith External Integration Test Workflow.
Commit: 6372ac4.
PR: 11018.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1827909301.
Commit: 6372ac4.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
Select category
scripting 1785.23 1834.49 1816.33 1913.14 3387.23 1834.49 2147.28 32.36 28.94
painting 23.73 23.79 23.52 31.85 13.3 23.73 23.24 28.36 25.34
rendering 908.42 697.28 955.89 619.81 919.16 908.42 820.11 18.42 16.47
Bind table data
scripting 1952.98 1485.38 1577.26 1839.76 2726.4 1839.76 1916.36 25.62 22.91
painting 45.91 30.9 68.96 46.22 27.73 45.91 43.94 37.19 33.25
rendering 845.55 853.9 862.42 883.64 840.5 853.9 857.2 1.98 1.77
Click on table #comments
scripting 3078.36 3280.86 3347.91 2946.23 2881.11 3078.36 3106.89 6.56 5.86
painting 31.22 45.77 40.62 67.83 39.58 40.62 45 30.64 27.40
rendering 739.82 857.13 800.11 857.05 996.66 857.05 850.15 11.20 10.01
Update title
scripting 8215.29 6655.86 8205.01 5428.46 6793.43 6793.43 7059.61 16.67 14.91
painting 79.14 57.61 84.74 59.03 87.99 79.14 73.7 19.54 17.48
rendering 1447.76 1262.06 1319.46 1362.62 1671.45 1362.62 1412.67 11.31 10.11
Open modal
scripting 4523.25 1796.49 1851.04 1783.85 5413.3 1851.04 3073.59 57.20 51.16
painting 27.43 23.42 40.18 39.8 25.41 27.43 31.25 25.95 23.20
rendering 681.24 677.9 805.26 694.36 698.6 694.36 711.47 7.47 6.68
Close modal
scripting 1044.77 1258.66 964.81 4874.09 1035.08 1044.77 1835.48 92.74 82.95
painting 19.99 18.55 10.95 8.01 14.69 14.69 14.44 34.83 31.16
rendering 491.28 638.48 565.09 552.71 555.39 555.39 560.59 9.35 8.36
Click on table row
scripting 2324.46 2368.37 2417.07 2326.86 2312.34 2326.86 2349.82 1.84 1.64
painting 21.97 19.55 14.27 19.06 29.94 19.55 20.96 27.39 24.52
rendering 259.14 274.26 274.79 280.39 270.05 274.26 271.73 2.92 2.61
Edit input
scripting 289.94 300.85 343.88 270.44 302.31 300.85 301.48 8.92 7.98
painting 4.94 4.87 4.72 4.45 4.39 4.72 4.67 5.35 4.71
rendering 11.83 14.21 16.18 14.52 13.73 14.21 14.09 11.14 9.94
Clear input
scripting 809.17 771.91 794.05 742.79 807.06 794.05 785 3.55 3.17
painting 8.84 16.9 6.62 6.54 16.93 8.84 11.17 47.72 42.70
rendering 202.47 179.22 196.42 191.02 183.09 191.02 190.44 4.99 4.46
Edit input again
scripting 313.26 301.03 282.87 289.28 329.02 301.03 303.09 6.13 5.48
painting 18.53 4.75 9.22 11.91 14.23 11.91 11.73 44.25 39.56
rendering 22.22 24.2 18.35 18.98 23.29 22.22 21.41 12.19 10.88

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1842980536.
Workflow: Appsmith External Integration Test Workflow.
Commit: 113bee1.
PR: 11018.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1842980536.
Commit: 113bee1.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
Select category
scripting 1903.45 1901.26 3914.79 1869.43 3910.31 1903.45 2699.85 41.01 36.68
painting 10.92 27.78 10.83 16.21 10.11 10.92 15.17 49.18 43.97
rendering 1047.95 915.58 1096.9 907.01 984.91 984.91 990.47 8.33 7.45
Bind table data
scripting 2555.42 2597.06 2673.02 2791.72 2363.75 2597.06 2596.19 6.09 5.44
painting 17.5 38.92 36.06 20.63 42.24 36.06 31.07 36.14 32.31
rendering 1069.76 1116.89 1314.29 1189.89 1125.61 1125.61 1163.29 8.14 7.28
Click on table #comments
scripting 3044.09 3491.12 3257.72 3809.55 3843.03 3491.12 3489.1 9.92 8.88
painting 36.95 39.67 25.33 66.97 46.37 39.67 43.06 35.72 31.93
rendering 1175.55 1351.18 1261.15 1124.78 1479.12 1261.15 1278.36 11.07 9.90
Update title
scripting 7992.62 8717.45 7001.73 7453.62 7526.99 7526.99 7738.48 8.40 7.52
painting 81.97 83.28 62.85 63.99 48.92 63.99 68.2 21.19 18.94
rendering 2682.18 2374.27 2117.87 2383.2 1992.23 2374.27 2309.95 11.57 10.35
Open modal
scripting 2476.92 6471.49 4970.42 7173.57 5834.43 5834.43 5385.37 33.74 30.18
painting 22.62 42.52 30.21 44.21 55.5 42.52 39.01 32.86 29.40
rendering 1190.86 1144.96 1250.96 1206.53 1134.39 1190.86 1185.54 4.00 3.58
Close modal
scripting 1233.56 1264.71 4161.1 1072.19 1344.81 1264.71 1815.27 72.45 64.80
painting 33.24 10.32 24.11 16.88 8.13 16.88 18.54 55.66 49.78
rendering 925.25 803.54 898.66 810.99 904.25 898.66 868.54 6.55 5.86
Click on table row
scripting 2687.16 2736.37 2773.84 2747.1 2626.08 2736.37 2714.11 2.15 1.92
painting 41.24 35.04 35.54 31.41 31.99 35.04 35.04 11.16 9.99
rendering 470.99 426.87 389.57 396.51 416.87 416.87 420.16 7.65 6.85
Edit input
scripting 368.74 349.78 396.31 332.96 469.62 368.74 383.48 13.98 12.50
painting 12.82 8.07 46.49 11.59 47.8 12.82 25.35 78.78 70.49
rendering 15.94 14.98 16.77 12 19.2 15.94 15.78 16.67 14.89
Clear input
scripting 891.01 889.41 1118.8 1216.08 884.61 891.01 999.98 15.67 14.02
painting 11.96 9.92 19.65 37.84 11.79 11.96 18.23 63.52 56.83
rendering 266.67 255.82 257.99 355.83 251.65 257.99 277.59 15.88 14.20
Edit input again
scripting 368.04 326.2 364.65 325.83 355.18 355.18 347.98 5.92 5.29
painting 11.24 20.16 13.66 6.7 6.19 11.24 11.59 49.35 44.18
rendering 25.45 21.29 33.9 21.13 21.37 21.37 24.63 22.29 19.94

@IAmAnubhavSaini IAmAnubhavSaini enabled auto-merge (squash) February 15, 2022 08:58
@IAmAnubhavSaini
Copy link
Contributor Author

/ok-to-test sha=9f76d5db2cf1c65e9dc8717187ae2843a0a11603

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1845953082.
Workflow: Appsmith External Integration Test Workflow.
Commit: 9f76d5db2cf1c65e9dc8717187ae2843a0a11603.
PR: 11018.

@IAmAnubhavSaini
Copy link
Contributor Author

/ok-to-test sha=34f2883dd0a2385ca0cc448ae3e87d09de0e3a9f

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1846057295.
Workflow: Appsmith External Integration Test Workflow.
Commit: 34f2883dd0a2385ca0cc448ae3e87d09de0e3a9f.
PR: 11018.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1845953082.
Commit: 9f76d5db2cf1c65e9dc8717187ae2843a0a11603.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
Select category
scripting 1877.71 1872.49 1748.6 3606.2 1763.82 1872.49 2173.76 36.94 33.04
painting 22.43 66.95 14.53 25.6 19.73 22.43 29.85 70.79 63.32
rendering 894.68 931.92 814.96 905.46 989.99 905.46 907.4 7.00 6.26
Bind table data
scripting 2885.01 2199.42 2333.23 2262.74 2112.86 2262.74 2358.65 12.94 11.57
painting 18.67 29.72 12.86 29.7 17.01 18.67 21.59 35.71 31.91
rendering 891.18 928.34 890.56 977.4 972.59 928.34 932.01 4.52 4.05
Click on table #comments
scripting 3008.13 3621.74 2888.69 2969.55 2912.12 2969.55 3080.05 9.95 8.90
painting 39.7 52.31 60.19 38.26 32.45 39.7 44.58 25.44 22.75
rendering 789.31 967.88 776.84 793.46 813.26 793.46 828.15 9.56 8.55
Update title
scripting 8104.82 6356.36 6846.98 6344.63 6097.37 6356.36 6750.03 11.92 10.66
painting 50.05 58.38 89.69 62.69 59.86 59.86 64.13 23.45 20.97
rendering 1306.56 1476.24 1391.83 1458.98 1403.51 1403.51 1407.42 4.74 4.24
Open modal
scripting 1842.9 1840.55 1887.83 5006.44 1983.65 1887.83 2512.27 55.55 49.68
painting 20.54 17.13 21.69 19.4 22.68 20.54 20.29 10.60 9.46
rendering 737.39 691.82 694.24 689.88 738.14 694.24 710.29 3.54 3.16
Close modal
scripting 1022.97 1077.7 1510.24 943.8 976.04 1022.97 1106.15 20.92 18.72
painting 29.96 20 9.94 20.08 17.05 20 19.41 37.09 33.18
rendering 515.44 599.11 595.33 480.86 579.16 579.16 553.98 9.56 8.55
Click on table row
scripting 2409.52 2319.33 2376.08 2360.5 2343.65 2360.5 2361.82 1.44 1.29
painting 23.59 17.1 16.7 24.91 25.22 23.59 21.5 19.77 17.67
rendering 314.82 305.34 318.47 293.51 272.92 305.34 301.01 6.13 5.48
Edit input
scripting 374.17 397.65 363.4 312.16 381.72 374.17 365.82 8.88 7.94
painting 14.96 18.26 14.63 51.77 6.53 14.96 21.23 82.95 74.19
rendering 37.17 30.66 16.74 13.63 26.1 26.1 24.86 39.14 35.00
Clear input
scripting 756.43 768.05 768.97 782.93 795.96 768.97 774.47 1.97 1.76
painting 19.37 8.32 9.54 10.9 5.74 9.54 10.77 48.00 42.90
rendering 194.49 195.51 191.23 202.84 192.79 194.49 195.37 2.29 2.05
Edit input again
scripting 326.89 300.18 514.15 303.9 296.77 303.9 348.38 26.82 23.98
painting 13.68 12.5 39.64 6.41 9.56 12.5 16.36 81.42 72.80
rendering 21.26 30.28 42.82 20.32 35.42 30.28 30.02 31.78 28.41

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1846057295.
Commit: 34f2883dd0a2385ca0cc448ae3e87d09de0e3a9f.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
Select category
scripting 1815.57 3742.88 1733.41 1845.64 3755.72 1845.64 2578.64 41.47 37.10
painting 10.22 18.02 29.53 61.28 30.47 29.53 29.9 65.05 58.19
rendering 1159.89 1188.29 1196.05 1031.09 1142.42 1159.89 1143.55 5.81 5.20
Bind table data
scripting 2321.86 2180 2059.27 3077.92 2222.87 2222.87 2372.38 17.09 15.29
painting 24.74 23.66 40.2 35.75 47.17 35.75 34.3 29.42 26.30
rendering 928.93 991.81 1296.06 845.77 1066.08 991.81 1025.73 16.72 14.95
Click on table #comments
scripting 3657.1 4147.3 3991.94 3290.14 4162.88 3991.94 3849.87 9.69 8.67
painting 59.78 46.43 31.62 48.46 39.06 46.43 45.07 23.45 20.97
rendering 1126.23 1070.2 1193.14 1273.17 1118.42 1126.23 1156.23 6.81 6.09
Update title
scripting 11243.09 8320.21 6381.73 8705.76 11358.85 8705.76 9201.93 22.92 20.50
painting 83.05 82.56 127 77.86 96.14 83.05 93.32 21.45 19.18
rendering 2522.71 2088.15 2041.95 2510.54 1982.48 2088.15 2229.17 11.89 10.64
Open modal
scripting 2116.6 2023.2 6320.28 2660.81 2302.02 2302.02 3084.58 59.17 52.92
painting 29.83 47.89 26.73 44.48 20.13 29.83 33.81 35.17 31.44
rendering 978.98 914.27 1098.76 1144.16 1208.37 1098.76 1068.91 11.27 10.08
Close modal
scripting 1200.92 5223.77 6277.34 1074.16 1232.91 1232.91 3001.82 84.53 75.61
painting 14.41 21.55 23.63 11.52 19.58 19.58 18.14 27.78 24.86
rendering 844.39 911.09 841.3 764.48 929.97 844.39 858.25 7.64 6.84
Click on table row
scripting 2640.59 2558.46 2600.34 2605.75 2575.79 2600.34 2596.19 1.21 1.08
painting 21.12 28.94 36.46 14.75 33.2 28.94 26.89 33.06 29.56
rendering 363.87 383 421.71 361.38 351.4 363.87 376.27 7.40 6.62
Edit input
scripting 370.2 345.7 418.77 450.43 362.84 370.2 389.59 11.17 9.99
painting 5.23 5.29 15.51 10.21 26.96 10.21 12.64 71.68 64.08
rendering 15.95 21.7 32.48 29.1 25.54 25.54 24.95 25.81 23.09
Clear input
scripting 830.62 914.88 988.19 1072.75 1120.34 988.19 985.36 11.88 10.62
painting 6.5 27.22 17.02 5.99 12.89 12.89 13.92 62.79 56.18
rendering 228.64 237.02 305.95 244.44 293.75 244.44 261.96 13.48 12.05
Edit input again
scripting 335.71 356.96 414.46 391.68 351.91 356.96 370.14 8.67 7.75
painting 5.03 10.87 14.13 12.17 5.28 10.87 9.5 43.47 38.84
rendering 18.94 22.42 25.17 22.88 23.74 22.88 22.63 10.21 9.15

ankitakinger
ankitakinger reviewed Feb 16, 2022
View reviewed changes
Copy link
Contributor

@ankitakinger ankitakinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else LGTM.

app/client/src/ce/constants/messages.test.ts Show resolved Hide resolved
app/client/src/components/ads/NotificationBanner.tsx Outdated Show resolved Hide resolved
feat/ssh-key-regneration - implementation
e1f05b9 
- remove learn more and paste text from top
- introduce SSH Key label
- introduce ads/NotificationBanner
- update NotificationBanner integration
- jest tests
- system notification on key regeneration
- use @AppSmith for constants/messages
- update imports
- remove optional chaining
@IAmAnubhavSaini
Copy link
Contributor Author

/ok-to-test sha=e1f05b91aa7286bc790d61e1d7dab4fe3dd2b3b2

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1851458688.
Workflow: Appsmith External Integration Test Workflow.
Commit: e1f05b91aa7286bc790d61e1d7dab4fe3dd2b3b2.
PR: 11018.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1851458688.
Commit: e1f05b91aa7286bc790d61e1d7dab4fe3dd2b3b2.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
Select category
scripting 1906.59 1765.22 1965.81 1880.95 3668.84 1906.59 2237.48 35.91 32.12
painting 22.59 11.34 22.1 23.15 17.24 22.1 19.28 26.09 23.34
rendering 745.05 1107.08 901.12 957.55 885.38 901.12 919.24 14.24 12.74
Bind table data
scripting 2867.02 2148.06 2295 2291.75 2209.98 2291.75 2362.36 12.22 10.93
painting 14.86 25.26 20.2 25.59 32.27 25.26 23.64 27.58 24.66
rendering 1026.87 1111.34 917.35 913.39 860.21 917.35 965.83 10.50 9.39
Click on table #comments
scripting 2853.63 3696.49 3603.96 2851.19 4006.79 3603.96 3402.41 15.39 13.77
painting 47.86 51.86 28.17 29.02 34.49 34.49 38.28 28.58 25.55
rendering 861.17 756.07 792.49 830.55 744.87 792.49 797.03 6.16 5.51
Update title
scripting 6485.82 6445.68 5930.53 6901.95 6299.71 6445.68 6412.74 5.46 4.89
painting 55.44 64.46 56.07 59.69 53.05 56.07 57.74 7.71 6.89
rendering 1602.02 1505.03 1508.91 1394.6 1429.2 1505.03 1487.95 5.41 4.84
Open modal
scripting 2111.77 1886.81 1729.9 1896.23 3803.7 1896.23 2285.68 37.60 33.63
painting 20.27 21.08 23.25 19.04 16.59 20.27 20.05 12.32 11.02
rendering 752.1 791.43 735.18 690.06 679.82 735.18 729.72 6.28 5.62
Close modal
scripting 1838.32 1009.57 1072.4 943.33 3546.07 1072.4 1681.94 65.59 58.67
painting 14.04 27.77 22.68 10.83 16.5 16.5 18.36 37.15 33.22
rendering 603.83 614.11 561.29 548.51 636.39 603.83 592.83 6.22 5.56
Click on table row
scripting 2216.17 2184.87 2475.56 2267.78 2208.78 2216.17 2270.63 5.22 4.67
painting 17.16 29.67 26.78 30.85 21.98 26.78 25.29 22.50 20.13
rendering 257.16 253.26 294.33 286.18 299.55 286.18 278.1 7.72 6.91
Edit input
scripting 358.98 323.44 304.47 296.47 293.58 304.47 315.39 8.56 7.66
painting 7.58 15.85 5.83 6.97 40 7.58 15.25 94.43 84.46
rendering 20.32 15.11 13.32 12.52 13.88 13.88 15.03 20.63 18.50
Clear input
scripting 724.05 748.91 791.89 785.74 754.91 754.91 761.1 3.67 3.28
painting 22.21 6.91 5.99 6.66 10.03 6.91 10.36 65.64 58.78
rendering 189.84 184.38 181.74 205.57 173.16 184.38 186.94 6.44 5.76
Edit input again
scripting 289.07 306.84 269.41 291.23 248.29 289.07 280.97 8.04 7.19
painting 11.69 5.08 13.98 15.16 5.28 11.69 10.24 46.68 41.80
rendering 19.87 17.03 19.27 19.24 15.01 19.24 18.08 11.23 10.07

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1851458688.
Commit: e1f05b91aa7286bc790d61e1d7dab4fe3dd2b3b2.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
Select category
scripting 1906.59 1765.22 1965.81 1880.95 3668.84 1906.59 2237.48 35.91 32.12
painting 22.59 11.34 22.1 23.15 17.24 22.1 19.28 26.09 23.34
rendering 745.05 1107.08 901.12 957.55 885.38 901.12 919.24 14.24 12.74
Bind table data
scripting 2867.02 2148.06 2295 2291.75 2209.98 2291.75 2362.36 12.22 10.93
painting 14.86 25.26 20.2 25.59 32.27 25.26 23.64 27.58 24.66
rendering 1026.87 1111.34 917.35 913.39 860.21 917.35 965.83 10.50 9.39
Click on table #comments
scripting 2853.63 3696.49 3603.96 2851.19 4006.79 3603.96 3402.41 15.39 13.77
painting 47.86 51.86 28.17 29.02 34.49 34.49 38.28 28.58 25.55
rendering 861.17 756.07 792.49 830.55 744.87 792.49 797.03 6.16 5.51
Update title
scripting 6485.82 6445.68 5930.53 6901.95 6299.71 6445.68 6412.74 5.46 4.89
painting 55.44 64.46 56.07 59.69 53.05 56.07 57.74 7.71 6.89
rendering 1602.02 1505.03 1508.91 1394.6 1429.2 1505.03 1487.95 5.41 4.84
Open modal
scripting 2111.77 1886.81 1729.9 1896.23 3803.7 1896.23 2285.68 37.60 33.63
painting 20.27 21.08 23.25 19.04 16.59 20.27 20.05 12.32 11.02
rendering 752.1 791.43 735.18 690.06 679.82 735.18 729.72 6.28 5.62
Close modal
scripting 1838.32 1009.57 1072.4 943.33 3546.07 1072.4 1681.94 65.59 58.67
painting 14.04 27.77 22.68 10.83 16.5 16.5 18.36 37.15 33.22
rendering 603.83 614.11 561.29 548.51 636.39 603.83 592.83 6.22 5.56
Click on table row
scripting 2216.17 2184.87 2475.56 2267.78 2208.78 2216.17 2270.63 5.22 4.67
painting 17.16 29.67 26.78 30.85 21.98 26.78 25.29 22.50 20.13
rendering 257.16 253.26 294.33 286.18 299.55 286.18 278.1 7.72 6.91
Edit input
scripting 358.98 323.44 304.47 296.47 293.58 304.47 315.39 8.56 7.66
painting 7.58 15.85 5.83 6.97 40 7.58 15.25 94.43 84.46
rendering 20.32 15.11 13.32 12.52 13.88 13.88 15.03 20.63 18.50
Clear input
scripting 724.05 748.91 791.89 785.74 754.91 754.91 761.1 3.67 3.28
painting 22.21 6.91 5.99 6.66 10.03 6.91 10.36 65.64 58.78
rendering 189.84 184.38 181.74 205.57 173.16 184.38 186.94 6.44 5.76
Edit input again
scripting 289.07 306.84 269.41 291.23 248.29 289.07 280.97 8.04 7.19
painting 11.69 5.08 13.98 15.16 5.28 11.69 10.24 46.68 41.80
rendering 19.87 17.03 19.27 19.24 15.01 19.24 18.08 11.23 10.07

@IAmAnubhavSaini IAmAnubhavSaini merged commit 64669f5 into release Feb 16, 2022
@IAmAnubhavSaini IAmAnubhavSaini deleted the 10299-ssh-key-regeneration branch February 16, 2022 10:15
@IAmAnubhavSaini IAmAnubhavSaini self-assigned this Feb 18, 2022
@IAmAnubhavSaini IAmAnubhavSaini mentioned this pull request Feb 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitakinger ankitakinger ankitakinger approved these changes

@haojin111 haojin111 Awaiting requested review from haojin111

Assignees

@IAmAnubhavSaini IAmAnubhavSaini

Labels
Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] SSH key management
3 participants
@IAmAnubhavSaini @ankitakinger @haojin111