Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Comment icon gets hidden behind tabs on Tab widget #11019

Merged
merged 7 commits into from
Feb 12, 2022
Merged

fix: Comment icon gets hidden behind tabs on Tab widget #11019

merged 7 commits into from
Feb 12, 2022

Conversation

ankitakinger
Copy link
Contributor

@ankitakinger ankitakinger commented Feb 9, 2022 •
edited by github-actions bot

Description

Fixed UI for Comment icon which was getting hidden behind tabs on Tab widget.

Fixes #7396

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Go to the application
Drag and drop the container widget
Drag and drop the tab widget
Click on the comment icon
Drop the comment icon in the corner of the container
The icon is displayed properly without getting overlayed by tabs

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

⚪ Total coverage has not changed No changes to code coverage between the base branch and the head branch

@vercel
Copy link

vercel bot commented Feb 9, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/get-appsmith/appsmith/6HwzQM26MoYz1MZwjvtN1bccrNFp
✅ Preview: https://appsmith-git-hotfix-z-index-comment-icon-get-appsmith.vercel.app

@github-actions github-actions bot added the Bug Something isn't working label Feb 9, 2022
@github-actions
Copy link

github-actions bot commented Feb 9, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@ankitakinger
Copy link
Contributor Author

/ok-to-test sha=e55f3ad

@github-actions
Copy link

github-actions bot commented Feb 9, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1816946129.
Workflow: Appsmith External Integration Test Workflow.
Commit: e55f3ad.
PR: 11019.

@github-actions
Copy link

github-actions bot commented Feb 9, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1816946129.
Commit: e55f3ad.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
Click on table row
scripting 4558.85 2821.88 2827.21 2794.12 2730.33 2821.88 3146.48 25.12 22.47
painting 76.57 12.37 17.07 19.76 12.48 17.07 27.65 99.57 89.04
rendering 641.82 420.72 397.34 401.66 384.26 401.66 449.16 24.15 21.60
Edit input
scripting 430.42 388.12 482.32 440.84 431.24 431.24 434.59 7.72 6.91
painting 31.9 15.93 32.62 28.28 16.76 28.28 25.1 32.51 29.08
rendering 18.13 19.44 29.81 17.15 18.5 18.5 20.61 25.28 22.61
Clear input
scripting 1013.39 942.58 896.53 984.05 964.53 964.53 960.22 4.59 4.11
painting 7.28 7.24 6.08 12.56 16.91 7.28 10.01 45.95 41.16
rendering 265.07 283.41 276.16 286.3 274.64 276.16 277.12 3.00 2.68
Edit input again
scripting 427.08 427.26 364.46 364.15 408.77 408.77 398.34 8.03 7.18
painting 24.96 19.28 11.55 7.64 5.4 11.55 13.77 59.48 53.16
rendering 24.57 25.48 21.6 23.09 21.94 23.09 23.34 7.16 6.38

@ankitakinger
Copy link
Contributor Author

/ok-to-test sha=e55f3ad

@github-actions
Copy link

github-actions bot commented Feb 9, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1817491985.
Workflow: Appsmith External Integration Test Workflow.
Commit: e55f3ad.
PR: 11019.

@github-actions
Copy link

github-actions bot commented Feb 9, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1817491985.
Commit: e55f3ad.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
Click on table row
scripting 2500.98 2257.25 2282.17 2272.05 2281.96 2281.96 2318.88 4.41 3.95
painting 15.23 11 12.27 9.29 30.11 12.27 15.58 53.98 48.27
rendering 325.97 296.73 281.66 280.53 294.04 294.04 295.79 6.20 5.55
Edit input
scripting 441.6 364.98 338.3 295.03 358.29 358.29 359.64 14.83 13.26
painting 15.52 39.43 37.8 36.11 15.16 36.11 28.8 42.88 38.33
rendering 24.37 17.97 17.59 13.71 31.7 17.97 21.07 33.55 30.00
Clear input
scripting 789.08 775.41 791.08 710.11 756.28 775.41 764.39 4.37 3.91
painting 6.29 6.94 10.24 6.82 8 6.94 7.66 20.50 18.41
rendering 201.67 202.77 205.7 172.78 192.45 201.67 195.07 6.87 6.15
Edit input again
scripting 584.37 330.6 320.79 288.95 292.11 320.79 363.36 34.36 30.73
painting 8.64 9.1 6.84 14.18 6.8 8.64 9.11 33.15 29.64
rendering 25.76 24.52 20.33 22.65 21.27 22.65 22.91 9.78 8.77

@ankitakinger
Copy link
Contributor Author

/ok-to-test sha=a963a2b

@github-actions
Copy link

github-actions bot commented Feb 9, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1818505737.
Workflow: Appsmith External Integration Test Workflow.
Commit: a963a2b.
PR: 11019.

@github-actions
Copy link

github-actions bot commented Feb 9, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1818505737.
Commit: a963a2b.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
Click on table row
scripting 2312.27 2881.28 2241.55 2258.55 2306.44 2306.44 2400.02 11.28 10.09
painting 14.9 36.65 14.82 14.75 29.07 14.9 22.04 46.46 41.56
rendering 293.65 357.67 304.91 265.3 288.57 293.65 302.02 11.36 10.15
Edit input
scripting 319.8 328.34 333.15 319.98 353.4 328.34 330.93 4.17 3.73
painting 22 10.82 11.87 22.04 9.85 11.87 15.32 40.21 35.97
rendering 18.28 14.41 13.33 15.85 16.63 15.85 15.7 12.29 10.96
Clear input
scripting 819.22 745.18 788.2 749.63 764.9 764.9 773.43 3.96 3.54
painting 10.36 7.36 5.66 9.59 9.74 9.59 8.54 23.07 20.61
rendering 199.16 201.07 183.99 186.82 197.82 197.82 193.77 4.02 3.60
Edit input again
scripting 327.23 306.35 282.3 335.33 314.46 314.46 313.13 6.56 5.87
painting 18.1 8.11 8.74 11.4 7.45 8.74 10.76 40.61 36.34
rendering 24.58 24.3 22.09 20.46 22.59 22.59 22.8 7.41 6.62

@ankitakinger
Copy link
Contributor Author

/ok-to-test sha=a963a2b

@github-actions
Copy link

github-actions bot commented Feb 9, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1818862540.
Workflow: Appsmith External Integration Test Workflow.
Commit: a963a2b.
PR: 11019.

@github-actions
Copy link

github-actions bot commented Feb 9, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1818862540.
Commit: a963a2b.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
Click on table row
scripting 2323.6 2543.42 2416.8 2493.72 2417.71 2417.71 2439.05 3.44 3.08
painting 21.09 38.16 14.47 20.92 12.39 20.92 21.41 47.31 42.32
rendering 286.08 325.39 277.16 285.36 284.42 285.36 291.68 6.58 5.88
Edit input
scripting 335.53 347.39 352.57 360.35 387.85 352.57 356.74 5.49 4.91
painting 25.56 15.37 4.83 13.66 8.42 13.66 13.57 58.22 52.10
rendering 14.59 27.04 18.44 18.01 19.52 18.44 19.52 23.51 21.06
Clear input
scripting 852.52 892 929.9 847.63 890.78 890.78 882.57 3.81 3.41
painting 7.35 8.58 6.47 6.77 13.44 7.35 8.52 33.69 30.05
rendering 228.17 212.66 217.78 210.17 248.97 217.78 223.55 7.07 6.32
Edit input again
scripting 328.2 276.8 326.31 347.05 290.28 326.31 313.73 9.28 8.30
painting 15.55 11.77 4.72 8.36 4.63 8.36 9.01 52.16 46.61
rendering 20.4 17.28 20.83 35.97 19.27 20.4 22.75 33.05 29.54

@ankitakinger
Copy link
Contributor Author

/ok-to-test sha=a963a2b

@github-actions
Copy link

github-actions bot commented Feb 9, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1819407748.
Workflow: Appsmith External Integration Test Workflow.
Commit: a963a2b.
PR: 11019.

@github-actions
Copy link

github-actions bot commented Feb 9, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1819407748.
Commit: a963a2b.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
Click on table row
scripting 2782.37 2553.59 2513.86 2363.47 2435.62 2513.86 2529.78 6.29 5.62
painting 11.5 15.8 15.25 19.67 11.66 15.25 14.78 22.87 20.43
rendering 292.86 284.57 291.07 280.52 310.88 291.07 291.98 4.00 3.58
Edit input
scripting 371.87 330.54 361.12 318.36 404.09 361.12 357.2 9.54 8.54
painting 12.26 4.29 4.25 8.19 16.3 8.19 9.06 57.73 51.66
rendering 14.06 15.68 18.03 14.75 17.53 15.68 16.01 10.74 9.62
Clear input
scripting 871.07 856.7 934.18 900.4 901.8 900.4 892.83 3.37 3.02
painting 5.93 9.86 6.29 11.33 11.38 9.86 8.96 29.80 26.67
rendering 213.02 198.69 230.54 192.58 208.42 208.42 208.65 7.01 6.27
Edit input again
scripting 348.42 304.39 300.93 320.44 365.42 320.44 327.92 8.58 7.67
painting 9.25 4.61 5.22 5.82 12.39 5.82 7.46 44.10 39.41
rendering 23.6 24.37 19.94 28.34 24.87 24.37 24.22 12.43 11.11

@ankitakinger
Copy link
Contributor Author

/ok-to-test sha=a963a2b

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1821926851.
Workflow: Appsmith External Integration Test Workflow.
Commit: a963a2b.
PR: 11019.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1822090195.
Commit: a963a2b.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
Click on table row
scripting 3507.38 2649.83 2679.54 2727.71 2782.01 2727.71 2869.29 12.55 11.23
painting 27.27 14.03 18.62 24.07 10.51 18.62 18.9 36.56 32.70
rendering 794.46 343.88 387.98 346.18 358.49 358.49 446.2 43.81 39.18
Edit input
scripting 372.14 385.67 461.24 433.46 424.44 424.44 415.39 8.73 7.81
painting 6.84 6.48 11.29 29.95 6.22 6.84 12.16 83.55 74.75
rendering 17.01 18.91 24.64 17.82 19.47 18.91 19.57 15.28 13.64
Clear input
scripting 935.12 891.86 978.33 1040.37 885.03 935.12 946.14 6.83 6.11
painting 6.86 7.26 6.78 13.81 7.47 7.26 8.44 35.78 31.99
rendering 267.92 258.33 273.21 249.99 240.55 258.33 258 5.12 4.58
Edit input again
scripting 407.57 374.8 388.67 711.7 459.81 407.57 468.51 29.82 26.67
painting 7.21 5.31 7.52 6.7 10.2 7.21 7.39 24.22 21.65
rendering 26.65 23.35 25.12 28.89 30.91 26.65 26.98 11.08 9.93

@ankitakinger
Copy link
Contributor Author

/ok-to-test sha=a963a2b

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1824304604.
Workflow: Appsmith External Integration Test Workflow.
Commit: a963a2b.
PR: 11019.

@ankitakinger
Copy link
Contributor Author

/ok-to-test sha=a963a2b

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1827652788.
Workflow: Appsmith External Integration Test Workflow.
Commit: a963a2b.
PR: 11019.

@ankitakinger
Copy link
Contributor Author

/ok-to-test sha=a963a2b

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1827909141.
Workflow: Appsmith External Integration Test Workflow.
Commit: a963a2b.
PR: 11019.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1827909141.
Commit: a963a2b.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
Select category
scripting 3629.36 1652.54 1866.76 1605.96 3517 1866.76 2454.32 41.84 37.42
painting 20.36 44.22 31.13 51.4 11.47 31.13 31.72 51.86 46.41
rendering 947.96 945.97 963.65 936.69 817.2 945.97 922.29 6.46 5.77
Bind table data
scripting 1447.4 1707.64 1688.67 1630.46 1633.57 1633.57 1621.55 6.35 5.68
painting 32.57 20.81 36.17 28.09 34.56 32.57 30.44 20.30 18.13
rendering 816.73 850.81 841.09 823.67 828.11 828.11 832.08 1.65 1.48
Click on table #comments
scripting 2517.13 2660.24 2724.58 2609.01 2715.05 2660.24 2645.2 3.23 2.88
painting 59.99 42.76 36.51 33.14 55.67 42.76 45.61 25.81 23.09
rendering 881.82 823.21 705.05 764.58 774.91 774.91 789.91 8.40 7.52
Update title
scripting 5540.5 6179.85 7406.67 7517.36 5832.51 6179.85 6495.38 14.04 12.56
painting 92.33 88.03 56.16 76.82 68.6 76.82 76.39 19.19 17.16
rendering 1230.6 1511.29 1473.42 1679.32 1292.43 1473.42 1437.41 12.50 11.18
Open modal
scripting 5672.15 1726.96 1707.07 1601.25 1681.81 1707.07 2477.85 72.09 64.48
painting 16.41 14.73 31.82 23.95 27.19 23.95 22.82 31.60 28.26
rendering 679.04 691.81 648 645.45 639.38 648 660.74 3.51 3.14
Close modal
scripting 1974.74 1043.66 1260.82 1084.33 1321.79 1260.82 1337.07 28.05 25.09
painting 32.99 9.79 10.34 10.57 25.46 10.57 17.83 60.24 53.90
rendering 526.82 477.98 655.75 631.2 645.16 631.2 587.38 13.61 12.17
Click on table row
scripting 2420.65 2274.88 2187.74 2184.94 2115.36 2187.74 2236.71 5.25 4.69
painting 15.5 22.35 23.84 21.47 30.27 22.35 22.69 23.31 20.85
rendering 327.19 261.43 264.64 254.79 259.03 261.43 273.42 11.07 9.90
Edit input
scripting 374.63 298.45 290.55 285.35 369.89 298.45 323.77 13.76 12.31
painting 7.3 20.97 13.93 4.09 9.4 9.4 11.14 58.89 52.60
rendering 16.8 14.65 13.37 12.83 20.63 14.65 15.66 20.24 18.14
Clear input
scripting 699.26 703.27 723.3 734.98 729.42 723.3 718.05 2.22 1.98
painting 5.73 5.4 5.75 5.53 10.92 5.73 6.67 35.68 31.93
rendering 173.36 180.44 181.69 171.97 186.42 180.44 178.78 3.37 3.01
Edit input again
scripting 303.93 271.8 613.65 295.56 300.87 300.87 357.16 40.30 36.05
painting 4.85 5.47 3.71 6.19 4.77 4.85 5 18.40 16.40
rendering 16.99 16.34 16.23 21.18 18.37 16.99 17.82 11.56 10.33

@ankitakinger
Copy link
Contributor Author

/ok-to-test sha=a963a2b

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1828485390.
Workflow: Appsmith External Integration Test Workflow.
Commit: a963a2b.
PR: 11019.

@ankitakinger
Copy link
Contributor Author

/ok-to-test sha=39f25cb

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1828979497.
Workflow: Appsmith External Integration Test Workflow.
Commit: 39f25cb.
PR: 11019.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1828979497.
Commit: 39f25cb.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
Select category
scripting 1658.91 1942.98 1859.56 1911.91 3863.73 1911.91 2247.42 40.50 36.23
painting 30.33 13.94 62.38 13.49 11.49 13.94 26.33 81.77 73.15
rendering 1079.2 999.49 937.36 1011.63 1085.66 1011.63 1022.67 6.01 5.37
Bind table data
scripting 2412.45 2360.37 2015.39 2240.33 2624.3 2360.37 2330.57 9.63 8.61
painting 64.51 40.37 32.78 22.33 25.51 32.78 37.1 45.36 40.57
rendering 1089.02 1268.79 1246.34 1281.03 986.72 1246.34 1174.38 11.10 9.93
Click on table #comments
scripting 3113.62 2808.45 3073.07 3087.57 3886.49 3087.57 3193.84 12.72 11.38
painting 56.53 60.4 36.45 38.01 36.73 38.01 45.62 25.91 23.17
rendering 1014.78 1009.43 1042.19 928.19 981.69 1009.43 995.26 4.34 3.88
Update title
scripting 6769.67 7644.23 8302.92 8450.6 6111.12 7644.23 7455.71 13.45 12.03
painting 77.74 80.54 76.35 58.83 56.24 76.35 69.94 16.39 14.66
rendering 1780.64 2455.82 1893.3 2373.18 2154.07 2154.07 2131.4 13.76 12.31
Open modal
scripting 2031.71 2785.22 2693.03 2358.08 2503.14 2503.14 2474.24 12.04 10.77
painting 25.83 28.46 52.23 18.41 23.31 25.83 29.65 44.38 39.70
rendering 1029.34 1142.46 1120.31 1012.25 1071.99 1071.99 1075.27 5.23 4.68
Close modal
scripting 3212.79 2326.06 2046.26 2329.78 1396.66 2326.06 2262.31 28.88 25.84
painting 12.07 16.71 13.36 12.33 12.32 12.33 13.36 14.52 12.95
rendering 665.53 861.05 769.47 664.49 745.36 745.36 741.18 11.04 9.88
Edit input
scripting 1457.08 319.92 321.93 478.49 380.94 380.94 591.67 82.49 73.78
painting 4.33 9.72 13.92 9.61 35.59 9.72 14.63 83.39 74.57
rendering 13.67 14.39 17.73 31.2 18.57 17.73 19.11 37.05 33.12
Clear input
scripting 762.31 773.83 793.83 853.97 783.45 783.45 793.48 4.51 4.03
painting 10.69 6.42 5.95 6.61 14.73 6.61 8.88 42.57 38.06
rendering 231.12 222.29 210.27 242.85 228.03 228.03 226.91 5.27 4.71
Edit input again
scripting 434.87 310.97 309.55 295.5 387.88 310.97 347.75 17.46 15.61
painting 15.04 6.74 7.55 5.17 12.64 7.55 9.43 44.54 39.87
rendering 24.67 22.68 20.66 19.1 20.83 20.83 21.59 9.91 8.85

@ankitakinger
Copy link
Contributor Author

/ok-to-test sha=39f25cb

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1829759111.
Workflow: Appsmith External Integration Test Workflow.
Commit: 39f25cb.
PR: 11019.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1829759111.
Commit: 39f25cb.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
Select category
scripting 1785.25 1881.3 1892.34 3626.76 1690.82 1881.3 2175.29 37.49 33.53
painting 35.63 15.42 42.77 37.02 46.37 37.02 35.44 33.89 30.30
rendering 894.5 947.67 994.02 921.04 942.43 942.43 939.93 3.91 3.50
Bind table data
scripting 2083.91 2421.85 2185.76 2291.11 2150.01 2185.76 2226.53 5.95 5.32
painting 36.43 21.17 25.53 31.54 25.02 25.53 27.94 21.58 19.29
rendering 955.65 888.49 963.27 972.23 1051.67 963.27 966.26 6.01 5.38
Click on table #comments
scripting 2918.48 3013.7 2935.17 3834.73 3065.15 3013.7 3153.45 12.22 10.93
painting 47.62 46.74 28.35 48.33 51.14 47.62 44.44 20.57 18.41
rendering 768.25 806.44 864.77 847.23 739.46 806.44 805.23 6.51 5.83
Update title
scripting 5942.46 8997.56 6425.14 6187.85 6836.08 6425.14 6877.82 17.88 15.99
painting 63.15 67.51 54.74 71.17 58.41 63.15 63 10.54 9.43
rendering 1318.11 1437.87 1525.66 1458.01 1596.8 1458.01 1467.29 7.10 6.35
Open modal
scripting 2240.06 1819.38 1787.55 1850.62 3321.45 1850.62 2203.81 29.55 26.43
painting 27.7 23.86 29.73 36.4 29.51 29.51 29.44 15.46 13.82
rendering 745.76 708.54 701.74 786.59 697.66 708.54 728.06 5.20 4.65
Close modal
scripting 2620.91 1069.86 1291.95 5219.66 1081.42 1291.95 2256.76 78.75 70.43
painting 26.17 11.6 20.42 30 8.87 20.42 19.41 46.88 41.94
rendering 631.56 535 644.16 642.16 486.78 631.56 587.93 12.33 11.03
Click on table row
scripting 2472.8 2470.07 2454.22 2512.09 2498.48 2472.8 2481.53 0.94 0.84
painting 14.21 34.06 22.8 40.56 17.54 22.8 25.83 43.17 38.64
rendering 343.37 313.35 271.95 312.52 302.63 312.52 308.76 8.30 7.42
Edit input
scripting 306.34 317.32 463.6 395.3 309.87 317.32 358.49 19.32 17.28
painting 35.31 32 22.32 7.75 5.77 22.32 20.63 65.68 58.75
rendering 15.1 14.21 24.48 22.33 18.03 18.03 18.83 23.74 21.24
Clear input
scripting 772.19 753.35 800.93 784.26 774.11 774.11 776.97 2.24 2.01
painting 5.87 5.82 6.29 9.34 7.1 6.29 6.88 21.37 19.04
rendering 183 197.49 194 187.05 185.09 187.05 189.33 3.25 2.91
Edit input again
scripting 311.51 287.43 304.37 638.85 336.33 311.51 375.7 39.43 35.27
painting 25.41 12.42 10.99 5.71 14.11 12.42 13.73 52.80 47.20
rendering 36.39 21.77 18.97 22.15 23.8 22.15 24.62 27.66 24.74

@ankitakinger
Copy link
Contributor Author

/ok-to-test sha=39f25cb

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1830358073.
Workflow: Appsmith External Integration Test Workflow.
Commit: 39f25cb.
PR: 11019.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1830358073.
Commit: 39f25cb.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
Select category
scripting 1914.77 1922.05 1850.91 1906.42 1887.74 1906.42 1896.38 1.50 1.34
painting 27.73 18.82 10.21 11.99 10.59 11.99 15.87 47.20 42.22
rendering 930.1 947.19 1039.34 930.5 986.09 947.19 966.64 4.82 4.31
Bind table data
scripting 2401.61 2736.6 2830.93 2335.43 2503.56 2503.56 2561.63 8.36 7.47
painting 36.52 29.22 23.44 33.05 29.24 29.24 30.29 16.14 14.43
rendering 849.66 873.87 1045.33 805.93 906.03 873.87 896.16 10.16 9.09
Click on table #comments
scripting 3684.11 2845.41 3777.45 3879.69 3694.32 3694.32 3576.2 11.63 10.40
painting 25.4 35.17 35.82 34.82 51.46 35.17 36.53 25.68 22.97
rendering 782.96 801.28 763.91 802.95 752.93 782.96 780.81 2.85 2.55
Update title
scripting 6426.61 7126.78 5521.53 5916.59 6235.66 6235.66 6245.43 9.61 8.60
painting 56.4 53.52 85.82 56.71 82.11 56.71 66.91 23.42 20.95
rendering 1811.64 1452.83 1351 1344.32 1462.93 1452.83 1484.54 12.87 11.51
Open modal
scripting 1684.55 4987.77 1799.22 2022.98 1851.1 1851.1 2469.12 57.24 51.19
painting 21.45 18.79 30.32 15.4 41.86 21.45 25.56 41.71 37.28
rendering 695.9 658.03 764.88 671.76 717.87 695.9 701.69 6.00 5.37
Close modal
scripting 4397.17 1100.51 982.59 958.85 1136.16 1100.51 1715.06 87.53 78.29
painting 9.11 23.07 7.18 18.16 28.77 18.16 17.26 53.01 47.45
rendering 542.98 575.71 550.36 476.47 638.24 550.36 556.75 10.50 9.39
Click on table row
scripting 2335.44 2366.97 2423.19 2402.85 2289.82 2366.97 2363.65 2.25 2.01
painting 17.88 46.52 13.91 13.8 48.3 17.88 28.08 63.14 56.48
rendering 284.25 250.18 360.25 297.31 266.74 284.25 291.75 14.47 12.95
Edit input
scripting 511.14 333.24 345.1 332.32 282.68 333.24 360.9 24.20 21.65
painting 24.3 7.94 24.21 3.46 4.81 7.94 12.94 80.76 72.26
rendering 18.29 16.72 18.97 16.35 13.24 16.72 16.71 13.29 11.91
Clear input
scripting 738.75 752.13 699.43 741.71 774.23 741.71 741.25 3.67 3.28
painting 8.85 11.13 14.44 10.59 12.01 11.13 11.4 17.98 16.14
rendering 193.65 178.89 173.99 174.12 181.82 178.89 180.49 4.47 4.00
Edit input again
scripting 271.92 277.18 312.34 251.44 292.54 277.18 281.08 8.13 7.27
painting 6.86 3.78 7.44 4.04 4.68 4.68 5.36 31.34 27.99
rendering 21.14 17.6 19.3 16.62 20.79 19.3 19.09 10.32 9.22

@ankitakinger
Copy link
Contributor Author

/ok-to-test sha=7551a6c

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1830952540.
Workflow: Appsmith External Integration Test Workflow.
Commit: 7551a6c.
PR: 11019.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1830952540.
Commit: 7551a6c.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
Select category
scripting 2040.53 1815.3 3862.58 1869.71 1684.71 1869.71 2254.57 40.27 36.02
painting 24.74 11.53 10.96 19.54 28.27 19.54 19.01 40.72 36.40
rendering 1042.87 1122.28 1310.09 1128.61 1113.89 1122.28 1143.55 8.68 7.77
Bind table data
scripting 2159.34 2312.89 2910.76 2170.68 2178.3 2178.3 2346.39 13.71 12.26
painting 28.05 30.5 31.21 37.3 36.34 31.21 32.68 12.15 10.86
rendering 1119.72 1228.27 1145.9 1093.14 1149.04 1145.9 1147.21 4.41 3.95
Click on table #comments
scripting 2589.1 3217.48 3348.3 3382.99 2915.07 3217.48 3090.59 10.86 9.71
painting 49.97 46.37 41.53 42.1 55.9 46.37 47.17 12.64 11.30
rendering 1268.43 1466.72 1352.19 1155.36 1269.27 1269.27 1302.39 8.87 7.93
Update title
scripting 7120.78 8316.26 7810.1 10322 8185.99 8185.99 8351.03 14.32 12.81
painting 67.54 59.26 69.36 58.53 50.92 59.26 61.12 12.22 10.93
rendering 2419.32 2992.73 2406.88 2477.59 2181.64 2419.32 2495.63 12.02 10.75
Open modal
scripting 3664.8 6366.14 2573.23 4156.78 5599.66 4156.78 4472.12 33.94 30.36
painting 29.02 18.95 20.24 25.33 35.65 25.33 25.84 26.35 23.57
rendering 1028.97 1242.61 1298.74 1219.74 1135.93 1219.74 1185.2 8.87 7.93
Close modal
scripting 1184.97 1682.07 1454.98 1150.3 1479.9 1454.98 1390.44 15.96 14.28
painting 17.7 17.26 37.49 10.83 25.68 17.7 21.79 46.95 41.99
rendering 902.53 1005.46 1046.36 856.16 906.11 906.11 943.32 8.40 7.51
Edit input
scripting 425.03 391.93 449.7 431.97 482.84 431.97 436.29 7.65 6.85
painting 18.68 5.47 24.88 8.52 22.72 18.68 16.05 53.77 48.10
rendering 19.67 17.09 19.2 20.06 25.65 19.67 20.33 15.69 14.02
Clear input
scripting 957.28 988.37 1039.31 966.25 931.88 966.25 976.62 4.14 3.71
painting 7.78 8.48 9.91 13.56 6.7 8.48 9.29 28.63 25.62
rendering 274.81 276.38 292.23 273.21 297.55 276.38 282.84 3.97 3.55
Edit input again
scripting 443.1 350.02 433.03 373.78 357.25 373.78 391.44 11.13 9.96
painting 9.75 12.6 18.14 6.12 6.32 9.75 10.59 47.21 42.21
rendering 30.37 20.63 29.98 26.26 36.04 29.98 28.66 19.85 17.76

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1830952540.
Commit: 7551a6c.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
Select category
scripting 2040.53 1815.3 3862.58 1869.71 1684.71 1869.71 2254.57 40.27 36.02
painting 24.74 11.53 10.96 19.54 28.27 19.54 19.01 40.72 36.40
rendering 1042.87 1122.28 1310.09 1128.61 1113.89 1122.28 1143.55 8.68 7.77
Bind table data
scripting 2159.34 2312.89 2910.76 2170.68 2178.3 2178.3 2346.39 13.71 12.26
painting 28.05 30.5 31.21 37.3 36.34 31.21 32.68 12.15 10.86
rendering 1119.72 1228.27 1145.9 1093.14 1149.04 1145.9 1147.21 4.41 3.95
Click on table #comments
scripting 2589.1 3217.48 3348.3 3382.99 2915.07 3217.48 3090.59 10.86 9.71
painting 49.97 46.37 41.53 42.1 55.9 46.37 47.17 12.64 11.30
rendering 1268.43 1466.72 1352.19 1155.36 1269.27 1269.27 1302.39 8.87 7.93
Update title
scripting 7120.78 8316.26 7810.1 10322 8185.99 8185.99 8351.03 14.32 12.81
painting 67.54 59.26 69.36 58.53 50.92 59.26 61.12 12.22 10.93
rendering 2419.32 2992.73 2406.88 2477.59 2181.64 2419.32 2495.63 12.02 10.75
Open modal
scripting 3664.8 6366.14 2573.23 4156.78 5599.66 4156.78 4472.12 33.94 30.36
painting 29.02 18.95 20.24 25.33 35.65 25.33 25.84 26.35 23.57
rendering 1028.97 1242.61 1298.74 1219.74 1135.93 1219.74 1185.2 8.87 7.93
Close modal
scripting 1184.97 1682.07 1454.98 1150.3 1479.9 1454.98 1390.44 15.96 14.28
painting 17.7 17.26 37.49 10.83 25.68 17.7 21.79 46.95 41.99
rendering 902.53 1005.46 1046.36 856.16 906.11 906.11 943.32 8.40 7.51
Edit input
scripting 425.03 391.93 449.7 431.97 482.84 431.97 436.29 7.65 6.85
painting 18.68 5.47 24.88 8.52 22.72 18.68 16.05 53.77 48.10
rendering 19.67 17.09 19.2 20.06 25.65 19.67 20.33 15.69 14.02
Clear input
scripting 957.28 988.37 1039.31 966.25 931.88 966.25 976.62 4.14 3.71
painting 7.78 8.48 9.91 13.56 6.7 8.48 9.29 28.63 25.62
rendering 274.81 276.38 292.23 273.21 297.55 276.38 282.84 3.97 3.55
Edit input again
scripting 443.1 350.02 433.03 373.78 357.25 373.78 391.44 11.13 9.96
painting 9.75 12.6 18.14 6.12 6.32 9.75 10.59 47.21 42.21
rendering 30.37 20.63 29.98 26.26 36.04 29.98 28.66 19.85 17.76

@ankitakinger ankitakinger merged commit c29c2f7 into release Feb 12, 2022
@ankitakinger ankitakinger deleted the hotfix/z-index-comment-icon branch February 12, 2022 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albinAppsmith albinAppsmith albinAppsmith approved these changes

@rishabhsaxena rishabhsaxena Awaiting requested review from rishabhsaxena

@sbalaji1192 sbalaji1192 Awaiting requested review from sbalaji1192

@pranavkanade pranavkanade Awaiting requested review from pranavkanade

Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]z-index issues when user add comments in the container widget
2 participants
@ankitakinger @albinAppsmith