Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Mongo Templates for plugin. #11153

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

felixsuarez0727
Copy link
Contributor

@felixsuarez0727 felixsuarez0727 commented Feb 14, 2022

This is a cleaned up version of PR #10626 without client side code.

Description

Refer to: #10626.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

app/server/appsmith-plugins/mongoPlugin/src/test/java/com/external/plugins/MongoPluginTest.java

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This is a cleaned up version of PR #10626 without client side code.
@vercel
Copy link

vercel bot commented Feb 14, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/get-appsmith/appsmith/9UBEY5n38JW7bNwgQ5QvxEs8JYGF
✅ Preview: https://appsmith-git-feature-add-mongo-plugin-cmd-t-ca99c4-get-appsmith.vercel.app

@github-actions github-actions bot added the Enhancement New feature or request label Feb 14, 2022
@felixsuarez0727 felixsuarez0727 requested review from nidhi-nair and removed request for sumitsum February 15, 2022 00:16
Copy link
Contributor

@nidhi-nair nidhi-nair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What sort of client side changes do we need here? We should be able to see and use the templates with just these changes, yes?

@felixsuarez0727
Copy link
Contributor Author

/ok-to-test sha=473c3ee

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1846880014.
Workflow: Appsmith External Integration Test Workflow.
Commit: 473c3ee.
PR: 11153.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1846880014.
Commit: 473c3ee.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
Select category
scripting 2015.77 1771.32 1918.88 1828.65 1845.23 1845.23 1875.97 5.02 4.49
painting 24.38 24.86 33.42 30.45 24.94 24.94 27.61 14.81 13.26
rendering 990.82 1050.78 860.99 988.69 971.93 988.69 972.64 7.12 6.36
Bind table data
scripting 2185.64 1956.1 2310.34 2093.22 2303 2185.64 2169.66 6.89 6.16
painting 18.32 28.14 28.26 33.36 31.76 28.26 27.97 20.88 18.70
rendering 1192.5 1217.88 960.29 1043.93 948.02 1043.93 1072.52 11.83 10.58
Click on table #comments
scripting 3247.86 4083.63 3279.99 2896.98 3009.65 3247.86 3303.62 14.07 12.58
painting 56.04 48.47 79.71 47.07 38.81 48.47 54.02 28.90 25.84
rendering 965.25 941.62 989.33 973.35 1093.16 973.35 992.54 5.93 5.30
Update title
scripting 8471.96 11122.79 8222.37 10141.45 8005.78 8471.96 9192.87 14.89 13.32
painting 98.05 62.52 64.68 65.61 86.96 65.61 75.56 21.16 18.94
rendering 1650.06 1862.32 1965.65 1776.66 1723.52 1776.66 1795.64 6.83 6.11
Open modal
scripting 2213.2 2318.12 6986.29 4569.01 6045 4569.01 4426.32 48.63 43.50
painting 31.15 41.84 21.32 22.81 61.38 31.15 35.7 46.25 41.37
rendering 836.48 892.46 950.03 835.48 857.49 857.49 874.39 5.51 4.93
Close modal
scripting 1085.89 1198.55 1353.16 4151.09 2480.32 1353.16 2053.8 63.20 56.53
painting 18.9 22.27 10.42 26.11 16.83 18.9 18.91 31.25 27.92
rendering 603 626.7 608.12 621.91 588.95 608.12 609.74 2.48 2.22
Click on table row
scripting 3016.34 2759.65 2874.27 2697.45 2782.17 2782.17 2825.98 4.38 3.92
painting 19.37 19.31 15.07 13.6 19.64 19.31 17.4 16.38 14.66
rendering 359.6 340.51 330.87 335.2 335.41 335.41 340.32 3.32 2.97
Edit input
scripting 459.64 410.44 361.61 376.33 364.9 376.33 394.58 10.44 9.34
painting 21.85 6.63 8.88 11.98 16.26 11.98 13.12 46.27 41.39
rendering 22.19 19.85 17.36 31.01 16.13 19.85 21.31 27.69 24.78
Clear input
scripting 1008.5 1152.44 917.75 1220.39 920.46 1008.5 1043.91 13.15 11.76
painting 8.07 6.68 6.72 5.94 6.17 6.68 6.72 12.35 11.01
rendering 236.24 217.86 231.11 225.28 238.3 231.11 229.76 3.63 3.25
Edit input again
scripting 358.1 376.84 378.05 767.75 386.72 378.05 453.49 38.81 34.71
painting 15.21 9.64 7.02 8.66 12.26 9.64 10.56 30.49 27.27
rendering 20.64 28.75 27.59 22.22 23.55 23.55 24.55 14.22 12.71

@felixsuarez0727
Copy link
Contributor Author

/ok-to-test sha=473c3ee

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1847787855.
Workflow: Appsmith External Integration Test Workflow.
Commit: 473c3ee.
PR: 11153.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1847787855.
Commit: 473c3ee.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
Select category
scripting 1851.16 2016.39 1880.99 1823.63 1758.33 1851.16 1866.1 5.12 4.58
painting 26.85 40.13 23.49 30.18 14.1 26.85 26.95 35.25 31.54
rendering 892.79 828.11 883.25 909.52 950.54 892.79 892.84 4.97 4.45
Bind table data
scripting 2364.47 2183.26 2679.59 2670.29 2156.55 2364.47 2410.83 10.54 9.42
painting 28.54 30.77 17.88 23.99 33.69 28.54 26.97 22.99 20.54
rendering 734.77 887.14 896.66 837.51 750.01 837.51 821.22 9.20 8.23
Click on table #comments
scripting 2677.99 3372.29 3377.87 2798.63 2898.87 2898.87 3025.13 10.87 9.72
painting 27.55 22.99 27.92 38.91 39.77 27.92 31.43 23.83 21.29
rendering 802.3 885.18 889.16 710.59 650.44 802.3 787.53 13.44 12.02
Update title
scripting 5023.49 5794.78 5412.48 5069.9 6500.5 5412.48 5560.23 10.97 9.82
painting 54.7 49.57 91.11 63.85 40.98 54.7 60.04 32.05 28.66
rendering 1393.16 1205.46 1229.79 1256.25 1206.4 1229.79 1258.21 6.22 5.56
Open modal
scripting 1560.49 1699.05 1731.11 1485.61 1648.62 1648.62 1624.98 6.22 5.56
painting 16.76 20.34 15.33 19.46 33.78 19.46 21.13 34.78 31.14
rendering 684.95 636.11 639.59 603.58 615.73 636.11 635.99 4.89 4.37
Close modal
scripting 854.25 1691.56 795.97 814.37 858.88 854.25 1003.01 38.47 34.41
painting 11.61 7.28 6.75 6.25 7.36 7.28 7.85 27.39 24.46
rendering 492.31 503.97 473.9 542.76 533.47 503.97 509.28 5.62 5.02
Click on table row
scripting 2266.45 2158.73 2162.2 2148.14 2204.17 2162.2 2187.94 2.23 2.00
painting 13.44 16.76 14.86 22.3 16.22 16.22 16.72 20.22 18.06
rendering 245.06 236.13 237.49 233.41 237.38 237.38 237.89 1.82 1.63
Edit input
scripting 271.92 289.83 238.69 271.54 257.89 271.54 265.97 7.15 6.39
painting 13.53 22.81 3.53 8.94 4.1 8.94 10.58 75.14 67.20
rendering 14.32 13.87 11.62 12.33 19.57 13.87 14.34 21.76 19.46
Clear input
scripting 647.06 678.05 749.15 702.45 682.41 682.41 691.82 5.45 4.87
painting 5.65 4.85 5.17 13.84 6.06 5.65 7.11 53.31 47.68
rendering 169.36 164.2 172.39 165.58 181.53 169.36 170.61 4.04 3.62
Edit input again
scripting 258.79 288.74 246.87 247.57 306.14 258.79 269.62 9.85 8.81
painting 7.24 14.22 4 5.8 10.86 7.24 8.42 48.69 43.59
rendering 21.87 16.99 16.78 18.59 18.76 18.59 18.6 10.97 9.78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants