Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added channel timeout configurations for REST WebClient provider #11177

Merged
merged 1 commit into from Feb 15, 2022

Conversation

nidhi-nair
Copy link
Contributor

Description

Unable to reproduce this issue on my local, but from this issue thread, the changes made in this PR should do the trick.

Fixes #10642

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Cannot be tested as this is not reproducible locally. Will need to test on release. Have tested for existing behaviour manually.

@nidhi-nair nidhi-nair self-assigned this Feb 15, 2022
@vercel
Copy link

vercel bot commented Feb 15, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/get-appsmith/appsmith/49tsiAwU7FkYeW9c2xrGVfEcBvEL
✅ Preview: https://appsmith-git-fix-rest-conxn-reset-get-appsmith.vercel.app

@github-actions github-actions bot added the Bug Something isn't working label Feb 15, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@nidhi-nair nidhi-nair added the BE Coders Pod Issues related to users writing code to fetch and update data label Feb 15, 2022
@nidhi-nair
Copy link
Contributor Author

/ok-to-test sha=48e95db

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1846878220.
Workflow: Appsmith External Integration Test Workflow.
Commit: 48e95db.
PR: 11177.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1846878220.
Commit: 48e95db.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
Select category
scripting 1831.15 1675.76 1858.54 1788.36 1720.05 1788.36 1774.77 4.29 3.84
painting 24.48 28.21 19.85 11.89 54.81 24.48 27.85 58.38 52.21
rendering 1108.36 1115.38 940.92 1091.27 1089.87 1091.27 1069.16 6.78 6.07
Bind table data
scripting 2564.63 2217.55 2178.89 2165.11 2807.92 2217.55 2386.82 12.03 10.76
painting 52.89 22.76 37.3 43.99 35.59 37.3 38.51 28.88 25.84
rendering 812.9 1053.84 1162.64 1155.8 1219.93 1155.8 1081.02 14.93 13.35
Click on table #comments
scripting 3366.82 3494.25 3168.24 3912.43 3394.21 3394.21 3467.19 7.95 7.11
painting 39.92 50.3 51.64 49.68 29.5 49.68 44.21 21.38 19.11
rendering 1057.14 1305.26 1190.53 1119.84 1146.18 1146.18 1163.79 7.96 7.12
Update title
scripting 9335.78 8424.03 7053.01 7432.3 8086.52 8086.52 8066.33 11.03 9.87
painting 60.25 82.38 69.16 67.01 98.59 69.16 75.48 20.15 18.02
rendering 2532.06 2512.98 2134.41 2227.59 2104.89 2227.59 2302.39 8.95 8.01
Open modal
scripting 2788.5 2977.87 6313.5 2115.59 2128.73 2788.5 3264.84 53.53 47.87
painting 27.66 21.13 49.05 20.38 32.32 27.66 30.11 38.76 34.67
rendering 1144.85 1149.05 1175.66 1124.59 994.18 1144.85 1117.67 6.39 5.71
Close modal
scripting 2616.47 1215.16 1991.77 4825.26 1318.92 1991.77 2393.52 61.50 55.01
painting 11.64 23.63 22.9 13.08 9.84 13.08 16.22 40.32 36.07
rendering 756.96 870.84 849.69 878.54 915.18 870.84 854.24 6.94 6.21
Click on table row
scripting 3053.19 2843.87 3024.11 3186.37 3259.8 3053.19 3073.47 5.22 4.67
painting 50.59 23.35 27.38 21.41 48.11 27.38 34.17 41.12 36.79
rendering 454.11 408.31 399.57 448.52 478.03 448.52 437.71 7.52 6.72
Edit input
scripting 407.74 468.67 416.27 406.27 393.06 407.74 418.4 7.00 6.26
painting 13.84 29.9 9.15 8.17 25.35 13.84 17.28 56.77 50.81
rendering 18.96 20.86 17.75 20.8 19.25 19.25 19.52 6.76 6.05
Clear input
scripting 962.2 1015.12 1032.53 1244.28 934.69 1015.12 1037.76 11.76 10.51
painting 8.54 15.38 10.34 7.65 7.88 8.54 9.96 32.23 28.82
rendering 260.65 284.32 283.37 253.19 249.02 260.65 266.11 6.28 5.62
Edit input again
scripting 413.9 343.5 506.65 362.22 358.13 362.22 396.88 16.85 15.07
painting 7.4 6.75 36.76 6.07 19.38 7.4 15.27 86.51 77.34
rendering 25.18 20.65 36.67 29.18 20.51 25.18 26.44 25.53 22.84

@nidhi-nair nidhi-nair enabled auto-merge (squash) February 15, 2022 13:13
@nidhi-nair nidhi-nair merged commit 7a8db42 into release Feb 15, 2022
@nidhi-nair nidhi-nair deleted the fix/rest-conxn-reset branch February 15, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BE Coders Pod Issues related to users writing code to fetch and update data Bug Something isn't working
Projects
None yet
2 participants