-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 8878 - To handle Comma delimited float values #11207
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/get-appsmith/appsmith/C3kADWYVynAErGJbZsmGpYvwrt7e |
...appsmith-interfaces/src/test/java/com/appsmith/external/helpers/DataTypeStringUtilsTest.java
Outdated
Show resolved
Hide resolved
...ver/appsmith-interfaces/src/main/java/com/appsmith/external/helpers/DataTypeStringUtils.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few tiny comments, please also format the files you have edited. I was pretty confused when I read .replaceAll(",","")
. I got lost in those quotes and commas for a second because there were no spaces. :)
Renamed the Test methods |
/ok-to-test sha=d21efb6 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1856937950. |
Merging in because failing tests are flaky and unrelated. |
Google Sheet Data processing issue with comma
Fixes #8878
Type of change
How Has This Been Tested?
Checklist: