Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 8878 - To handle Comma delimited float values #11207

Merged
merged 2 commits into from
Feb 17, 2022

Conversation

leotom2000
Copy link
Contributor

Google Sheet Data processing issue with comma

  • Fix for Comma delimited Number with or without decimal places

Fixes #8878

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manually tested
  • Existing @tests were checked to work fine
  • Added new @tests to test new implementation

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Feb 16, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/get-appsmith/appsmith/C3kADWYVynAErGJbZsmGpYvwrt7e
✅ Preview: https://appsmith-git-fix8878gsfailswithvalueswithcomma-get-appsmith.vercel.app

Copy link
Contributor

@nidhi-nair nidhi-nair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few tiny comments, please also format the files you have edited. I was pretty confused when I read .replaceAll(",",""). I got lost in those quotes and commas for a second because there were no spaces. :)

@leotom2000
Copy link
Contributor Author

A few tiny comments, please also format the files you have edited. I was pretty confused when I read .replaceAll(",",""). I got lost in those quotes and commas for a second because there were no spaces. :)

A few tiny comments, please also format the files you have edited. I was pretty confused when I read .replaceAll(",",""). I got lost in those quotes and commas for a second because there were no spaces. :)

Renamed the Test methods

@nidhi-nair
Copy link
Contributor

/ok-to-test sha=d21efb6

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1856937950.
Workflow: Appsmith External Integration Test Workflow.
Commit: d21efb6.
PR: 11207.

@nidhi-nair
Copy link
Contributor

Merging in because failing tests are flaky and unrelated.

@nidhi-nair nidhi-nair merged commit 69f7136 into release Feb 17, 2022
@nidhi-nair nidhi-nair deleted the Fix8878_GS_Fails_with_values_with_comma branch February 17, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Data not being parsed into Float
2 participants