Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 13412 - improve import app with progress bar #13864

Merged
merged 10 commits into from
May 26, 2022
Merged

feat: 13412 - improve import app with progress bar #13864

merged 10 commits into from
May 26, 2022

Conversation

haojin111
Copy link
Contributor

@haojin111 haojin111 commented May 16, 2022 •
edited by github-actions bot

Description

Added status bar while importing application with json

Fixes #13412

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Jest test
cypress test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🟢 Total coverage has increased 
// Code coverage diff between base branch:release and head branch: feat/13412-improve-import-app-flow-ui
Status File % Stmts % Branch % Funcs % Lines
🟢 total 56.63 (0.01) 38.63 (0) 35.97 (0.03) 56.88 (0.01)
🟢 app/client/src/ce/constants/messages.ts 77.99 (0.21) 100 (0) 34.88 (0.62) 82.03 (0.29)

@vercel
Copy link

vercel bot commented May 16, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview May 23, 2022 at 5:39AM (UTC)

@github-actions github-actions bot added Enhancement New feature or request Git Version Control Issues related to version control Import-Export-App Issues related to importing and exporting apps Medium Issues that frustrate users due to poor UX Platform Pod Team Managers Pod Issues that team managers care about for the security and efficiency of their teams UI Improvement labels May 16, 2022
@haojin111
Copy link
Contributor Author

/ok-to-test sha=a3be249

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2334790232.
Workflow: Appsmith External Integration Test Workflow.
Commit: a3be249.
PR: 13864.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2334790232.
Commit: a3be249.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1531.4 1635.75 1551.62 1533.63 1620.88 1551.62 1574.66 3.17 2.83
painting 5.85 5.81 15.23 6.24 8.66 6.24 8.36 48.09 42.94
rendering 517.52 543.65 520.12 515.14 577.6 520.12 534.81 4.96 4.43
SELECT_WIDGET_SELECT_OPTION
scripting 273.15 221.83 240.07 254.27 276.86 254.27 253.24 9.08 8.12
painting 3.28 2.66 2.83 5.07 2.89 2.89 3.35 29.55 26.57
rendering 17.05 15.05 17.69 17.56 18.42 17.56 17.15 7.41 6.65

IAmAnubhavSaini
IAmAnubhavSaini suggested changes May 17, 2022
View reviewed changes
Copy link
Contributor

@IAmAnubhavSaini IAmAnubhavSaini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove coverage-summary.json from changeset.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2334790232.
Commit: a3be249.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1531.4 1635.75 1551.62 1533.63 1620.88 1551.62 1574.66 3.17 2.83
painting 5.85 5.81 15.23 6.24 8.66 6.24 8.36 48.09 42.94
rendering 517.52 543.65 520.12 515.14 577.6 520.12 534.81 4.96 4.43
SELECT_WIDGET_SELECT_OPTION
scripting 273.15 221.83 240.07 254.27 276.86 254.27 253.24 9.08 8.12
painting 3.28 2.66 2.83 5.07 2.89 2.89 3.35 29.55 26.57
rendering 17.05 15.05 17.69 17.56 18.42 17.56 17.15 7.41 6.65

@IAmAnubhavSaini
Copy link
Contributor

There are 0 files to review.

@haojin111
Copy link
Contributor Author

/ok-to-test sha=27ebbfa

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2336853545.
Workflow: Appsmith External Integration Test Workflow.
Commit: 27ebbfa.
PR: 13864.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2336853545.
Commit: 27ebbfa.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 623.63 609.26 588.74 714.43 636.13 623.63 634.44 7.58 6.78
painting 13.01 4.16 3.55 5.32 4.92 4.92 6.19 62.52 55.90
rendering 282.93 259.43 261.36 281.04 268.22 268.22 270.6 4.04 3.61
BIND_TABLE_DATA
scripting 2199.48 2280.13 2303.33 2278.66 2212.1 2278.66 2254.74 2.04 1.82
painting 15.78 19.7 23.03 13.09 16.48 16.48 17.62 21.74 19.47
rendering 544 523.75 513.5 562.34 534.53 534.53 535.62 3.51 3.14
CLICK_ON_TABLE_ROW
scripting 1587.35 1526.42 2137.12 1565.99 1647 1587.35 1692.78 14.90 13.33
painting 10.86 10.94 14.63 11.77 15.54 11.77 12.75 17.18 15.37
rendering 241.76 247.85 270.48 269.09 262.92 262.92 258.42 5.00 4.48
UPDATE_POST_TITLE
scripting 2439.55 2357.88 2771 2311.19 2527.35 2439.55 2481.39 7.32 6.55
painting 13.1 15.33 15.87 16.02 12.87 15.33 14.64 10.45 9.36
rendering 321.15 339.75 357.74 328.64 321.23 328.64 333.7 4.63 4.14
OPEN_MODAL
scripting 952.37 1081.33 1110.99 1079.94 952.6 1079.94 1035.45 7.41 6.63
painting 8.34 11.01 12.25 8.39 18.17 11.01 11.63 34.65 30.95
rendering 373.93 377.88 435.54 386.24 375.33 377.88 389.78 6.68 5.97
CLOSE_MODAL
scripting 640.19 621.34 588.96 616.93 678.63 621.34 629.21 5.27 4.71
painting 5.83 4.33 4.58 4.97 4.81 4.81 4.9 11.63 10.41
rendering 296.72 323.87 326.21 308.03 320.45 320.45 315.06 3.94 3.53
SELECT_WIDGET_MENU_OPEN
scripting 1425.9 1383.83 1407.53 1414.49 1403.94 1407.53 1407.14 1.10 0.98
painting 5.19 9.96 7.58 8.4 8.21 8.21 7.87 21.98 19.70
rendering 394.44 397.38 384.52 395.88 393.16 394.44 393.08 1.28 1.14
SELECT_WIDGET_SELECT_OPTION
scripting 204.29 175.22 170.25 193.81 180.85 180.85 184.88 7.56 6.76
painting 2.48 2.55 2.12 1.99 2.05 2.12 2.24 11.61 10.27
rendering 12.2 11.55 12.06 12.26 12.18 12.18 12.05 2.41 2.16

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2336853545.
Commit: 27ebbfa.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 623.63 609.26 588.74 714.43 636.13 623.63 634.44 7.58 6.78
painting 13.01 4.16 3.55 5.32 4.92 4.92 6.19 62.52 55.90
rendering 282.93 259.43 261.36 281.04 268.22 268.22 270.6 4.04 3.61
BIND_TABLE_DATA
scripting 2199.48 2280.13 2303.33 2278.66 2212.1 2278.66 2254.74 2.04 1.82
painting 15.78 19.7 23.03 13.09 16.48 16.48 17.62 21.74 19.47
rendering 544 523.75 513.5 562.34 534.53 534.53 535.62 3.51 3.14
CLICK_ON_TABLE_ROW
scripting 1587.35 1526.42 2137.12 1565.99 1647 1587.35 1692.78 14.90 13.33
painting 10.86 10.94 14.63 11.77 15.54 11.77 12.75 17.18 15.37
rendering 241.76 247.85 270.48 269.09 262.92 262.92 258.42 5.00 4.48
UPDATE_POST_TITLE
scripting 2439.55 2357.88 2771 2311.19 2527.35 2439.55 2481.39 7.32 6.55
painting 13.1 15.33 15.87 16.02 12.87 15.33 14.64 10.45 9.36
rendering 321.15 339.75 357.74 328.64 321.23 328.64 333.7 4.63 4.14
OPEN_MODAL
scripting 952.37 1081.33 1110.99 1079.94 952.6 1079.94 1035.45 7.41 6.63
painting 8.34 11.01 12.25 8.39 18.17 11.01 11.63 34.65 30.95
rendering 373.93 377.88 435.54 386.24 375.33 377.88 389.78 6.68 5.97
CLOSE_MODAL
scripting 640.19 621.34 588.96 616.93 678.63 621.34 629.21 5.27 4.71
painting 5.83 4.33 4.58 4.97 4.81 4.81 4.9 11.63 10.41
rendering 296.72 323.87 326.21 308.03 320.45 320.45 315.06 3.94 3.53
SELECT_WIDGET_MENU_OPEN
scripting 1425.9 1383.83 1407.53 1414.49 1403.94 1407.53 1407.14 1.10 0.98
painting 5.19 9.96 7.58 8.4 8.21 8.21 7.87 21.98 19.70
rendering 394.44 397.38 384.52 395.88 393.16 394.44 393.08 1.28 1.14
SELECT_WIDGET_SELECT_OPTION
scripting 204.29 175.22 170.25 193.81 180.85 180.85 184.88 7.56 6.76
painting 2.48 2.55 2.12 1.99 2.05 2.12 2.24 11.61 10.27
rendering 12.2 11.55 12.06 12.26 12.18 12.18 12.05 2.41 2.16

IAmAnubhavSaini
IAmAnubhavSaini suggested changes May 18, 2022
View reviewed changes
app/client/src/ce/constants/messages.test.ts Outdated Show resolved Hide resolved
app/client/src/ce/constants/messages.test.ts Outdated Show resolved Hide resolved
app/client/src/ce/constants/messages.test.ts Outdated Show resolved Hide resolved
app/client/src/ce/constants/messages.test.ts Outdated Show resolved Hide resolved
app/client/src/ce/constants/messages.test.ts Outdated Show resolved Hide resolved
app/client/src/pages/Applications/ImportApplicationModal.tsx Outdated Show resolved Hide resolved
app/client/src/pages/Applications/ImportApplicationModal.tsx Outdated Show resolved Hide resolved
app/client/src/pages/Applications/ImportApplicationModal.tsx Show resolved Hide resolved
app/client/src/pages/Applications/ImportApplicationModal.tsx Outdated Show resolved Hide resolved
@haojin111
Copy link
Contributor Author

/ok-to-test sha=82dcfef

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2357926679.
Workflow: Appsmith External Integration Test Workflow.
Commit: 82dcfef.
PR: 13864.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2357926679.
Commit: 82dcfef.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1940.04 1510.95 1503.93 1592.36 1592.05 1592.05 1627.87 11.03 9.87
painting 14.47 7.67 7.92 9.9 6.71 7.92 9.33 33.23 29.69
rendering 687.83 544.38 508.26 529.56 534.82 534.82 560.97 12.86 11.50
SELECT_WIDGET_SELECT_OPTION
scripting 297.77 269.46 252.17 279.07 236.62 269.46 267.02 8.86 7.93
painting 7.11 6.61 4.6 8.78 5.04 6.61 6.43 26.13 23.33
rendering 25.48 20.91 17.85 18.37 16.91 18.37 19.9 17.34 15.53

@haojin111
Copy link
Contributor Author

/ok-to-test sha=7e5332c

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2370461526.
Workflow: Appsmith External Integration Test Workflow.
Commit: 7e5332c.
PR: 13864.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2370461526.
Commit: 7e5332c.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 541.88 596.35 551.46 1721.88 1743.94 596.35 1031.1 62.17 55.61
painting 6.85 5.03 6.96 6.93 3.71 6.85 5.9 24.92 22.20
rendering 259.7 287.12 278.1 261.18 255.33 261.18 268.29 5.08 4.54
BIND_TABLE_DATA
scripting 2257.87 2305.77 2241.53 2209.33 2192.24 2241.53 2241.35 1.98 1.77
painting 14.68 16.08 13.96 12.92 15.24 14.68 14.58 8.30 7.41
rendering 512.61 515.4 516.52 572.92 508.96 515.4 525.28 5.10 4.56
CLICK_ON_TABLE_ROW
scripting 1349.45 1334.95 1233.16 1264.2 1352.75 1334.95 1306.9 4.18 3.74
painting 13.21 17.13 13.48 25.71 13.42 13.48 16.59 32.25 28.87
rendering 246.05 257.13 246.8 245.59 290.53 246.8 257.22 7.47 6.68
UPDATE_POST_TITLE
scripting 1992.59 2087.93 2481.6 2005.74 2078.06 2078.06 2129.18 9.46 8.46
painting 16 12.41 15.98 15.87 15.54 15.87 15.16 10.22 9.10
rendering 322.76 328.18 319.26 313.32 321.47 321.47 321 1.69 1.50
OPEN_MODAL
scripting 988.62 944.82 962.63 877.29 1704.57 962.63 1095.59 31.30 27.99
painting 10.7 9.34 8.43 8.52 8.3 8.52 9.06 11.04 9.93
rendering 372.73 366.81 400.25 388.06 371.55 372.73 379.88 3.66 3.27
CLOSE_MODAL
scripting 478.68 638.68 497.54 684.34 613.75 613.75 582.6 15.47 13.84
painting 4.45 4.77 3.91 4.25 7.68 4.45 5.01 30.34 27.15
rendering 306.79 300.55 295.22 313.54 300.63 300.63 303.35 2.31 2.07
SELECT_WIDGET_MENU_OPEN
scripting 1382.23 1396.81 1377.51 1424.61 1566.66 1396.81 1429.56 5.51 4.93
painting 8.51 5.82 4.04 8.44 6.53 6.53 6.67 28.19 25.19
rendering 399.74 392.92 395.99 411.81 488.04 399.74 417.7 9.57 8.56
SELECT_WIDGET_SELECT_OPTION
scripting 160.33 196.38 168.39 227.46 189.69 189.69 188.45 13.99 12.51
painting 4.42 6.23 4.74 4.03 2.35 4.42 4.35 32.18 28.74
rendering 11.84 11.68 11.24 12.2 13.22 11.84 12.04 6.23 5.56

@haojin111 haojin111 merged commit 3c1b1a3 into release May 26, 2022
@haojin111 haojin111 deleted the feat/13412-improve-import-app-flow-ui branch May 26, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IAmAnubhavSaini IAmAnubhavSaini IAmAnubhavSaini approved these changes

Assignees
No one assigned
Labels
Enhancement New feature or request Git Version Control Issues related to version control Import-Export-App Issues related to importing and exporting apps Medium Issues that frustrate users due to poor UX Team Managers Pod Issues that team managers care about for the security and efficiency of their teams UI Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]-[300]:Improve import application UX flow
2 participants
@haojin111 @IAmAnubhavSaini