Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Text overlap in slash commands #13871

Merged
merged 3 commits into from
May 18, 2022
Merged

fix: Text overlap in slash commands #13871

merged 3 commits into from
May 18, 2022

Conversation

arunvjn
Copy link
Contributor

@arunvjn arunvjn commented May 16, 2022 •
edited by github-actions bot

Description

Fixes text overlap for datasources with longer names in slash commands.

Fixes #13868

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

⚪ Total coverage has not changed 
// Code coverage diff between base branch:release and head branch: fix/13868-text-overlap-slash-commands
Status File % Stmts % Branch % Funcs % Lines
🟢 app/client/src/selectors/commentsSelectors.ts 85.25 (1.64) 64.71 (2.95) 73.33 (0) 90.59 (2.35)
🔴 app/client/src/utils/WorkerUtil.ts 89.76 (0) 70.59 (-1.96) 100 (0) 93.33 (0)

@vercel
Copy link

vercel bot commented May 16, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview May 16, 2022 at 1:35PM (UTC)

@github-actions github-actions bot added Actions Pod Bug Something isn't working FE Coders Pod Issues related to users writing javascript in appsmith Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Regressed Scenarios that were working before but have now regressed labels May 16, 2022
@arunvjn arunvjn added New Developers Pod Issues that new developers face while exploring the IDE and removed FE Coders Pod Issues related to users writing javascript in appsmith Actions Pod labels May 16, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions github-actions bot added Actions Pod FE Coders Pod Issues related to users writing javascript in appsmith labels May 16, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

5 similar comments
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@arunvjn
Copy link
Contributor Author

arunvjn commented May 18, 2022

/ok-to-test sha=82a7658

@arunvjn
Copy link
Contributor Author

arunvjn commented May 18, 2022

/ok-to-test sha=d401690

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2343997134.
Workflow: Appsmith External Integration Test Workflow.
Commit: d401690.
PR: 13871.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2343997134.
Commit: d401690.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 826.76 1023.18 1021.03 724.75 746.89 826.76 868.52 16.72 14.96
painting 7.48 6.27 7 10.02 4.5 7 7.05 28.51 25.53
rendering 379.09 446.48 532.97 339.61 311.23 379.09 401.88 22.18 19.84
BIND_TABLE_DATA
scripting 2232.23 2905.34 2268.69 2272.54 2247.46 2268.69 2385.25 12.21 10.92
painting 18.04 35.28 22.84 21.02 27.39 22.84 24.91 26.94 24.13
rendering 729.97 940.75 817.83 741.66 753.63 753.63 796.77 10.97 9.81
CLICK_ON_TABLE_ROW
scripting 2067.94 4507.84 1826.25 2592.81 1955.18 2067.94 2590 42.89 38.37
painting 34.44 54.26 18.62 17.07 18.36 18.62 28.55 56.22 50.26
rendering 381.79 1032.49 306.77 333.57 369.66 369.66 484.86 63.43 56.74
UPDATE_POST_TITLE
scripting 2958.53 3990.15 2763.28 2905.16 2739.16 2905.16 3071.26 17.00 15.20
painting 18.43 30.65 26.18 15.47 18.41 18.43 21.83 29.00 25.93
rendering 414.41 566.82 385.61 397.46 404.97 404.97 433.85 17.30 15.48
OPEN_MODAL
scripting 1610.42 4820.86 2741.54 1422.84 1509.25 1610.42 2420.98 59.67 53.37
painting 16.23 17.97 14.75 14.3 18.54 16.23 16.36 11.49 10.33
rendering 580.23 770.4 466.44 543.99 551.77 551.77 582.57 19.42 17.37
CLOSE_MODAL
scripting 813 2195.06 2753.99 992.88 871.61 992.88 1525.31 58.42 52.25
painting 7.8 6.86 4.99 10.64 8.84 7.8 7.83 27.08 24.14
rendering 409.84 424.3 371.92 473.18 456.68 424.3 427.18 9.33 8.34
SELECT_WIDGET_MENU_OPEN
scripting 1538.31 1593.73 1698.58 1592.21 1514.48 1592.21 1587.46 4.47 4.00
painting 17.09 12.32 13.33 6.54 4.91 12.32 10.84 46.40 41.51
rendering 523.01 575.32 669.91 528.84 516.18 528.84 562.65 11.43 10.22
SELECT_WIDGET_SELECT_OPTION
scripting 278.5 335.06 251.97 201.09 213.66 251.97 256.06 21.01 18.80
painting 7.35 3.23 2.92 2.88 4.28 3.23 4.13 45.76 40.92
rendering 19.45 18.99 15.06 16.43 14.39 16.43 16.86 13.52 12.10

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2343997134.
Commit: d401690.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 826.76 1023.18 1021.03 724.75 746.89 826.76 868.52 16.72 14.96
painting 7.48 6.27 7 10.02 4.5 7 7.05 28.51 25.53
rendering 379.09 446.48 532.97 339.61 311.23 379.09 401.88 22.18 19.84
BIND_TABLE_DATA
scripting 2232.23 2905.34 2268.69 2272.54 2247.46 2268.69 2385.25 12.21 10.92
painting 18.04 35.28 22.84 21.02 27.39 22.84 24.91 26.94 24.13
rendering 729.97 940.75 817.83 741.66 753.63 753.63 796.77 10.97 9.81
CLICK_ON_TABLE_ROW
scripting 2067.94 4507.84 1826.25 2592.81 1955.18 2067.94 2590 42.89 38.37
painting 34.44 54.26 18.62 17.07 18.36 18.62 28.55 56.22 50.26
rendering 381.79 1032.49 306.77 333.57 369.66 369.66 484.86 63.43 56.74
UPDATE_POST_TITLE
scripting 2958.53 3990.15 2763.28 2905.16 2739.16 2905.16 3071.26 17.00 15.20
painting 18.43 30.65 26.18 15.47 18.41 18.43 21.83 29.00 25.93
rendering 414.41 566.82 385.61 397.46 404.97 404.97 433.85 17.30 15.48
OPEN_MODAL
scripting 1610.42 4820.86 2741.54 1422.84 1509.25 1610.42 2420.98 59.67 53.37
painting 16.23 17.97 14.75 14.3 18.54 16.23 16.36 11.49 10.33
rendering 580.23 770.4 466.44 543.99 551.77 551.77 582.57 19.42 17.37
CLOSE_MODAL
scripting 813 2195.06 2753.99 992.88 871.61 992.88 1525.31 58.42 52.25
painting 7.8 6.86 4.99 10.64 8.84 7.8 7.83 27.08 24.14
rendering 409.84 424.3 371.92 473.18 456.68 424.3 427.18 9.33 8.34
SELECT_WIDGET_MENU_OPEN
scripting 1538.31 1593.73 1698.58 1592.21 1514.48 1592.21 1587.46 4.47 4.00
painting 17.09 12.32 13.33 6.54 4.91 12.32 10.84 46.40 41.51
rendering 523.01 575.32 669.91 528.84 516.18 528.84 562.65 11.43 10.22
SELECT_WIDGET_SELECT_OPTION
scripting 278.5 335.06 251.97 201.09 213.66 251.97 256.06 21.01 18.80
painting 7.35 3.23 2.92 2.88 4.28 3.23 4.13 45.76 40.92
rendering 19.45 18.99 15.06 16.43 14.39 16.43 16.86 13.52 12.10

@arunvjn arunvjn merged commit 0bcabdb into release May 18, 2022
@arunvjn arunvjn deleted the fix/13868-text-overlap-slash-commands branch May 18, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albinAppsmith albinAppsmith albinAppsmith approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working FE Coders Pod Issues related to users writing javascript in appsmith Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage New Developers Pod Issues that new developers face while exploring the IDE Regressed Scenarios that were working before but have now regressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Overlapping observed in the dropdown while using slash command
2 participants
@arunvjn @albinAppsmith