Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle selectedValues value #13887

Merged
merged 2 commits into from
May 19, 2022
Merged

fix: handle selectedValues value #13887

merged 2 commits into from
May 19, 2022

Conversation

techbhavin
Copy link
Contributor

@techbhavin techbhavin commented May 17, 2022 •
edited by github-actions bot

Description

CheckBoxGroup not displaying options in a modal to fix an issue we improve the handle selected value.

Fixes #13171

Type of change

  • Bugfix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🔴 Total coverage has decreased 
// Code coverage diff between base branch:release and head branch: fix/issue-13171
Status File % Stmts % Branch % Funcs % Lines
🔴 total 56.64 (-0.01) 38.61 (0) 35.97 (0) 56.9 (0)
🔴 app/client/src/selectors/commentsSelectors.ts 83.61 (-1.64) 61.76 (-2.95) 73.33 (0) 88.24 (-2.35)
🟢 app/client/src/utils/WorkerUtil.ts 89.76 (0) 72.55 (1.96) 100 (0) 93.33 (0)
🟢 app/client/src/utils/autocomplete/TernServer.ts 52.94 (0.23) 41.67 (0.84) 36.21 (0) 56.99 (0.25)
🔴 app/client/src/widgets/CheckboxGroupWidget/widget/index.tsx 46.51 (-1.11) 17.5 (-3.09) 34.78 (0) 48.1 (0)

@techbhavin techbhavin requested a review from jsartisan May 17, 2022 05:57
@vercel
Copy link

vercel bot commented May 17, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview May 18, 2022 at 10:12AM (UTC)

@github-actions github-actions bot added App Viewers Pod This label assigns issues to the app viewers pod Bug Something isn't working Checkbox Group widget Issues related to Checkbox Group Widget High This issue blocks a user from building or impacts a lot of users Modal Widget UI Building Pod labels May 17, 2022
@techbhavin
Copy link
Contributor Author

/ok-to-test sha=e450222

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2336591895.
Workflow: Appsmith External Integration Test Workflow.
Commit: e450222.
PR: 13887.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2336591895.
Commit: e450222.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1980.99 2026.86 1992.69 1984.72 1961.02 1984.72 1989.26 1.21 1.08
painting 16.63 12.85 15.43 13.61 12.13 13.61 14.13 13.16 11.75
rendering 702.3 692.77 704.92 697.9 688.79 697.9 697.34 0.95 0.85
SELECT_WIDGET_SELECT_OPTION
scripting 305.78 362.76 331.24 364.86 312.47 331.24 335.42 8.21 7.35
painting 11.79 3.5 5.13 6.27 4.66 5.13 6.27 51.67 46.25
rendering 22.77 23.71 25.19 22.9 21.05 22.9 23.12 6.53 5.84

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2336591895.
Commit: e450222.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1980.99 2026.86 1992.69 1984.72 1961.02 1984.72 1989.26 1.21 1.08
painting 16.63 12.85 15.43 13.61 12.13 13.61 14.13 13.16 11.75
rendering 702.3 692.77 704.92 697.9 688.79 697.9 697.34 0.95 0.85
SELECT_WIDGET_SELECT_OPTION
scripting 305.78 362.76 331.24 364.86 312.47 331.24 335.42 8.21 7.35
painting 11.79 3.5 5.13 6.27 4.66 5.13 6.27 51.67 46.25
rendering 22.77 23.71 25.19 22.9 21.05 22.9 23.12 6.53 5.84

@chandannkumar
Copy link

Tested this PR and working as Expected

@techbhavin
Copy link
Contributor Author

/ok-to-test sha=9ac62ad

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2344825466.
Workflow: Appsmith External Integration Test Workflow.
Commit: 9ac62ad.
PR: 13887.

@techbhavin
Copy link
Contributor Author

/ok-to-test sha=9ac62ad

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2349500855.
Workflow: Appsmith External Integration Test Workflow.
Commit: 9ac62ad.
PR: 13887.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2349500855.
Commit: 9ac62ad.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 2432.52 2389.33 2342.56 2416.2 2506.76 2416.2 2417.47 2.50 2.24
painting 18 25.87 15.15 17.13 21.68 18 19.57 21.72 19.42
rendering 844.58 824.6 834.91 839.34 824.5 834.91 833.59 1.07 0.96
SELECT_WIDGET_SELECT_OPTION
scripting 366.31 381.81 407.13 363.43 385.98 381.81 380.93 4.61 4.12
painting 5.62 14.24 5.38 10.4 3.96 5.62 7.92 54.17 48.36
rendering 21.71 22.62 23.6 24.61 25.7 23.6 23.65 6.68 5.96

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2349500855.
Commit: 9ac62ad.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 2432.52 2389.33 2342.56 2416.2 2506.76 2416.2 2417.47 2.50 2.24
painting 18 25.87 15.15 17.13 21.68 18 19.57 21.72 19.42
rendering 844.58 824.6 834.91 839.34 824.5 834.91 833.59 1.07 0.96
SELECT_WIDGET_SELECT_OPTION
scripting 366.31 381.81 407.13 363.43 385.98 381.81 380.93 4.61 4.12
painting 5.62 14.24 5.38 10.4 3.96 5.62 7.92 54.17 48.36
rendering 21.71 22.62 23.6 24.61 25.7 23.6 23.65 6.68 5.96

@techbhavin techbhavin merged commit 33d8347 into release May 19, 2022
@techbhavin techbhavin deleted the fix/issue-13171 branch May 19, 2022 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsartisan jsartisan jsartisan approved these changes

Assignees
No one assigned
Labels
App Viewers Pod This label assigns issues to the app viewers pod Bug Something isn't working Checkbox Group widget Issues related to Checkbox Group Widget High This issue blocks a user from building or impacts a lot of users Modal Widget
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]-[160]:CheckBoxGroup not displaying options in a modal
3 participants
@techbhavin @chandannkumar @jsartisan