Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inconsistency in naming actions in omnibar #13898

Merged
merged 2 commits into from
May 25, 2022

Conversation

akash-codemonk
Copy link
Contributor

@akash-codemonk akash-codemonk commented May 17, 2022

Description

We were creating queries for api datasources. The fix is here checks for the datasource plugin type and then creates an api/query accordingly. This also fixes the case where actions are created from the explorer, as it goes through the same code.

Fixes #11303

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Cypress

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🔴 Total coverage has decreased
// Code coverage diff between base branch:release and head branch: fix/new-api-name-inconsistency 
Status File % Stmts % Branch % Funcs % Lines
🔴 total 56.62 (0) 38.6 (-0.02) 35.94 (0) 56.87 (0)
🔴 app/client/src/components/editorComponents/GlobalSearch/GlobalSearchHooks.tsx 73.15 (-1.85) 19.49 (-4.47) 55.56 (-2.13) 69.15 (-1.78)
🟢 app/client/src/utils/WorkerUtil.ts 89.76 (0.78) 72.55 (1.96) 100 (0) 93.33 (0.95)

@vercel
Copy link

vercel bot commented May 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview May 23, 2022 at 9:10AM (UTC)

@github-actions github-actions bot added Bug Something isn't working Frontend This label marks the issue or pull request to reference client code Low An issue that is neither critical nor breaks a user flow New Developers Pod Issues that new developers face while exploring the IDE Omnibar Issues related to the omnibar for navigation Platform Pod labels May 17, 2022
@akash-codemonk
Copy link
Contributor Author

/ok-to-test sha=bf22aaa

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2338206309.
Workflow: Appsmith External Integration Test Workflow.
Commit: bf22aaa.
PR: 13898.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2338206309.
Commit: bf22aaa.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 799.47 798.16 795.93 777.94 2085.3 798.16 1051.36 54.98 49.18
painting 4.93 4.9 5.78 5.47 3.94 4.93 5 14.00 12.60
rendering 297.15 298.79 315.43 294.78 298.36 298.36 300.9 2.75 2.46
BIND_TABLE_DATA
scripting 2263.71 2261.9 2305.09 2797.5 2351.38 2305.09 2395.92 9.49 8.49
painting 14.21 20.54 14.96 19.53 18.01 18.01 17.45 15.93 14.27
rendering 584.84 632.66 678.49 682.35 603.03 632.66 636.27 6.88 6.15
CLICK_ON_TABLE_ROW
scripting 2241.1 2313 2098.75 2056.14 1953.37 2098.75 2132.47 6.77 6.06
painting 15.14 23.57 22.73 19.7 16.55 19.7 19.54 18.94 16.94
rendering 308.9 340 339.48 295.62 319.45 319.45 320.69 6.03 5.39
UPDATE_POST_TITLE
scripting 3413.76 3268.82 3238.53 3405.53 3092.84 3268.82 3283.9 4.04 3.61
painting 16 20.25 15.01 18.41 29.76 18.41 19.89 29.61 26.50
rendering 385.93 396.39 385.43 410.44 416.03 396.39 398.84 3.51 3.14
OPEN_MODAL
scripting 1413.4 3296.65 1298.71 1330.22 1386.7 1386.7 1745.14 49.77 44.51
painting 11.53 13.28 14.05 15.84 15.45 14.05 14.03 12.40 11.12
rendering 475.23 442.86 439.82 444.06 447.42 444.06 449.88 3.21 2.87
CLOSE_MODAL
scripting 926.2 763.01 881.11 846.45 725.69 846.45 828.49 10.01 8.95
painting 6.16 5.97 15.74 6.67 6.86 6.67 8.28 50.60 45.17
rendering 392.17 358.19 345.34 400.49 374.77 374.77 374.19 6.13 5.48
SELECT_WIDGET_MENU_OPEN
scripting 1560.94 1498.91 1523.36 1509.86 1515.72 1515.72 1521.76 1.55 1.39
painting 6.06 9.21 15 12.86 7.27 9.21 10.08 37.40 33.43
rendering 529.43 488.75 507.61 490.73 565.95 507.61 516.49 6.22 5.56
SELECT_WIDGET_SELECT_OPTION
scripting 231.96 230.82 242.39 203.67 235.05 231.96 228.78 6.44 5.77
painting 5.56 3.35 2.94 3.92 4.85 3.92 4.12 26.21 23.30
rendering 15.97 16.46 23.07 16.24 14.77 16.24 17.3 19.02 16.99

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2338206309.
Commit: bf22aaa.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 799.47 798.16 795.93 777.94 2085.3 798.16 1051.36 54.98 49.18
painting 4.93 4.9 5.78 5.47 3.94 4.93 5 14.00 12.60
rendering 297.15 298.79 315.43 294.78 298.36 298.36 300.9 2.75 2.46
BIND_TABLE_DATA
scripting 2263.71 2261.9 2305.09 2797.5 2351.38 2305.09 2395.92 9.49 8.49
painting 14.21 20.54 14.96 19.53 18.01 18.01 17.45 15.93 14.27
rendering 584.84 632.66 678.49 682.35 603.03 632.66 636.27 6.88 6.15
CLICK_ON_TABLE_ROW
scripting 2241.1 2313 2098.75 2056.14 1953.37 2098.75 2132.47 6.77 6.06
painting 15.14 23.57 22.73 19.7 16.55 19.7 19.54 18.94 16.94
rendering 308.9 340 339.48 295.62 319.45 319.45 320.69 6.03 5.39
UPDATE_POST_TITLE
scripting 3413.76 3268.82 3238.53 3405.53 3092.84 3268.82 3283.9 4.04 3.61
painting 16 20.25 15.01 18.41 29.76 18.41 19.89 29.61 26.50
rendering 385.93 396.39 385.43 410.44 416.03 396.39 398.84 3.51 3.14
OPEN_MODAL
scripting 1413.4 3296.65 1298.71 1330.22 1386.7 1386.7 1745.14 49.77 44.51
painting 11.53 13.28 14.05 15.84 15.45 14.05 14.03 12.40 11.12
rendering 475.23 442.86 439.82 444.06 447.42 444.06 449.88 3.21 2.87
CLOSE_MODAL
scripting 926.2 763.01 881.11 846.45 725.69 846.45 828.49 10.01 8.95
painting 6.16 5.97 15.74 6.67 6.86 6.67 8.28 50.60 45.17
rendering 392.17 358.19 345.34 400.49 374.77 374.77 374.19 6.13 5.48
SELECT_WIDGET_MENU_OPEN
scripting 1560.94 1498.91 1523.36 1509.86 1515.72 1515.72 1521.76 1.55 1.39
painting 6.06 9.21 15 12.86 7.27 9.21 10.08 37.40 33.43
rendering 529.43 488.75 507.61 490.73 565.95 507.61 516.49 6.22 5.56
SELECT_WIDGET_SELECT_OPTION
scripting 231.96 230.82 242.39 203.67 235.05 231.96 228.78 6.44 5.77
painting 5.56 3.35 2.94 3.92 4.85 3.92 4.12 26.21 23.30
rendering 15.97 16.46 23.07 16.24 14.77 16.24 17.3 19.02 16.99

@akash-codemonk
Copy link
Contributor Author

/ok-to-test sha=c298fa1

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2370606254.
Workflow: Appsmith External Integration Test Workflow.
Commit: c298fa1.
PR: 13898.

@akash-codemonk akash-codemonk merged commit 77cee95 into release May 25, 2022
@akash-codemonk akash-codemonk deleted the fix/new-api-name-inconsistency branch May 25, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Frontend This label marks the issue or pull request to reference client code Low An issue that is neither critical nor breaks a user flow New Developers Pod Issues that new developers face while exploring the IDE Omnibar Issues related to the omnibar for navigation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]-[6500]:Inconsistency in naming actions
2 participants