Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove transition delay in entity explorer. #13942

Merged
merged 13 commits into from
May 20, 2022
Merged

fix: remove transition delay in entity explorer. #13942

merged 13 commits into from
May 20, 2022

Conversation

arunvjn
Copy link
Contributor

@arunvjn arunvjn commented May 18, 2022 •
edited by github-actions bot

Description

This PR removes the transition delay while switching between explorer and widgets in the entity explorer.
It is attempt to improve perceived performance.

Fixes #13929

Type of change

  • UX/Perf change

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🔴 Total coverage has decreased 
// Code coverage diff between base branch:release and head branch: fix/remove-explorer-animation
Status File % Stmts % Branch % Funcs % Lines
🔴 total 56.65 (-0.01) 38.67 (0.01) 35.97 (0) 56.91 (-0.01)
🟢 app/client/src/components/ads/index.ts 100 (0) 100 (0) 13.21 (1.89) 100 (0)
🟢 app/client/src/components/editorComponents/Sidebar.tsx 85.25 (2.69) 46.43 (2.31) 72.73 (10.23) 84.75 (2.03)
🔴 app/client/src/pages/Editor/WidgetSidebar.tsx 63.64 (-7.09) 16.67 (2.38) 28.57 (-15.87) 61.29 (-7.94)
🟢 app/client/src/pages/Editor/Explorer/EntityExplorer.tsx 88 (-0.24) 71.43 (4.76) 50 (0) 87.5 (-0.26)
🟢 app/client/src/pages/Editor/Explorer/ExplorerSearch.tsx 73.08 (0) 37.5 (20.83) 60 (0) 68.18 (0)
🔴 app/client/src/pages/Editor/Explorer/index.tsx 84.38 (-15.62) 33.33 (-66.67) 66.67 (-33.33) 83.33 (-16.67)
🟢 app/client/src/pages/Editor/Explorer/Entity/index.tsx 91.86 (0) 86.49 (0.38) 84.21 (0) 91.46 (0)

@vercel
Copy link

vercel bot commented May 18, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview May 20, 2022 at 3:40AM (UTC)

@github-actions github-actions bot added Bug Something isn't working Entity Explorer Issues related to navigation using the entity explorer Medium Issues that frustrate users due to poor UX New Developers Pod Issues that new developers face while exploring the IDE Platform Pod labels May 18, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@arunvjn
Copy link
Contributor Author

arunvjn commented May 18, 2022

/ok-to-test sha=71a576c

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

3 similar comments
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2345840883.
Workflow: Appsmith External Integration Test Workflow.
Commit: 71a576c.
PR: 13942.

albinAppsmith
albinAppsmith previously approved these changes May 18, 2022
View reviewed changes
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2345840883.
Commit: 71a576c.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 724.63 560.97 518.15 561.94 721.01 561.94 617.34 15.86 14.19
painting 6.03 5.33 3.97 3.56 5.56 5.33 4.89 21.88 19.43
rendering 331.22 290.23 259.62 272.83 403.24 290.23 311.43 18.61 16.65
BIND_TABLE_DATA
scripting 2445.09 2277.61 2240.04 2578.21 2369.67 2369.67 2382.12 5.70 5.10
painting 35.95 15.43 6.83 10.97 33.09 15.43 20.45 64.69 57.90
rendering 761.19 531.97 493.58 561.63 640.94 561.63 597.86 17.75 15.88
CLICK_ON_TABLE_ROW
scripting 2209.89 1342.21 1374 1507.09 1659.65 1507.09 1618.57 21.84 19.54
painting 20.45 14.89 10.83 17.39 18.48 17.39 16.41 22.61 20.23
rendering 371.07 245.63 252.17 283.49 298.75 283.49 290.22 17.31 15.48
UPDATE_POST_TITLE
scripting 4059.44 2169.18 2064.63 2240.5 3625.52 2240.5 2831.85 33.10 29.61
painting 36.62 12.61 26.99 14.15 22.77 22.77 22.63 43.48 38.89
rendering 499.77 326.72 318.35 354.36 412.5 354.36 382.34 19.69 17.61
OPEN_MODAL
scripting 1613.14 2264.22 930.88 1057.42 1215.9 1215.9 1416.31 38.06 34.04
painting 15.8 10.45 8.4 10.91 13.54 10.91 11.82 24.37 21.83
rendering 608.93 372.6 384.32 428.36 451.1 428.36 449.06 21.14 18.90
CLOSE_MODAL
scripting 590.97 1508.24 612.09 693.76 625.11 625.11 806.03 48.93 43.77
painting 7.96 7.21 4.55 5.51 5.2 5.51 6.09 23.65 21.02
rendering 348.47 339.63 301.88 330.36 362.44 339.63 336.56 6.75 6.03
SELECT_WIDGET_MENU_OPEN
scripting 1511.02 1567.35 1577.01 1617.32 1521.33 1567.35 1558.81 2.78 2.49
painting 11.86 17.79 20.9 14.72 10.93 14.72 15.24 27.23 24.34
rendering 456.84 480.95 474.21 472.75 443.51 472.75 465.65 3.27 2.92
SELECT_WIDGET_SELECT_OPTION
scripting 243.93 195.2 222.04 187.05 202.82 202.82 210.21 10.88 9.73
painting 6.91 10.46 3.45 2.6 2.7 3.45 5.22 65.52 58.43
rendering 22.38 17.37 14.88 14.25 14.02 14.88 16.58 21.11 18.88

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2345840883.
Commit: 71a576c.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 724.63 560.97 518.15 561.94 721.01 561.94 617.34 15.86 14.19
painting 6.03 5.33 3.97 3.56 5.56 5.33 4.89 21.88 19.43
rendering 331.22 290.23 259.62 272.83 403.24 290.23 311.43 18.61 16.65
BIND_TABLE_DATA
scripting 2445.09 2277.61 2240.04 2578.21 2369.67 2369.67 2382.12 5.70 5.10
painting 35.95 15.43 6.83 10.97 33.09 15.43 20.45 64.69 57.90
rendering 761.19 531.97 493.58 561.63 640.94 561.63 597.86 17.75 15.88
CLICK_ON_TABLE_ROW
scripting 2209.89 1342.21 1374 1507.09 1659.65 1507.09 1618.57 21.84 19.54
painting 20.45 14.89 10.83 17.39 18.48 17.39 16.41 22.61 20.23
rendering 371.07 245.63 252.17 283.49 298.75 283.49 290.22 17.31 15.48
UPDATE_POST_TITLE
scripting 4059.44 2169.18 2064.63 2240.5 3625.52 2240.5 2831.85 33.10 29.61
painting 36.62 12.61 26.99 14.15 22.77 22.77 22.63 43.48 38.89
rendering 499.77 326.72 318.35 354.36 412.5 354.36 382.34 19.69 17.61
OPEN_MODAL
scripting 1613.14 2264.22 930.88 1057.42 1215.9 1215.9 1416.31 38.06 34.04
painting 15.8 10.45 8.4 10.91 13.54 10.91 11.82 24.37 21.83
rendering 608.93 372.6 384.32 428.36 451.1 428.36 449.06 21.14 18.90
CLOSE_MODAL
scripting 590.97 1508.24 612.09 693.76 625.11 625.11 806.03 48.93 43.77
painting 7.96 7.21 4.55 5.51 5.2 5.51 6.09 23.65 21.02
rendering 348.47 339.63 301.88 330.36 362.44 339.63 336.56 6.75 6.03
SELECT_WIDGET_MENU_OPEN
scripting 1511.02 1567.35 1577.01 1617.32 1521.33 1567.35 1558.81 2.78 2.49
painting 11.86 17.79 20.9 14.72 10.93 14.72 15.24 27.23 24.34
rendering 456.84 480.95 474.21 472.75 443.51 472.75 465.65 3.27 2.92
SELECT_WIDGET_SELECT_OPTION
scripting 243.93 195.2 222.04 187.05 202.82 202.82 210.21 10.88 9.73
painting 6.91 10.46 3.45 2.6 2.7 3.45 5.22 65.52 58.43
rendering 22.38 17.37 14.88 14.25 14.02 14.88 16.58 21.11 18.88

@arunvjn
Copy link
Contributor Author

arunvjn commented May 19, 2022

/ok-to-test sha=2d54201

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2351133218.
Workflow: Appsmith External Integration Test Workflow.
Commit: 2d54201.
PR: 13942.

@arunvjn
Copy link
Contributor Author

arunvjn commented May 19, 2022

/ok-to-test sha=98f5087

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2351159841.
Workflow: Appsmith External Integration Test Workflow.
Commit: 98f5087.
PR: 13942.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2351133218.
Commit: 2d54201.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 761.92 722.36 670.81 788.09 689.98 722.36 726.63 6.71 6.00
painting 6.85 5.95 3.73 7.1 7.57 6.85 6.24 24.36 21.79
rendering 331.98 302.44 293.76 308.29 307.49 307.49 308.79 4.60 4.11
BIND_TABLE_DATA
scripting 2250.13 2161.85 2212.13 2247 2345.91 2247 2243.4 3.01 2.69
painting 24.35 20.51 17.79 20.68 25.54 20.68 21.77 14.42 12.91
rendering 691.77 650.66 590.64 662.31 668.85 662.31 652.85 5.80 5.19
CLICK_ON_TABLE_ROW
scripting 1891.65 2077.16 1723.38 1775.37 2026.04 1891.65 1898.72 8.08 7.22
painting 19.81 14.92 13.02 16.47 23.9 16.47 17.62 24.40 21.85
rendering 340.9 361.45 302.54 300.86 339.61 339.61 329.07 8.04 7.19
UPDATE_POST_TITLE
scripting 2858.29 3064.33 2572.8 2545.91 3766.38 2858.29 2961.54 16.82 15.05
painting 30.82 22.43 16.32 11.78 20.05 20.05 20.28 35.21 31.46
rendering 403.41 465.66 425.21 362.16 358.35 403.41 402.96 11.15 9.98
OPEN_MODAL
scripting 1230.27 1214.23 1234.04 1218.85 2122.92 1230.27 1404.06 28.63 25.60
painting 13.05 13.19 11.83 13.11 14.25 13.11 13.09 6.57 5.88
rendering 462.82 447.41 480.22 405.22 406.74 447.41 440.48 7.62 6.82
CLOSE_MODAL
scripting 833.43 781.34 3121.3 593.73 614.01 781.34 1188.76 91.30 81.66
painting 12.31 10.44 6.02 7.7 4.46 7.7 8.19 39.07 34.92
rendering 371.47 364.52 359.61 348.01 320.34 359.61 352.79 5.69 5.09
SELECT_WIDGET_MENU_OPEN
scripting 1475.85 1382.94 1487.18 1629.93 1979.17 1487.18 1591.01 14.72 13.17
painting 10.99 7.2 7.49 9.01 13.09 9.01 9.56 25.94 23.22
rendering 500.44 480.5 503.04 526.5 742.97 503.04 550.69 19.74 17.66
SELECT_WIDGET_SELECT_OPTION
scripting 250.64 240.74 267.02 324.25 319.7 267.02 280.47 13.93 12.46
painting 4.2 14.9 3.05 2.99 4.49 4.2 5.93 85.33 76.39
rendering 15.16 14.17 14.87 15.84 21.88 15.16 16.38 19.11 17.09

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2351159841.
Commit: 98f5087.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 746.81 733.03 629.45 614.99 1061.25 733.03 757.11 23.78 21.27
painting 4.65 5.75 3.79 3.49 9.38 4.65 5.41 44.18 39.37
rendering 314.3 363.84 288.57 298.77 519.22 314.3 356.94 26.67 23.86
BIND_TABLE_DATA
scripting 2265.51 2273.64 2225.96 2316.99 2375.42 2273.64 2291.5 2.49 2.22
painting 18.29 13.73 19.48 16.9 75.32 18.29 28.74 90.92 81.32
rendering 684.09 701.94 635.51 590.82 1066.68 684.09 735.81 25.82 23.09
CLICK_ON_TABLE_ROW
scripting 1904.66 3089.22 1691.79 2279.41 4346.04 2279.41 2662.22 40.63 36.34
painting 20.12 23.3 22.1 29.68 50.46 23.3 29.13 42.74 38.21
rendering 315.51 418.24 288.23 422.24 1100.72 418.24 508.99 66.05 59.08
UPDATE_POST_TITLE
scripting 2889.16 2911.23 3276.79 2901.39 4986.08 2911.23 3392.93 26.69 23.87
painting 18.48 22.23 19.23 35.89 23.53 22.23 23.87 29.45 26.35
rendering 391.61 395.01 379.37 479.01 507.92 395.01 430.58 13.61 12.17
OPEN_MODAL
scripting 1253.76 1182.85 1097.29 1694.96 1772.64 1253.76 1400.3 22.19 19.84
painting 13.26 9.79 16.95 15.25 13.43 13.43 13.74 19.43 17.39
rendering 464.04 410.85 411.83 665.93 679.19 464.04 526.37 25.70 22.98
CLOSE_MODAL
scripting 757.67 581.68 536.18 956.21 944.59 757.67 755.27 26.01 23.26
painting 5.07 4.61 4.36 8.22 11.25 5.07 6.7 44.48 39.85
rendering 429.98 336.52 333.72 477.98 506.52 429.98 416.94 19.08 17.06
SELECT_WIDGET_MENU_OPEN
scripting 1562.7 2243.13 1883.76 1879.7 1609.4 1879.7 1835.74 14.82 13.25
painting 5.63 20.43 9.51 7.97 11.69 9.51 11.05 51.49 46.06
rendering 542.18 751.79 674.23 701.64 533.83 674.23 640.73 15.27 13.66
SELECT_WIDGET_SELECT_OPTION
scripting 257.3 258.85 330.18 380.44 258.28 258.85 297.01 18.89 16.90
painting 4.02 3.42 4.49 4.8 2.94 4.02 3.93 19.34 17.30
rendering 16.83 20.47 20.16 24.67 17.12 20.16 19.85 15.97 14.31

@arunvjn
Copy link
Contributor Author

arunvjn commented May 19, 2022

/ok-to-test sha=0524342

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2351943194.
Workflow: Appsmith External Integration Test Workflow.
Commit: 0524342.
PR: 13942.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2351943194.
Commit: 0524342.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 804.67 885.29 1282.76 1074.55 877.37 885.29 984.93 19.71 17.63
painting 4.21 7.28 15.77 7.48 7.64 7.48 8.48 50.94 45.52
rendering 324.61 378.94 556.16 464.52 403.71 403.71 425.59 20.82 18.63
BIND_TABLE_DATA
scripting 2270.41 2342.25 2341.59 2316.89 3001.85 2341.59 2454.6 12.52 11.20
painting 18.42 23.93 21.9 43.56 19.25 21.9 25.41 40.85 36.52
rendering 686.27 700.45 752.75 839.89 826.05 752.75 761.08 9.24 8.26
CLICK_ON_TABLE_ROW
scripting 1845.69 2221.01 3355.52 3567.49 2646.29 2646.29 2727.2 26.82 23.99
painting 17.83 20.95 43.17 34.72 34.81 34.72 30.3 34.95 31.25
rendering 308.75 408.57 579.05 816.21 512.92 512.92 525.1 36.66 32.79
UPDATE_POST_TITLE
scripting 2814.41 3150.65 4421.21 3456.17 3934.92 3456.17 3555.47 17.88 15.99
painting 15.57 20.54 35.77 23.97 29.79 23.97 25.13 31.40 28.05
rendering 427.56 452.04 622.81 484.18 652.51 484.18 527.82 19.48 17.42
OPEN_MODAL
scripting 1487.35 1507.91 3521.03 1564.65 1275.88 1507.91 1871.36 49.62 44.39
painting 14.92 14.13 26.64 19.28 12.56 14.92 17.51 32.44 29.01
rendering 559.58 553.82 784.19 518.25 442.22 553.82 571.61 22.34 19.98
CLOSE_MODAL
scripting 749.33 896.02 1190.35 1012.48 748.9 896.02 919.42 20.39 18.24
painting 6.32 7.02 11.41 13.42 6.81 7.02 9 35.67 31.89
rendering 394.57 414 658.56 510.31 473.05 473.05 490.1 21.40 19.14
SELECT_WIDGET_MENU_OPEN
scripting 1719.89 1576.61 1481.41 1717.02 1807.13 1717.02 1660.41 7.81 6.99
painting 5.85 12.16 9.55 16.91 11.97 11.97 11.29 35.78 32.06
rendering 615.7 527.25 512.47 583.84 593.79 583.84 566.61 7.86 7.03
SELECT_WIDGET_SELECT_OPTION
scripting 223.95 229.49 309.07 274.23 291.41 274.23 265.63 14.17 12.68
painting 4.5 3.84 6.38 8.51 9.64 6.38 6.57 38.05 33.94
rendering 22.1 15.11 19.76 20.35 21.72 20.35 19.81 14.13 12.62

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2351943194.
Commit: 0524342.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 804.67 885.29 1282.76 1074.55 877.37 885.29 984.93 19.71 17.63
painting 4.21 7.28 15.77 7.48 7.64 7.48 8.48 50.94 45.52
rendering 324.61 378.94 556.16 464.52 403.71 403.71 425.59 20.82 18.63
BIND_TABLE_DATA
scripting 2270.41 2342.25 2341.59 2316.89 3001.85 2341.59 2454.6 12.52 11.20
painting 18.42 23.93 21.9 43.56 19.25 21.9 25.41 40.85 36.52
rendering 686.27 700.45 752.75 839.89 826.05 752.75 761.08 9.24 8.26
CLICK_ON_TABLE_ROW
scripting 1845.69 2221.01 3355.52 3567.49 2646.29 2646.29 2727.2 26.82 23.99
painting 17.83 20.95 43.17 34.72 34.81 34.72 30.3 34.95 31.25
rendering 308.75 408.57 579.05 816.21 512.92 512.92 525.1 36.66 32.79
UPDATE_POST_TITLE
scripting 2814.41 3150.65 4421.21 3456.17 3934.92 3456.17 3555.47 17.88 15.99
painting 15.57 20.54 35.77 23.97 29.79 23.97 25.13 31.40 28.05
rendering 427.56 452.04 622.81 484.18 652.51 484.18 527.82 19.48 17.42
OPEN_MODAL
scripting 1487.35 1507.91 3521.03 1564.65 1275.88 1507.91 1871.36 49.62 44.39
painting 14.92 14.13 26.64 19.28 12.56 14.92 17.51 32.44 29.01
rendering 559.58 553.82 784.19 518.25 442.22 553.82 571.61 22.34 19.98
CLOSE_MODAL
scripting 749.33 896.02 1190.35 1012.48 748.9 896.02 919.42 20.39 18.24
painting 6.32 7.02 11.41 13.42 6.81 7.02 9 35.67 31.89
rendering 394.57 414 658.56 510.31 473.05 473.05 490.1 21.40 19.14
SELECT_WIDGET_MENU_OPEN
scripting 1719.89 1576.61 1481.41 1717.02 1807.13 1717.02 1660.41 7.81 6.99
painting 5.85 12.16 9.55 16.91 11.97 11.97 11.29 35.78 32.06
rendering 615.7 527.25 512.47 583.84 593.79 583.84 566.61 7.86 7.03
SELECT_WIDGET_SELECT_OPTION
scripting 223.95 229.49 309.07 274.23 291.41 274.23 265.63 14.17 12.68
painting 4.5 3.84 6.38 8.51 9.64 6.38 6.57 38.05 33.94
rendering 22.1 15.11 19.76 20.35 21.72 20.35 19.81 14.13 12.62

@arunvjn
Copy link
Contributor Author

arunvjn commented May 19, 2022

/ok-to-test sha=24484dc

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2353298658.
Workflow: Appsmith External Integration Test Workflow.
Commit: 24484dc.
PR: 13942.

@arunvjn
Copy link
Contributor Author

arunvjn commented May 20, 2022

/ok-to-test sha=0b95306

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2355942345.
Workflow: Appsmith External Integration Test Workflow.
Commit: 0b95306.
PR: 13942.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2355942345.
Commit: 0b95306.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 618.46 585.67 618.12 602.71 653.82 618.12 615.76 4.09 3.66
painting 5.71 5.02 6.06 13.66 5.97 5.97 7.28 49.31 44.09
rendering 287.61 277.85 289.12 300.49 279.95 287.61 287 3.12 2.79
BIND_TABLE_DATA
scripting 2174.73 2211.32 2198.38 2235.14 2643.35 2211.32 2292.58 8.61 7.70
painting 17.38 13.04 14.04 19.35 19.01 17.38 16.56 17.39 15.58
rendering 612.06 587.15 579.13 541.61 600.53 587.15 584.1 4.60 4.12
CLICK_ON_TABLE_ROW
scripting 1696.28 1626.97 1730.25 1607.31 1699.23 1696.28 1672.01 3.13 2.80
painting 12.4 12.89 15.71 18.57 11.4 12.89 14.19 20.58 18.39
rendering 274.33 287.96 306.32 272.72 270.2 274.33 282.31 5.35 4.78
UPDATE_POST_TITLE
scripting 2446.68 2419.94 3266.97 2408.07 2426.28 2426.28 2593.59 14.52 12.99
painting 19.17 13.95 20.13 16.28 16.14 16.28 17.13 14.59 13.08
rendering 353.07 347.96 362.5 353.69 360.49 353.69 355.54 1.66 1.49
OPEN_MODAL
scripting 1134.54 1977.75 1046.33 1090.45 1045.7 1090.45 1258.95 32.05 28.67
painting 9.95 8.64 11.39 8.98 9.76 9.76 9.74 10.99 9.75
rendering 404.22 392.36 395.86 435.55 399.9 399.9 405.58 4.27 3.82
CLOSE_MODAL
scripting 1520.98 623.34 2060.58 666.97 608.11 666.97 1096 60.46 54.08
painting 10.37 4.8 8.25 11.13 10.34 10.34 8.98 28.62 25.61
rendering 326.61 363.54 371.54 355.73 319.34 355.73 347.35 6.65 5.95
SELECT_WIDGET_MENU_OPEN
scripting 1519.56 1455.51 1440.89 1465.47 1451.68 1455.51 1466.62 2.10 1.88
painting 4.91 7.9 8.24 7.44 5.96 7.44 6.89 20.46 18.29
rendering 489.8 488.88 475.24 469.95 471.85 475.24 479.14 1.98 1.77
SELECT_WIDGET_SELECT_OPTION
scripting 174.04 191.38 286.62 212.29 187.86 191.38 210.44 21.26 19.01
painting 2.97 8.51 3.12 4.41 9.24 4.41 5.65 53.27 47.61
rendering 14.42 13.13 14.11 14.36 14.48 14.36 14.1 3.97 3.55

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2355942345.
Commit: 0b95306.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 618.46 585.67 618.12 602.71 653.82 618.12 615.76 4.09 3.66
painting 5.71 5.02 6.06 13.66 5.97 5.97 7.28 49.31 44.09
rendering 287.61 277.85 289.12 300.49 279.95 287.61 287 3.12 2.79
BIND_TABLE_DATA
scripting 2174.73 2211.32 2198.38 2235.14 2643.35 2211.32 2292.58 8.61 7.70
painting 17.38 13.04 14.04 19.35 19.01 17.38 16.56 17.39 15.58
rendering 612.06 587.15 579.13 541.61 600.53 587.15 584.1 4.60 4.12
CLICK_ON_TABLE_ROW
scripting 1696.28 1626.97 1730.25 1607.31 1699.23 1696.28 1672.01 3.13 2.80
painting 12.4 12.89 15.71 18.57 11.4 12.89 14.19 20.58 18.39
rendering 274.33 287.96 306.32 272.72 270.2 274.33 282.31 5.35 4.78
UPDATE_POST_TITLE
scripting 2446.68 2419.94 3266.97 2408.07 2426.28 2426.28 2593.59 14.52 12.99
painting 19.17 13.95 20.13 16.28 16.14 16.28 17.13 14.59 13.08
rendering 353.07 347.96 362.5 353.69 360.49 353.69 355.54 1.66 1.49
OPEN_MODAL
scripting 1134.54 1977.75 1046.33 1090.45 1045.7 1090.45 1258.95 32.05 28.67
painting 9.95 8.64 11.39 8.98 9.76 9.76 9.74 10.99 9.75
rendering 404.22 392.36 395.86 435.55 399.9 399.9 405.58 4.27 3.82
CLOSE_MODAL
scripting 1520.98 623.34 2060.58 666.97 608.11 666.97 1096 60.46 54.08
painting 10.37 4.8 8.25 11.13 10.34 10.34 8.98 28.62 25.61
rendering 326.61 363.54 371.54 355.73 319.34 355.73 347.35 6.65 5.95
SELECT_WIDGET_MENU_OPEN
scripting 1519.56 1455.51 1440.89 1465.47 1451.68 1455.51 1466.62 2.10 1.88
painting 4.91 7.9 8.24 7.44 5.96 7.44 6.89 20.46 18.29
rendering 489.8 488.88 475.24 469.95 471.85 475.24 479.14 1.98 1.77
SELECT_WIDGET_SELECT_OPTION
scripting 174.04 191.38 286.62 212.29 187.86 191.38 210.44 21.26 19.01
painting 2.97 8.51 3.12 4.41 9.24 4.41 5.65 53.27 47.61
rendering 14.42 13.13 14.11 14.36 14.48 14.36 14.1 3.97 3.55

@arunvjn arunvjn merged commit 9753df5 into release May 20, 2022
@arunvjn arunvjn deleted the fix/remove-explorer-animation branch May 20, 2022 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albinAppsmith albinAppsmith albinAppsmith approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working Entity Explorer Issues related to navigation using the entity explorer Medium Issues that frustrate users due to poor UX New Developers Pod Issues that new developers face while exploring the IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Animation on switching tab in Entity Explorer
2 participants
@arunvjn @albinAppsmith