Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix validation check that is blocking input from changing #13943

Merged
merged 4 commits into from
May 18, 2022
Merged

fix: Fix validation check that is blocking input from changing #13943

merged 4 commits into from
May 18, 2022

Conversation

Irongade
Copy link
Contributor

@Irongade Irongade commented May 18, 2022 •
edited

Fixes validation regex checks blocking onChange function from firing in KeyValue array form input.

Fixes #13919

if no issue exists, please create an issue and ask the maintainers about this first

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

I wrote cypress tests that creates an Elastic search datasource and fills the datasource configuration inputs with custom values, This asserts that we can type any value in those inputs and configure the elastic search datasource.

Screenshot 2022-05-19 at 15 35 01

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🟢 Total coverage has increased 
// Code coverage diff between base branch:release and head branch: fix/fix-key-value-validation-check
Status File % Stmts % Branch % Funcs % Lines
🟢 total 56.65 (0.01) 38.62 (0.01) 35.97 (0) 56.9 (0.01)
🟢 app/client/src/components/ads/TextInput.tsx 79.84 (0.61) 63.89 (1.3) 87.5 (0) 78.63 (0.66)
🟢 app/client/src/utils/autocomplete/TernServer.ts 52.94 (0.23) 41.67 (0.84) 36.21 (0) 56.99 (0.25)

@vercel
Copy link

vercel bot commented May 18, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview May 18, 2022 at 4:40PM (UTC)

rashmi-rai
rashmi-rai previously approved these changes May 18, 2022
View reviewed changes
@github-actions github-actions bot added Actions Pod BE Coders Pod Issues related to users writing code to fetch and update data Bug Something isn't working Critical This issue needs immediate attention. Drop everything else Datasources Issues related to configuring datasource on appsmith Needs Triaging Needs attention from maintainers to triage Regressed Scenarios that were working before but have now regressed labels May 18, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

1 similar comment
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@Irongade Irongade requested a review from rashmi-rai May 18, 2022 14:35
@Irongade
Copy link
Contributor Author

/ok-to-test sha=58a9869

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2346242631.
Workflow: Appsmith External Integration Test Workflow.
Commit: 58a9869.
PR: 13943.

@Irongade
Copy link
Contributor Author

/ok-to-test sha=83b9bc0

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2346324647.
Workflow: Appsmith External Integration Test Workflow.
Commit: 83b9bc0.
PR: 13943.

Aishwarya-U-R
Aishwarya-U-R previously approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@Aishwarya-U-R Aishwarya-U-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed Cypress test, LGTM

@Aishwarya-U-R Aishwarya-U-R added the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label May 18, 2022
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2346242631.
Commit: 58a9869.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 2726.46 2647.79 2639.05 2599.02 2624.44 2639.05 2647.35 1.81 1.62
painting 23.23 13.53 20.14 16.02 16.87 16.87 17.96 21.05 18.82
rendering 1211.97 1141.4 1195.89 1179.57 1217.27 1195.89 1189.22 2.57 2.30
SELECT_WIDGET_SELECT_OPTION
scripting 433.67 435.03 384.58 381.3 389 389 404.72 6.72 6.01
painting 19.62 4.63 22.42 3.59 5.28 5.28 11.11 82.09 73.45
rendering 28.54 27.11 24.6 24.49 24 24.6 25.75 7.69 6.87

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2346242631.
Commit: 58a9869.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 2726.46 2647.79 2639.05 2599.02 2624.44 2639.05 2647.35 1.81 1.62
painting 23.23 13.53 20.14 16.02 16.87 16.87 17.96 21.05 18.82
rendering 1211.97 1141.4 1195.89 1179.57 1217.27 1195.89 1189.22 2.57 2.30
SELECT_WIDGET_SELECT_OPTION
scripting 433.67 435.03 384.58 381.3 389 389 404.72 6.72 6.01
painting 19.62 4.63 22.42 3.59 5.28 5.28 11.11 82.09 73.45
rendering 28.54 27.11 24.6 24.49 24 24.6 25.75 7.69 6.87

@Irongade
Copy link
Contributor Author

/ok-to-test sha=08cc7fd

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2346895661.
Workflow: Appsmith External Integration Test Workflow.
Commit: 08cc7fd.
PR: 13943.

@Irongade Irongade enabled auto-merge (squash) May 18, 2022 16:34
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2346895661.
Commit: 08cc7fd.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 2277.86 2235.02 2362.89 2305.31 2327.57 2305.31 2301.73 2.11 1.89
painting 9.14 15.41 18.89 13.11 27.38 15.41 16.79 41.10 36.75
rendering 779.32 771.64 870.4 749.45 778.24 778.24 789.81 5.90 5.28
SELECT_WIDGET_SELECT_OPTION
scripting 372.82 348.22 311.92 367.49 347.61 348.22 349.61 6.84 6.12
painting 3.85 8.14 5.8 36.44 6.55 6.55 12.16 112.34 100.49
rendering 30.96 25.5 21.68 21.12 22.8 22.8 24.41 16.51 14.75

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2346895661.
Commit: 08cc7fd.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 2277.86 2235.02 2362.89 2305.31 2327.57 2305.31 2301.73 2.11 1.89
painting 9.14 15.41 18.89 13.11 27.38 15.41 16.79 41.10 36.75
rendering 779.32 771.64 870.4 749.45 778.24 778.24 789.81 5.90 5.28
SELECT_WIDGET_SELECT_OPTION
scripting 372.82 348.22 311.92 367.49 347.61 348.22 349.61 6.84 6.12
painting 3.85 8.14 5.8 36.44 6.55 6.55 12.16 112.34 100.49
rendering 30.96 25.5 21.68 21.12 22.8 22.8 24.41 16.51 14.75

Aishwarya-U-R
Aishwarya-U-R approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@Aishwarya-U-R Aishwarya-U-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cypress tests LGTM

@Irongade Irongade merged commit 1ee494b into release May 18, 2022
@Irongade Irongade deleted the fix/fix-key-value-validation-check branch May 18, 2022 17:35
@github-actions github-actions bot added the QA Needs QA attention label May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmanAgarwal041 AmanAgarwal041 AmanAgarwal041 approved these changes

@rashmi-rai rashmi-rai rashmi-rai approved these changes

@Aishwarya-U-R Aishwarya-U-R Aishwarya-U-R approved these changes

Assignees
No one assigned
Labels
BE Coders Pod Issues related to users writing code to fetch and update data Bug Something isn't working Critical This issue needs immediate attention. Drop everything else Datasources Issues related to configuring datasource on appsmith Needs Triaging Needs attention from maintainers to triage QA Needs QA attention Regressed Scenarios that were working before but have now regressed Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: [REGRESSION] Unable to configure Elasticsearch datasource
4 participants
@Irongade @AmanAgarwal041 @rashmi-rai @Aishwarya-U-R