Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Error message thrown on reset password from user profile screen #13974

Merged
merged 1 commit into from
May 20, 2022

Conversation

arunvjn
Copy link
Contributor

@arunvjn arunvjn commented May 20, 2022

Description

Fixes "There was an unexpected error" error message in reset password flow from user profile screen.

Fixes #13872

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

⚪ Total coverage has not changed
// Code coverage diff between base branch:release and head branch: fix/reset-password-error-message 
Status File % Stmts % Branch % Funcs % Lines
🟢 app/client/src/selectors/commentsSelectors.ts 85.25 (1.64) 64.71 (2.95) 73.33 (0) 90.59 (2.35)
🔴 app/client/src/utils/autocomplete/TernServer.ts 52.71 (-0.23) 40.83 (-0.84) 36.21 (0) 56.74 (-0.25)

@vercel
Copy link

vercel bot commented May 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview May 20, 2022 at 6:20AM (UTC)

@github-actions github-actions bot added Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage New Developers Pod Issues that new developers face while exploring the IDE Platform Pod Welcome Screen Issues related to the welcome screen labels May 20, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@arunvjn
Copy link
Contributor Author

arunvjn commented May 20, 2022

/ok-to-test sha=7ac8071

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2356528681.
Workflow: Appsmith External Integration Test Workflow.
Commit: 7ac8071.
PR: 13974.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2356528681.
Commit: 7ac8071.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 2698.07 2746.98 2880.95 2758.95 2754.75 2754.75 2767.94 2.45 2.19
painting 18.83 26.28 24.22 16.09 23.23 23.23 21.73 19.14 17.12
rendering 1217.32 1222.13 1356.33 1221.1 1224.75 1222.13 1248.33 4.84 4.33
SELECT_WIDGET_SELECT_OPTION
scripting 409.13 428.96 423.83 450.64 429.05 428.96 428.32 3.48 3.11
painting 10.98 7.07 8.07 9.36 7.19 8.07 8.53 19.34 17.23
rendering 30.28 28.71 31.81 26.31 25.73 28.71 28.57 9.03 8.09

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2356528681.
Commit: 7ac8071.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 2698.07 2746.98 2880.95 2758.95 2754.75 2754.75 2767.94 2.45 2.19
painting 18.83 26.28 24.22 16.09 23.23 23.23 21.73 19.14 17.12
rendering 1217.32 1222.13 1356.33 1221.1 1224.75 1222.13 1248.33 4.84 4.33
SELECT_WIDGET_SELECT_OPTION
scripting 409.13 428.96 423.83 450.64 429.05 428.96 428.32 3.48 3.11
painting 10.98 7.07 8.07 9.36 7.19 8.07 8.53 19.34 17.23
rendering 30.28 28.71 31.81 26.31 25.73 28.71 28.57 9.03 8.09

@arunvjn arunvjn merged commit da1a57d into release May 20, 2022
@arunvjn arunvjn deleted the fix/reset-password-error-message branch May 20, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage New Developers Pod Issues that new developers face while exploring the IDE Welcome Screen Issues related to the welcome screen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Welcome screen - Edit profile - Reset password - "There was an unexpected error" message displayed
2 participants