Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing application id in comment threads API #14011

Merged
merged 2 commits into from
May 25, 2022
Merged

fix: missing application id in comment threads API #14011

merged 2 commits into from
May 25, 2022

Conversation

arunvjn
Copy link
Contributor

@arunvjn arunvjn commented May 23, 2022 •
edited by github-actions bot

Description

Fixes the error toast message that says "Please enter a valid applicationId".
This has to do with the comments component mounted and it the fetch threads API being called before the applicationId is retrieved. This PR delays the comments component mount in the application header.

Fixes #13489

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

⚪ Total coverage has not changed 
// Code coverage diff between base branch:release and head branch: fix/missing-app-id
Status File % Stmts % Branch % Funcs % Lines
🔴 app/client/src/pages/Editor/EditorHeader.tsx 86.99 (-0.26) 53.09 (-0.48) 62.5 (0) 86.33 (-0.29)
🟢 app/client/src/pages/Editor/ToggleModeButton.tsx 38.73 (1.32) 11.49 (-0.71) 17.24 (0) 38.17 (1.45)
🟢 app/client/src/reducers/uiReducers/appViewReducer.tsx 50 (4.55) 100 (0) 14.29 (14.29) 50 (4.55)
🟢 app/client/src/utils/autocomplete/TernServer.ts 52.94 (0.23) 41.67 (0.84) 36.21 (0) 56.99 (0.25)

@vercel
Copy link

vercel bot commented May 23, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview May 23, 2022 at 10:11AM (UTC)

@github-actions github-actions bot added Bug Something isn't working Home Page Issues related to the application home page Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage New Developers Pod Issues that new developers face while exploring the IDE Platform Pod Regressed Scenarios that were working before but have now regressed Reopen Team Managers Pod Issues that team managers care about for the security and efficiency of their teams Verified When issue is retested post its fixed labels May 23, 2022
@arunvjn arunvjn requested a review from Parthvi12 May 23, 2022 03:23
@arunvjn
Copy link
Contributor Author

arunvjn commented May 23, 2022

@Parthvi12 Can you please test out the DP ?

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@arunvjn
Copy link
Contributor Author

arunvjn commented May 23, 2022

/ok-to-test sha=5217a6e

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

5 similar comments
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2368777917.
Workflow: Appsmith External Integration Test Workflow.
Commit: 5217a6e.
PR: 14011.

@arunvjn arunvjn removed the Regressed Scenarios that were working before but have now regressed label May 23, 2022
@github-actions github-actions bot added the Regressed Scenarios that were working before but have now regressed label May 23, 2022
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2368777917.
Commit: 5217a6e.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 2044.37 2036.33 2088.42 2009.52 2250.47 2044.37 2085.82 4.62 4.13
painting 14.55 17.78 11.04 21.43 9.5 14.55 14.86 32.84 29.34
rendering 716.94 728 707.91 720.83 789.38 720.83 732.61 4.44 3.97
SELECT_WIDGET_SELECT_OPTION
scripting 312.84 356.52 456.29 307.92 358.69 356.52 358.45 16.63 14.87
painting 4.38 14.54 21.53 11.13 15.93 14.54 13.5 46.89 41.93
rendering 23.94 22.48 24.17 21.48 23.05 23.05 23.02 4.78 4.26
SELECT_CATEGORY
scripting 1096.81 1112.05 1134.51 1186.68 2468.58 1134.51 1399.73 42.76 38.24
painting 8.84 15.64 13.79 8.34 9.48 9.48 11.22 29.23 26.20
rendering 429.87 417.26 417.34 430.83 423.2 423.2 423.7 1.54 1.38
BIND_TABLE_DATA
scripting 2245.44 2197.65 2226.19 2066.01 2125.7 2197.65 2172.2 3.44 3.08
painting 29.49 26.73 27.71 26.44 52.22 27.71 32.52 34.07 30.47
rendering 970.74 1010.94 1009.26 1165.6 976.42 1009.26 1026.59 7.78 6.96
CLICK_ON_TABLE_ROW
scripting 5043.98 4887.19 4949.15 4682.77 4592.98 4887.19 4831.21 3.89 3.48
painting 60.18 78.91 72.4 103.96 43.82 72.4 71.85 31.15 27.86
rendering 1399.59 1566.17 1158.95 1261.19 1068.18 1261.19 1290.82 15.27 13.66
UPDATE_POST_TITLE
scripting 4632.4 4709.26 4445.4 4374.5 4610.63 4610.63 4554.44 3.06 2.73
painting 32.52 27.84 38.12 25.24 46.77 32.52 34.1 25.25 22.61
rendering 561.33 556.92 576.68 564.38 565.93 564.38 565.05 1.30 1.16
OPEN_MODAL
scripting 1904.05 1929.45 2059.3 4304.39 1952.75 1952.75 2429.99 43.19 38.63
painting 26.02 47.04 24.86 16.64 17.32 24.86 26.38 46.66 41.74
rendering 619.53 655.74 661.27 650.4 632.65 650.4 643.92 2.69 2.41
CLOSE_MODAL
scripting 940.34 1077.68 988.5 1431.38 1123.73 1077.68 1112.33 17.30 15.47
painting 15.64 10.25 7.49 44.41 15.71 15.64 18.7 79.14 70.80
rendering 602.08 666.47 524.81 541.33 498.97 541.33 566.73 11.90 10.64

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2368777917.
Commit: 5217a6e.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 2044.37 2036.33 2088.42 2009.52 2250.47 2044.37 2085.82 4.62 4.13
painting 14.55 17.78 11.04 21.43 9.5 14.55 14.86 32.84 29.34
rendering 716.94 728 707.91 720.83 789.38 720.83 732.61 4.44 3.97
SELECT_WIDGET_SELECT_OPTION
scripting 312.84 356.52 456.29 307.92 358.69 356.52 358.45 16.63 14.87
painting 4.38 14.54 21.53 11.13 15.93 14.54 13.5 46.89 41.93
rendering 23.94 22.48 24.17 21.48 23.05 23.05 23.02 4.78 4.26
SELECT_CATEGORY
scripting 1096.81 1112.05 1134.51 1186.68 2468.58 1134.51 1399.73 42.76 38.24
painting 8.84 15.64 13.79 8.34 9.48 9.48 11.22 29.23 26.20
rendering 429.87 417.26 417.34 430.83 423.2 423.2 423.7 1.54 1.38
BIND_TABLE_DATA
scripting 2245.44 2197.65 2226.19 2066.01 2125.7 2197.65 2172.2 3.44 3.08
painting 29.49 26.73 27.71 26.44 52.22 27.71 32.52 34.07 30.47
rendering 970.74 1010.94 1009.26 1165.6 976.42 1009.26 1026.59 7.78 6.96
CLICK_ON_TABLE_ROW
scripting 5043.98 4887.19 4949.15 4682.77 4592.98 4887.19 4831.21 3.89 3.48
painting 60.18 78.91 72.4 103.96 43.82 72.4 71.85 31.15 27.86
rendering 1399.59 1566.17 1158.95 1261.19 1068.18 1261.19 1290.82 15.27 13.66
UPDATE_POST_TITLE
scripting 4632.4 4709.26 4445.4 4374.5 4610.63 4610.63 4554.44 3.06 2.73
painting 32.52 27.84 38.12 25.24 46.77 32.52 34.1 25.25 22.61
rendering 561.33 556.92 576.68 564.38 565.93 564.38 565.05 1.30 1.16
OPEN_MODAL
scripting 1904.05 1929.45 2059.3 4304.39 1952.75 1952.75 2429.99 43.19 38.63
painting 26.02 47.04 24.86 16.64 17.32 24.86 26.38 46.66 41.74
rendering 619.53 655.74 661.27 650.4 632.65 650.4 643.92 2.69 2.41
CLOSE_MODAL
scripting 940.34 1077.68 988.5 1431.38 1123.73 1077.68 1112.33 17.30 15.47
painting 15.64 10.25 7.49 44.41 15.71 15.64 18.7 79.14 70.80
rendering 602.08 666.47 524.81 541.33 498.97 541.33 566.73 11.90 10.64

@Parthvi12
Copy link
Contributor

@arunvjn For existing app its working fine but I am seeing this toast message on creating new app Screenshot 2022-05-23 at 9 52 32 AM

@arunvjn
Copy link
Contributor Author

arunvjn commented May 23, 2022

/ok-to-test sha=53ddb8d

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2370498136.
Workflow: Appsmith External Integration Test Workflow.
Commit: 53ddb8d.
PR: 14011.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2370498136.
Commit: 53ddb8d.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 2366.83 2483.25 2554.33 2549.53 2407.95 2483.25 2472.38 3.39 3.03
painting 18.42 14.62 13.76 19.28 17.43 17.43 16.7 14.37 12.87
rendering 836.69 959.41 961.17 875.96 837.94 875.96 894.23 6.97 6.23
SELECT_WIDGET_SELECT_OPTION
scripting 364.8 419.8 392.25 366 357.69 366 380.11 6.78 6.07
painting 4.62 3.75 9.68 13.88 7.65 7.65 7.92 51.64 46.21
rendering 23.72 23.75 23.19 23.41 22.02 23.41 23.22 3.06 2.71

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2370498136.
Commit: 53ddb8d.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 2366.83 2483.25 2554.33 2549.53 2407.95 2483.25 2472.38 3.39 3.03
painting 18.42 14.62 13.76 19.28 17.43 17.43 16.7 14.37 12.87
rendering 836.69 959.41 961.17 875.96 837.94 875.96 894.23 6.97 6.23
SELECT_WIDGET_SELECT_OPTION
scripting 364.8 419.8 392.25 366 357.69 366 380.11 6.78 6.07
painting 4.62 3.75 9.68 13.88 7.65 7.65 7.92 51.64 46.21
rendering 23.72 23.75 23.19 23.41 22.02 23.41 23.22 3.06 2.71

@Parthvi12
Copy link
Contributor

Tested the dp and its working as expected @arunvjn

@arunvjn arunvjn merged commit 82328f4 into release May 25, 2022
@arunvjn arunvjn deleted the fix/missing-app-id branch May 25, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albinAppsmith albinAppsmith albinAppsmith approved these changes

@Parthvi12 Parthvi12 Awaiting requested review from Parthvi12

Assignees
No one assigned
Labels
Bug Something isn't working Home Page Issues related to the application home page Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage New Developers Pod Issues that new developers face while exploring the IDE Regressed Scenarios that were working before but have now regressed Reopen Team Managers Pod Issues that team managers care about for the security and efficiency of their teams Verified When issue is retested post its fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Error is displayed when a new application is created
3 participants
@arunvjn @Parthvi12 @albinAppsmith