Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Redirect to website home instead of appsmith home on watermark #14018

Merged
merged 2 commits into from
May 23, 2022
Merged

fix: Redirect to website home instead of appsmith home on watermark #14018

merged 2 commits into from
May 23, 2022

Conversation

jsartisan
Copy link
Contributor

@jsartisan jsartisan commented May 23, 2022 •
edited by github-actions bot

Fixes #14017

Type of change

  • Bug fix

How Has This Been Tested?

  • Manually tested

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

⚪ Total coverage has not changed 
// Code coverage diff between base branch:release and head branch: fix/branding-badge-url
Status File % Stmts % Branch % Funcs % Lines
🟢 app/client/src/selectors/commentsSelectors.ts 85.25 (1.64) 64.71 (2.95) 73.33 (0) 90.59 (2.35)
🔴 app/client/src/utils/autocomplete/TernServer.ts 52.71 (-0.23) 40.83 (-0.84) 36.21 (0) 56.74 (-0.25)

@vercel
Copy link

vercel bot commented May 23, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview May 23, 2022 at 8:14AM (UTC)

@github-actions github-actions bot added App Theming Items that are related to the App level theming controls epic App Viewers Pod This label assigns issues to the app viewers pod Enhancement New feature or request High This issue blocks a user from building or impacts a lot of users UI Building Pod Bug Something isn't working and removed Enhancement New feature or request labels May 23, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions github-actions bot added the Enhancement New feature or request label May 23, 2022
somangshu
somangshu approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@somangshu somangshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsartisan
Copy link
Contributor Author

/ok-to-test sha=bf5e0c7

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2370631805.
Workflow: Appsmith External Integration Test Workflow.
Commit: bf5e0c7.
PR: 14018.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2370631805.
Commit: bf5e0c7.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1521.39 1713.07 1647.59 1532.98 1645.52 1645.52 1612.11 5.10 4.56
painting 10.77 13.76 13.63 6.25 14.34 13.63 11.75 28.68 25.70
rendering 523.67 604.55 539.69 527.15 619.32 539.69 562.88 8.08 7.23
SELECT_WIDGET_SELECT_OPTION
scripting 243.8 232.62 285.57 215.78 214.02 232.62 238.36 12.22 10.93
painting 9.12 4.63 2.82 3.54 3.51 3.54 4.72 53.81 48.09
rendering 17.66 18.43 17.29 15.63 15.94 17.29 16.99 6.95 6.18

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2370631805.
Commit: bf5e0c7.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1521.39 1713.07 1647.59 1532.98 1645.52 1645.52 1612.11 5.10 4.56
painting 10.77 13.76 13.63 6.25 14.34 13.63 11.75 28.68 25.70
rendering 523.67 604.55 539.69 527.15 619.32 539.69 562.88 8.08 7.23
SELECT_WIDGET_SELECT_OPTION
scripting 243.8 232.62 285.57 215.78 214.02 232.62 238.36 12.22 10.93
painting 9.12 4.63 2.82 3.54 3.51 3.54 4.72 53.81 48.09
rendering 17.66 18.43 17.29 15.63 15.94 17.29 16.99 6.95 6.18

@jsartisan jsartisan merged commit 297421b into release May 23, 2022
@jsartisan jsartisan deleted the fix/branding-badge-url branch May 23, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@somangshu somangshu somangshu approved these changes

@dilippitchika dilippitchika Awaiting requested review from dilippitchika

Assignees
No one assigned
Labels
App Theming Items that are related to the App level theming controls epic App Viewers Pod This label assigns issues to the app viewers pod Bug Something isn't working Enhancement New feature or request High This issue blocks a user from building or impacts a lot of users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Redirect to website home instead of appsmith home on watermark
2 participants
@jsartisan @somangshu