Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for running migrations before application start #14025

Merged
merged 2 commits into from
May 23, 2022
Merged

Fix for running migrations before application start #14025

merged 2 commits into from
May 23, 2022

Conversation

sidhantgoel
Copy link
Contributor

Pull Request Template

Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request.

Description

Migrations should run before application is started to avoid side effects caused by API calls

Fixes # (issue)

if no issue exists, please create an issue and ask the maintainers about this first

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented May 23, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview May 23, 2022 at 10:55AM (UTC)

@sidhantgoel
Copy link
Contributor Author

/ok-to-test sha=54b82d050212c2f862ece30be5e95b9a075cba24

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2370537113.
Workflow: Appsmith External Integration Test Workflow.
Commit: 54b82d050212c2f862ece30be5e95b9a075cba24.
PR: 14025.

@sidhantgoel sidhantgoel added the Team Managers Pod Issues that team managers care about for the security and efficiency of their teams label May 23, 2022
trishaanand
trishaanand previously approved these changes May 23, 2022
View reviewed changes
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2370537113.
Commit: 54b82d050212c2f862ece30be5e95b9a075cba24.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1913.53 1717.16 1657.21 1739.57 1863.82 1739.57 1778.26 6.00 5.36
painting 18.15 11.36 15.38 6.65 14.55 14.55 13.22 33.28 29.73
rendering 788.08 641.19 613.61 632.75 761.55 641.19 687.44 11.77 10.53
SELECT_WIDGET_SELECT_OPTION
scripting 285 287.63 358.84 319 351.21 319 320.34 10.76 9.63
painting 4.07 4.19 11.72 5.46 4.79 4.79 6.05 53.22 47.60
rendering 21.52 25.83 25.02 27.76 23.28 25.02 24.68 9.68 8.67

@sidhantgoel sidhantgoel merged commit d60057a into release May 23, 2022
@sidhantgoel sidhantgoel deleted the fix/migration_before_application_start branch May 23, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trishaanand trishaanand trishaanand approved these changes

Assignees
No one assigned
Labels
Team Managers Pod Issues that team managers care about for the security and efficiency of their teams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sidhantgoel @trishaanand