fix: stop showing errored widget labels prmanently and show them only on hover or when selected

[rahulramesha]

Description

Changed the condition to display errored widgetLabel only when focused or selected and not permanently.

Fixes #13873

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual UI verification

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

Test coverage results 🧪

⚪ Total coverage has not changed

// Code coverage diff between base branch:release and head branch: widgetLabelErrorFix 

Status	File	% Stmts	% Branch	% Funcs	% Lines
🟢	app/client/src/components/editorComponents/WidgetNameComponent/index.tsx	96.97 (0)	84.91 (1.27)	100 (0)	96.88 (0)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
appsmith	✅ Ready (Inspect)	Visit Preview	May 24, 2022 at 0:48AM (UTC)

[github-actions]

Unable to find test scripts. Please add necessary tests to the PR.

[github-actions]

Unable to find test scripts. Please add necessary tests to the PR.

[github-actions]

Unable to find test scripts. Please add necessary tests to the PR.

[github-actions]

Unable to find test scripts. Please add necessary tests to the PR.

[github-actions]

Unable to find test scripts. Please add necessary tests to the PR.

[rahulramesha]

/ok-to-test sha=9e09e35

[github-actions]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2377920560.
Workflow: Appsmith External Integration Test Workflow.
Commit: 9e09e35.
PR: 14064.

[github-actions]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2377920560.
Commit: 9e09e35.
Results:

Click to view performance test results

	Run 1	Run 2	Run 3	Run 4	Run 5	Median	Mean	SD.Sample	SD.Population
SELECT_CATEGORY
scripting	549.12	567.48	551.01	564.01	498.9	551.01	546.1	5.05	4.51
painting	4.65	5.47	9.08	3.71	4.31	4.65	5.44	39.15	34.93
rendering	265.76	255.62	290.41	279.28	251.84	265.76	268.58	6.02	5.39
BIND_TABLE_DATA
scripting	2233.52	2251.01	2232.34	2216.66	2244.28	2233.52	2235.56	0.59	0.52
painting	15.23	12.65	11.94	11.87	16.6	12.65	13.66	15.67	13.98
rendering	536.83	516.11	504.86	491.37	531.2	516.11	516.07	3.62	3.24
CLICK_ON_TABLE_ROW
scripting	1457.73	1361.61	1266.57	1330.13	1663.25	1361.61	1415.86	10.91	9.76
painting	15.06	15.08	15.59	14	14.8	15.06	14.91	3.89	3.49
rendering	263.79	251.04	246.32	244.04	261.41	251.04	253.32	3.51	3.13
UPDATE_POST_TITLE
scripting	2033.48	2216.46	2195.65	2097.26	2501.11	2195.65	2208.79	8.13	7.27
painting	17.24	19.24	13.95	14.44	46.03	17.24	22.18	60.87	54.46
rendering	329.75	338.01	346.86	338.11	325.48	338.01	335.64	2.47	2.21
OPEN_MODAL
scripting	902.86	1735.17	895.03	908.52	968.63	908.52	1082.04	33.85	30.28
painting	15.91	13.4	8.4	8.67	10.4	10.4	11.36	28.43	25.44
rendering	375.69	374.06	373.78	420.36	387.33	375.69	386.24	5.15	4.60
CLOSE_MODAL
scripting	700.4	567.41	602.07	667.51	620.19	620.19	631.52	8.36	7.48
painting	4.92	5.85	3.95	5.09	7.09	5.09	5.38	21.75	19.52
rendering	341.96	303.38	305.77	322.9	322.73	322.73	319.35	4.89	4.37
SELECT_WIDGET_MENU_OPEN
scripting	1355.18	1486.76	1501.59	1549.12	1510.8	1501.59	1480.69	4.99	4.46
painting	7.25	8.94	10.89	3.95	5.17	7.25	7.24	38.67	34.53
rendering	411.64	455.22	437.33	449.91	424.03	437.33	435.63	4.14	3.70
SELECT_WIDGET_SELECT_OPTION
scripting	215.53	197.94	252.3	197.33	239.51	215.53	220.52	11.21	10.02
painting	2.86	2.32	6.75	3.03	5.52	3.03	4.1	47.07	42.20
rendering	13.31	13.35	12.45	15.76	15.14	13.35	14	9.93	8.86

[github-actions]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2377920560.
Commit: 9e09e35.
Results:

Click to view performance test results

	Run 1	Run 2	Run 3	Run 4	Run 5	Median	Mean	SD.Sample	SD.Population
SELECT_CATEGORY
scripting	549.12	567.48	551.01	564.01	498.9	551.01	546.1	5.05	4.51
painting	4.65	5.47	9.08	3.71	4.31	4.65	5.44	39.15	34.93
rendering	265.76	255.62	290.41	279.28	251.84	265.76	268.58	6.02	5.39
BIND_TABLE_DATA
scripting	2233.52	2251.01	2232.34	2216.66	2244.28	2233.52	2235.56	0.59	0.52
painting	15.23	12.65	11.94	11.87	16.6	12.65	13.66	15.67	13.98
rendering	536.83	516.11	504.86	491.37	531.2	516.11	516.07	3.62	3.24
CLICK_ON_TABLE_ROW
scripting	1457.73	1361.61	1266.57	1330.13	1663.25	1361.61	1415.86	10.91	9.76
painting	15.06	15.08	15.59	14	14.8	15.06	14.91	3.89	3.49
rendering	263.79	251.04	246.32	244.04	261.41	251.04	253.32	3.51	3.13
UPDATE_POST_TITLE
scripting	2033.48	2216.46	2195.65	2097.26	2501.11	2195.65	2208.79	8.13	7.27
painting	17.24	19.24	13.95	14.44	46.03	17.24	22.18	60.87	54.46
rendering	329.75	338.01	346.86	338.11	325.48	338.01	335.64	2.47	2.21
OPEN_MODAL
scripting	902.86	1735.17	895.03	908.52	968.63	908.52	1082.04	33.85	30.28
painting	15.91	13.4	8.4	8.67	10.4	10.4	11.36	28.43	25.44
rendering	375.69	374.06	373.78	420.36	387.33	375.69	386.24	5.15	4.60
CLOSE_MODAL
scripting	700.4	567.41	602.07	667.51	620.19	620.19	631.52	8.36	7.48
painting	4.92	5.85	3.95	5.09	7.09	5.09	5.38	21.75	19.52
rendering	341.96	303.38	305.77	322.9	322.73	322.73	319.35	4.89	4.37
SELECT_WIDGET_MENU_OPEN
scripting	1355.18	1486.76	1501.59	1549.12	1510.8	1501.59	1480.69	4.99	4.46
painting	7.25	8.94	10.89	3.95	5.17	7.25	7.24	38.67	34.53
rendering	411.64	455.22	437.33	449.91	424.03	437.33	435.63	4.14	3.70
SELECT_WIDGET_SELECT_OPTION
scripting	215.53	197.94	252.3	197.33	239.51	215.53	220.52	11.21	10.02
painting	2.86	2.32	6.75	3.03	5.52	3.03	4.1	47.07	42.20
rendering	13.31	13.35	12.45	15.76	15.14	13.35	14	9.93	8.86

[btsgh]

As per the discussion in the associated bug, the errored widget label does not show up permanently. It only shows up on hover. If we move the mouse pointer away from it, the error message goes away.