Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update error highlight border in RTE widget #14112

Merged
merged 7 commits into from
Jun 1, 2022
Merged

fix: update error highlight border in RTE widget #14112

merged 7 commits into from
Jun 1, 2022

Conversation

techbhavin
Copy link
Contributor

@techbhavin techbhavin commented May 26, 2022 •
edited by github-actions bot

Description

In RTE Widget Remove Error Highlight from the label and apply only on RTE input.

Fixes #14019

Type of change

  • Bugfix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🔴 Total coverage has decreased 
// Code coverage diff between base branch:release and head branch: fix/issue-14019
Status File % Stmts % Branch % Funcs % Lines
🔴 total 56.71 (0) 38.66 (-0.01) 36.23 (0) 56.96 (0)
🔴 app/client/src/utils/autocomplete/TernServer.ts 52.71 (-0.23) 40.83 (-0.84) 36.21 (0) 56.74 (-0.25)

@techbhavin techbhavin added the App Viewers Pod This label assigns issues to the app viewers pod label May 26, 2022
@vercel
Copy link

vercel bot commented May 26, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Jun 1, 2022 at 8:19AM (UTC)

@github-actions github-actions bot added Bug Something isn't working Input Widget Low An issue that is neither critical nor breaks a user flow Papercut a trivially fixable usability bug Rich Text Editor Widget UI Building Pod labels May 26, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

1 similar comment
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@techbhavin
Copy link
Contributor Author

/ok-to-test sha=982c476

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2388476037.
Workflow: Appsmith External Integration Test Workflow.
Commit: 982c476.
PR: 14112.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2388476037.
Commit: 982c476.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 685.31 618.87 655.17 596.77 665.52 655.17 644.33 5.57 4.98
painting 4.13 6.2 5.85 3.5 4.04 4.13 4.74 25.32 22.57
rendering 332.16 274.78 299.23 281.17 305.54 299.23 298.58 7.58 6.78
BIND_TABLE_DATA
scripting 2305.79 2197.12 2294.87 2266.62 2300.19 2294.87 2272.92 1.98 1.77
painting 11.97 13.32 11.17 11.62 20.94 11.97 13.8 29.49 26.38
rendering 689.1 707.41 681.04 668.62 667.52 681.04 682.74 2.41 2.16
CLICK_ON_TABLE_ROW
scripting 1588.26 1423.01 1407.88 1688.78 1595.3 1588.26 1540.65 7.86 7.03
painting 17.22 16.23 12.28 11.53 12.5 12.5 13.95 18.49 16.56
rendering 295.72 269.79 271.05 285.46 269.93 271.05 278.39 4.21 3.77
UPDATE_POST_TITLE
scripting 2934.24 2391.83 2322.63 2305.96 2454.05 2391.83 2481.74 10.47 9.36
painting 16.11 38.5 13.53 12.86 28.09 16.11 21.82 51.19 45.78
rendering 424.22 350.74 351.25 363.5 367.15 363.5 371.37 8.19 7.33
OPEN_MODAL
scripting 1284.34 3047.15 1139.08 2556.57 1233.33 1284.34 1852.09 47.82 42.77
painting 15.41 13.9 20.26 16.28 14.76 15.41 16.12 15.32 13.71
rendering 491.04 434.04 412.89 457.01 440.78 440.78 447.15 6.53 5.84
CLOSE_MODAL
scripting 594.18 523.31 559.94 692.21 560.61 560.61 586.05 10.99 9.83
painting 5.1 4.35 4.69 6.7 5.03 5.03 5.17 17.41 15.67
rendering 359.18 332.03 345.57 398.07 338.17 345.57 354.6 7.42 6.64
SELECT_WIDGET_MENU_OPEN
scripting 1539.84 1536.82 1568.92 1424.76 1455.04 1536.82 1505.08 4.10 3.67
painting 10.35 11.63 7.76 22.75 6.53 10.35 11.8 54.58 48.81
rendering 542.7 566.94 545.35 523.62 499.65 542.7 535.65 4.73 4.23
SELECT_WIDGET_SELECT_OPTION
scripting 224.44 212.18 255.77 229.17 313.62 229.17 247.04 16.39 14.66
painting 5.34 5.47 4.02 3.57 2.42 4.02 4.16 30.77 27.40
rendering 15.27 18.85 17.12 15.12 13.92 15.27 16.06 12.08 10.77

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2388476037.
Commit: 982c476.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 685.31 618.87 655.17 596.77 665.52 655.17 644.33 5.57 4.98
painting 4.13 6.2 5.85 3.5 4.04 4.13 4.74 25.32 22.57
rendering 332.16 274.78 299.23 281.17 305.54 299.23 298.58 7.58 6.78
BIND_TABLE_DATA
scripting 2305.79 2197.12 2294.87 2266.62 2300.19 2294.87 2272.92 1.98 1.77
painting 11.97 13.32 11.17 11.62 20.94 11.97 13.8 29.49 26.38
rendering 689.1 707.41 681.04 668.62 667.52 681.04 682.74 2.41 2.16
CLICK_ON_TABLE_ROW
scripting 1588.26 1423.01 1407.88 1688.78 1595.3 1588.26 1540.65 7.86 7.03
painting 17.22 16.23 12.28 11.53 12.5 12.5 13.95 18.49 16.56
rendering 295.72 269.79 271.05 285.46 269.93 271.05 278.39 4.21 3.77
UPDATE_POST_TITLE
scripting 2934.24 2391.83 2322.63 2305.96 2454.05 2391.83 2481.74 10.47 9.36
painting 16.11 38.5 13.53 12.86 28.09 16.11 21.82 51.19 45.78
rendering 424.22 350.74 351.25 363.5 367.15 363.5 371.37 8.19 7.33
OPEN_MODAL
scripting 1284.34 3047.15 1139.08 2556.57 1233.33 1284.34 1852.09 47.82 42.77
painting 15.41 13.9 20.26 16.28 14.76 15.41 16.12 15.32 13.71
rendering 491.04 434.04 412.89 457.01 440.78 440.78 447.15 6.53 5.84
CLOSE_MODAL
scripting 594.18 523.31 559.94 692.21 560.61 560.61 586.05 10.99 9.83
painting 5.1 4.35 4.69 6.7 5.03 5.03 5.17 17.41 15.67
rendering 359.18 332.03 345.57 398.07 338.17 345.57 354.6 7.42 6.64
SELECT_WIDGET_MENU_OPEN
scripting 1539.84 1536.82 1568.92 1424.76 1455.04 1536.82 1505.08 4.10 3.67
painting 10.35 11.63 7.76 22.75 6.53 10.35 11.8 54.58 48.81
rendering 542.7 566.94 545.35 523.62 499.65 542.7 535.65 4.73 4.23
SELECT_WIDGET_SELECT_OPTION
scripting 224.44 212.18 255.77 229.17 313.62 229.17 247.04 16.39 14.66
painting 5.34 5.47 4.02 3.57 2.42 4.02 4.16 30.77 27.40
rendering 15.27 18.85 17.12 15.12 13.92 15.27 16.06 12.08 10.77

Tooluloope
Tooluloope suggested changes May 26, 2022
View reviewed changes
app/client/src/widgets/RichTextEditorWidget/component/index.tsx
display: flex;
width: 100%;
min-width: 0;
height: 100%;
border: 1px solid ${(props) => (props.isValid ? "none" : Colors.DANGER_SOLID)};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a cypress test for this, so it doesn't reoccur

@techbhavin
Copy link
Contributor Author

/ok-to-test sha=464abcf

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2401234914.
Workflow: Appsmith External Integration Test Workflow.
Commit: 464abcf.
PR: 14112.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2401234914.
Commit: 464abcf.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 2752.77 1154.93 1079.64 1093.72 1126.35 1126.35 1441.48 50.89 45.52
painting 24.72 13.38 21.1 8.95 7.84 13.38 15.2 49.01 43.82
rendering 433.97 452.24 466.09 436.73 427.03 436.73 443.21 3.56 3.18
BIND_TABLE_DATA
scripting 2079.28 2227.37 2061.84 2272.37 2296.85 2227.37 2187.54 5.02 4.49
painting 16.86 40.7 34.12 31.78 18.31 31.78 28.35 36.58 32.73
rendering 1154.92 1099.83 1306.83 954.79 936.92 1099.83 1090.66 13.98 12.51
CLICK_ON_TABLE_ROW
scripting 4322.63 4646.73 4384.19 4414.02 4030.53 4384.19 4359.62 5.07 4.54
painting 76.75 44.94 71.01 54.52 41.95 54.52 57.83 26.80 23.97
rendering 1185.1 1254.68 1509.33 1489.44 1439.96 1439.96 1375.7 10.65 9.53
UPDATE_POST_TITLE
scripting 4647.66 5150.98 4474.42 5789.21 5769 5150.98 5166.25 11.85 10.60
painting 37.66 33.8 37.98 49.38 39.88 37.98 39.74 14.65 13.11
rendering 653.13 593.32 585.39 612.14 606.73 606.73 610.14 4.30 3.85
OPEN_MODAL
scripting 2096.95 1996.13 2080.16 3903.24 2135.56 2096.95 2442.41 33.50 29.96
painting 27.98 36.48 41.6 39.24 23.56 36.48 33.77 22.77 20.37
rendering 670.18 663.51 684.63 670.65 664.14 670.18 670.62 1.27 1.13
CLOSE_MODAL
scripting 1138.28 3609.23 3612.15 1086.75 1403.34 1403.34 2169.95 60.86 54.44
painting 14.77 9.86 10.99 21.13 25.19 14.77 16.39 40.27 36.00
rendering 606 626.82 628.91 552.94 672.34 626.82 617.4 7.02 6.28
SELECT_WIDGET_MENU_OPEN
scripting 2218 2124.89 2082.71 2108.56 1966.45 2108.56 2100.12 4.31 3.85
painting 20.56 17.42 38.36 31.77 19.3 20.56 25.48 35.79 32.03
rendering 780.78 789.82 792.37 803.05 737.17 789.82 780.64 3.27 2.93
SELECT_WIDGET_SELECT_OPTION
scripting 348.44 387.99 319.04 345.22 474.56 348.44 375.05 16.22 14.51
painting 5.4 4.73 8.94 4.91 5.16 5.16 5.83 30.19 26.93
rendering 22.54 22.33 21.82 21.76 22.65 22.33 22.22 1.85 1.67

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2401234914.
Commit: 464abcf.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 2752.77 1154.93 1079.64 1093.72 1126.35 1126.35 1441.48 50.89 45.52
painting 24.72 13.38 21.1 8.95 7.84 13.38 15.2 49.01 43.82
rendering 433.97 452.24 466.09 436.73 427.03 436.73 443.21 3.56 3.18
BIND_TABLE_DATA
scripting 2079.28 2227.37 2061.84 2272.37 2296.85 2227.37 2187.54 5.02 4.49
painting 16.86 40.7 34.12 31.78 18.31 31.78 28.35 36.58 32.73
rendering 1154.92 1099.83 1306.83 954.79 936.92 1099.83 1090.66 13.98 12.51
CLICK_ON_TABLE_ROW
scripting 4322.63 4646.73 4384.19 4414.02 4030.53 4384.19 4359.62 5.07 4.54
painting 76.75 44.94 71.01 54.52 41.95 54.52 57.83 26.80 23.97
rendering 1185.1 1254.68 1509.33 1489.44 1439.96 1439.96 1375.7 10.65 9.53
UPDATE_POST_TITLE
scripting 4647.66 5150.98 4474.42 5789.21 5769 5150.98 5166.25 11.85 10.60
painting 37.66 33.8 37.98 49.38 39.88 37.98 39.74 14.65 13.11
rendering 653.13 593.32 585.39 612.14 606.73 606.73 610.14 4.30 3.85
OPEN_MODAL
scripting 2096.95 1996.13 2080.16 3903.24 2135.56 2096.95 2442.41 33.50 29.96
painting 27.98 36.48 41.6 39.24 23.56 36.48 33.77 22.77 20.37
rendering 670.18 663.51 684.63 670.65 664.14 670.18 670.62 1.27 1.13
CLOSE_MODAL
scripting 1138.28 3609.23 3612.15 1086.75 1403.34 1403.34 2169.95 60.86 54.44
painting 14.77 9.86 10.99 21.13 25.19 14.77 16.39 40.27 36.00
rendering 606 626.82 628.91 552.94 672.34 626.82 617.4 7.02 6.28
SELECT_WIDGET_MENU_OPEN
scripting 2218 2124.89 2082.71 2108.56 1966.45 2108.56 2100.12 4.31 3.85
painting 20.56 17.42 38.36 31.77 19.3 20.56 25.48 35.79 32.03
rendering 780.78 789.82 792.37 803.05 737.17 789.82 780.64 3.27 2.93
SELECT_WIDGET_SELECT_OPTION
scripting 348.44 387.99 319.04 345.22 474.56 348.44 375.05 16.22 14.51
painting 5.4 4.73 8.94 4.91 5.16 5.16 5.83 30.19 26.93
rendering 22.54 22.33 21.82 21.76 22.65 22.33 22.22 1.85 1.67

@techbhavin
Copy link
Contributor Author

/ok-to-test sha=464abcf

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2406668725.
Workflow: Appsmith External Integration Test Workflow.
Commit: 464abcf.
PR: 14112.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2406668725.
Commit: 464abcf.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1832.18 1912.83 1955.97 1876.11 1715.49 1876.11 1858.52 4.95 4.43
painting 13.82 15.14 16.08 37.99 13.16 15.14 19.24 54.78 49.01
rendering 639.87 727.78 794.27 785.45 684.1 727.78 726.29 9.07 8.12
SELECT_WIDGET_SELECT_OPTION
scripting 346.62 266.2 383.31 331.28 314.91 331.28 328.46 13.10 11.72
painting 7.11 4.12 10.45 5.14 4.92 5.14 6.35 40.00 35.75
rendering 23.87 22.91 23.82 20.12 24.9 23.82 23.12 7.87 7.05

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2406668725.
Commit: 464abcf.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1832.18 1912.83 1955.97 1876.11 1715.49 1876.11 1858.52 4.95 4.43
painting 13.82 15.14 16.08 37.99 13.16 15.14 19.24 54.78 49.01
rendering 639.87 727.78 794.27 785.45 684.1 727.78 726.29 9.07 8.12
SELECT_WIDGET_SELECT_OPTION
scripting 346.62 266.2 383.31 331.28 314.91 331.28 328.46 13.10 11.72
painting 7.11 4.12 10.45 5.14 4.92 5.14 6.35 40.00 35.75
rendering 23.87 22.91 23.82 20.12 24.9 23.82 23.12 7.87 7.05

@techbhavin
Copy link
Contributor Author

/ok-to-test sha=e76b30c

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2407629515.
Workflow: Appsmith External Integration Test Workflow.
Commit: e76b30c.
PR: 14112.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2407629515.
Commit: e76b30c.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 513.8 559.27 1744.38 542.84 581.62 559.27 788.38 67.86 60.70
painting 3.61 5 16.69 3.92 4.07 4.07 6.66 84.53 75.68
rendering 256.09 259.07 256.01 267.69 267.35 259.07 261.24 2.24 2.01
BIND_TABLE_DATA
scripting 2233.08 2229.61 2317.61 2237.16 2252.08 2237.16 2253.91 1.63 1.45
painting 13.65 16.38 13.03 15.38 12.47 13.65 14.18 11.57 10.37
rendering 589.35 622.36 583.41 598.8 558.37 589.35 590.46 3.94 3.53
CLICK_ON_TABLE_ROW
scripting 1354.81 1394.34 1705.91 1247.26 1232.69 1354.81 1387 13.78 12.33
painting 18.74 10.65 9.98 14.35 13.2 13.2 13.38 26.08 23.32
rendering 267.66 240.8 250.26 253.66 246.48 250.26 251.77 4.00 3.58
UPDATE_POST_TITLE
scripting 2109.37 1937.07 1917.85 2138.33 1964.66 1964.66 2013.46 5.10 4.56
painting 14.51 16.25 11.43 18.81 13.49 14.51 14.9 18.79 16.78
rendering 336.54 311.38 322.05 322.07 335.63 322.07 325.53 3.25 2.91
OPEN_MODAL
scripting 870.78 861.17 883.82 995.57 993.69 883.82 921.01 7.35 6.57
painting 10.68 12.88 9.54 11.97 11.36 11.36 11.29 11.25 10.01
rendering 364.67 369.91 374.15 362.29 385.89 369.91 371.38 2.51 2.25
CLOSE_MODAL
scripting 608.79 616.09 555.95 513.35 487.03 555.95 556.24 10.24 9.16
painting 4.03 4.1 14.43 6.02 9.19 6.02 7.55 58.01 51.92
rendering 322.26 318.26 312.47 300.05 325.66 318.26 315.74 3.18 2.85
SELECT_WIDGET_MENU_OPEN
scripting 1352.53 1398.37 1317.85 1311.51 1357.54 1352.53 1347.56 2.59 2.32
painting 6.06 12.31 7.64 6.35 6.66 6.66 7.8 33.21 29.62
rendering 445.1 430.66 414.19 426.69 415.13 426.69 426.35 2.98 2.66
SELECT_WIDGET_SELECT_OPTION
scripting 206.13 241.44 222.16 141.53 187.91 206.13 199.83 19.07 17.06
painting 6.94 3.28 1.93 3.45 3.18 3.28 3.76 50.00 44.68
rendering 12.89 12.26 12.36 11.58 11.62 12.26 12.14 4.53 4.04

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2407629515.
Commit: e76b30c.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 513.8 559.27 1744.38 542.84 581.62 559.27 788.38 67.86 60.70
painting 3.61 5 16.69 3.92 4.07 4.07 6.66 84.53 75.68
rendering 256.09 259.07 256.01 267.69 267.35 259.07 261.24 2.24 2.01
BIND_TABLE_DATA
scripting 2233.08 2229.61 2317.61 2237.16 2252.08 2237.16 2253.91 1.63 1.45
painting 13.65 16.38 13.03 15.38 12.47 13.65 14.18 11.57 10.37
rendering 589.35 622.36 583.41 598.8 558.37 589.35 590.46 3.94 3.53
CLICK_ON_TABLE_ROW
scripting 1354.81 1394.34 1705.91 1247.26 1232.69 1354.81 1387 13.78 12.33
painting 18.74 10.65 9.98 14.35 13.2 13.2 13.38 26.08 23.32
rendering 267.66 240.8 250.26 253.66 246.48 250.26 251.77 4.00 3.58
UPDATE_POST_TITLE
scripting 2109.37 1937.07 1917.85 2138.33 1964.66 1964.66 2013.46 5.10 4.56
painting 14.51 16.25 11.43 18.81 13.49 14.51 14.9 18.79 16.78
rendering 336.54 311.38 322.05 322.07 335.63 322.07 325.53 3.25 2.91
OPEN_MODAL
scripting 870.78 861.17 883.82 995.57 993.69 883.82 921.01 7.35 6.57
painting 10.68 12.88 9.54 11.97 11.36 11.36 11.29 11.25 10.01
rendering 364.67 369.91 374.15 362.29 385.89 369.91 371.38 2.51 2.25
CLOSE_MODAL
scripting 608.79 616.09 555.95 513.35 487.03 555.95 556.24 10.24 9.16
painting 4.03 4.1 14.43 6.02 9.19 6.02 7.55 58.01 51.92
rendering 322.26 318.26 312.47 300.05 325.66 318.26 315.74 3.18 2.85
SELECT_WIDGET_MENU_OPEN
scripting 1352.53 1398.37 1317.85 1311.51 1357.54 1352.53 1347.56 2.59 2.32
painting 6.06 12.31 7.64 6.35 6.66 6.66 7.8 33.21 29.62
rendering 445.1 430.66 414.19 426.69 415.13 426.69 426.35 2.98 2.66
SELECT_WIDGET_SELECT_OPTION
scripting 206.13 241.44 222.16 141.53 187.91 206.13 199.83 19.07 17.06
painting 6.94 3.28 1.93 3.45 3.18 3.28 3.76 50.00 44.68
rendering 12.89 12.26 12.36 11.58 11.62 12.26 12.14 4.53 4.04

Tooluloope
Tooluloope previously approved these changes May 30, 2022
View reviewed changes
@shadabbuchh
Copy link

shadabbuchh commented May 31, 2022 •
edited

This issue if fixed. The error (red) highlight now appears only on the input component of the RTE widget.
Screenshot 2022-05-31 at 9.49.27 AM.pngScreenshot 2022-05-31 at 9.50.14 AM.png

However @Tooluloope / @techbhavin I notice that the error highlight does not adjust with the changing Border Radius. Is this something that is expected?
Screenshot 2022-05-31 at 9.56.07 AM.png

@Tooluloope
Copy link
Contributor

@techbhavin Could you look into the border-radius issue

cc @shadabbuchh

@techbhavin
Copy link
Contributor Author

/ok-to-test sha=af374f6

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2416654624.
Workflow: Appsmith External Integration Test Workflow.
Commit: af374f6.
PR: 14112.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2416654624.
Commit: af374f6.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 1193.2 3333.89 1341.17 1276.83 1236.44 1276.83 1676.31 55.37 49.53
painting 10.73 8.18 19.47 11.9 18.83 11.9 13.82 36.54 32.71
rendering 489.39 498.67 486.22 507.29 477.3 489.39 491.77 2.35 2.10
BIND_TABLE_DATA
scripting 2311.42 2232.41 2224.76 2298.77 3165.22 2298.77 2446.52 16.50 14.76
painting 49.88 73.41 31.67 34.18 56.51 49.88 49.13 34.85 31.18
rendering 1151.98 1198.78 1181.82 1000.16 1547.2 1181.82 1215.99 16.54 14.80
CLICK_ON_TABLE_ROW
scripting 4917.55 5190.74 5009.1 5380.73 4425.42 5009.1 4984.71 7.21 6.45
painting 93.94 59.68 78.09 64.97 64.94 64.97 72.32 19.18 17.15
rendering 1562.57 1789.62 1548.56 1855.1 1884.89 1789.62 1728.15 9.34 8.35
UPDATE_POST_TITLE
scripting 5746.76 5908.15 5302.12 5436.84 5670.05 5670.05 5612.78 4.33 3.87
painting 57.17 36.85 61.59 41.5 31.71 41.5 45.76 28.41 25.42
rendering 734.46 708.8 668.78 637.72 666.49 668.78 683.25 5.59 5.00
OPEN_MODAL
scripting 2433.17 2400.88 2564.7 2426.31 2336.07 2426.31 2432.23 3.43 3.07
painting 32.33 48.48 21.9 39.33 21.07 32.33 32.62 35.78 32.00
rendering 772.58 730.31 769 741.21 748.9 748.9 752.4 2.40 2.15
CLOSE_MODAL
scripting 1200.89 1221.3 1429.66 4406.94 1385.97 1385.97 1928.95 72.00 64.40
painting 11.49 11.32 10.56 21.15 17.65 11.49 14.43 32.64 29.18
rendering 624.75 675.32 668.36 635.15 893.07 668.36 699.33 15.79 14.12
SELECT_WIDGET_MENU_OPEN
scripting 2355.08 2342.18 2328.54 2287.92 2281.33 2328.54 2319.01 1.42 1.27
painting 22.33 27.17 12.6 28.44 23.78 23.78 22.86 27.34 24.45
rendering 839.62 861.09 866.35 838.18 830.74 839.62 847.2 1.84 1.64
SELECT_WIDGET_SELECT_OPTION
scripting 378.07 383.47 398.86 378.95 387.97 383.47 385.46 2.20 1.96
painting 7.05 6 13.71 4.87 3.98 6 7.12 54.21 48.46
rendering 25.02 23.03 23.05 23.33 20.8 23.05 23.05 6.51 5.81

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2416654624.
Commit: af374f6.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 1193.2 3333.89 1341.17 1276.83 1236.44 1276.83 1676.31 55.37 49.53
painting 10.73 8.18 19.47 11.9 18.83 11.9 13.82 36.54 32.71
rendering 489.39 498.67 486.22 507.29 477.3 489.39 491.77 2.35 2.10
BIND_TABLE_DATA
scripting 2311.42 2232.41 2224.76 2298.77 3165.22 2298.77 2446.52 16.50 14.76
painting 49.88 73.41 31.67 34.18 56.51 49.88 49.13 34.85 31.18
rendering 1151.98 1198.78 1181.82 1000.16 1547.2 1181.82 1215.99 16.54 14.80
CLICK_ON_TABLE_ROW
scripting 4917.55 5190.74 5009.1 5380.73 4425.42 5009.1 4984.71 7.21 6.45
painting 93.94 59.68 78.09 64.97 64.94 64.97 72.32 19.18 17.15
rendering 1562.57 1789.62 1548.56 1855.1 1884.89 1789.62 1728.15 9.34 8.35
UPDATE_POST_TITLE
scripting 5746.76 5908.15 5302.12 5436.84 5670.05 5670.05 5612.78 4.33 3.87
painting 57.17 36.85 61.59 41.5 31.71 41.5 45.76 28.41 25.42
rendering 734.46 708.8 668.78 637.72 666.49 668.78 683.25 5.59 5.00
OPEN_MODAL
scripting 2433.17 2400.88 2564.7 2426.31 2336.07 2426.31 2432.23 3.43 3.07
painting 32.33 48.48 21.9 39.33 21.07 32.33 32.62 35.78 32.00
rendering 772.58 730.31 769 741.21 748.9 748.9 752.4 2.40 2.15
CLOSE_MODAL
scripting 1200.89 1221.3 1429.66 4406.94 1385.97 1385.97 1928.95 72.00 64.40
painting 11.49 11.32 10.56 21.15 17.65 11.49 14.43 32.64 29.18
rendering 624.75 675.32 668.36 635.15 893.07 668.36 699.33 15.79 14.12
SELECT_WIDGET_MENU_OPEN
scripting 2355.08 2342.18 2328.54 2287.92 2281.33 2328.54 2319.01 1.42 1.27
painting 22.33 27.17 12.6 28.44 23.78 23.78 22.86 27.34 24.45
rendering 839.62 861.09 866.35 838.18 830.74 839.62 847.2 1.84 1.64
SELECT_WIDGET_SELECT_OPTION
scripting 378.07 383.47 398.86 378.95 387.97 383.47 385.46 2.20 1.96
painting 7.05 6 13.71 4.87 3.98 6 7.12 54.21 48.46
rendering 25.02 23.03 23.05 23.33 20.8 23.05 23.05 6.51 5.81

@techbhavin
Copy link
Contributor Author

/ok-to-test sha=af374f6

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2419231798.
Workflow: Appsmith External Integration Test Workflow.
Commit: af374f6.
PR: 14112.

@shadabbuchh
Copy link

The issue is fixed. Moving it to Done.

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2419231798.
Commit: af374f6.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1954.73 1963.01 2065.49 1963.86 1954.72 1963.01 1980.36 2.41 2.16
painting 14.94 16.86 29.21 19.56 22.81 19.56 20.68 27.13 24.27
rendering 669.84 688.05 711.51 725.31 676.97 688.05 694.34 3.37 3.02
SELECT_WIDGET_SELECT_OPTION
scripting 307.69 388.69 313.63 460.73 387.5 387.5 371.65 16.98 15.19
painting 5.64 5.39 10.53 9.78 4.4 5.64 7.15 39.16 34.97
rendering 22.54 28.07 19.71 22.35 31.89 22.54 24.91 19.87 17.78

1 similar comment
@github-actions
Copy link

github-actions bot commented Jun 1, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2419231798.
Commit: af374f6.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1954.73 1963.01 2065.49 1963.86 1954.72 1963.01 1980.36 2.41 2.16
painting 14.94 16.86 29.21 19.56 22.81 19.56 20.68 27.13 24.27
rendering 669.84 688.05 711.51 725.31 676.97 688.05 694.34 3.37 3.02
SELECT_WIDGET_SELECT_OPTION
scripting 307.69 388.69 313.63 460.73 387.5 387.5 371.65 16.98 15.19
painting 5.64 5.39 10.53 9.78 4.4 5.64 7.15 39.16 34.97
rendering 22.54 28.07 19.71 22.35 31.89 22.54 24.91 19.87 17.78

@techbhavin
Copy link
Contributor Author

/ok-to-test sha=6114139

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2420179809.
Workflow: Appsmith External Integration Test Workflow.
Commit: 6114139.
PR: 14112.

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2420179809.
Commit: 6114139.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 679.81 883.62 618.69 592.66 687.5 679.81 692.46 16.49 14.75
painting 5.16 7.15 4.79 4.74 5.79 5.16 5.53 18.08 16.09
rendering 312.29 345.82 278.32 274.32 293 293 300.75 9.73 8.70
BIND_TABLE_DATA
scripting 2229 2371.77 2282.58 2275.83 2320.86 2282.58 2296.01 2.33 2.08
painting 23.98 18.65 17.23 13.12 14.57 17.23 17.51 24.10 21.53
rendering 819.15 828.59 695.81 687.02 692.83 695.81 744.68 9.73 8.70
CLICK_ON_TABLE_ROW
scripting 1931.79 1912.04 1676.3 1581.67 1797.23 1797.23 1779.81 8.47 7.57
painting 26.67 24.33 16.77 15.89 11.31 16.77 18.99 33.39 29.86
rendering 317.51 350.33 314.84 273.2 284.22 314.84 308.02 9.88 8.84
UPDATE_POST_TITLE
scripting 3208.19 3158.08 2571.29 2485.74 2615.3 2615.3 2807.72 12.33 11.03
painting 22.24 22.43 18.73 11.81 28.55 22.24 20.75 29.49 26.41
rendering 512.9 410.32 370.22 363.97 376.66 376.66 406.81 15.23 13.62
OPEN_MODAL
scripting 1173.96 2049.22 1172.51 1127.29 1206.56 1173.96 1345.91 29.29 26.19
painting 16.35 20.6 11.32 12.55 16.33 16.33 15.43 23.72 21.19
rendering 465.68 678.51 432.17 428.66 459.06 459.06 492.82 21.32 19.07
CLOSE_MODAL
scripting 781.07 2897.85 632.76 631.4 633.43 633.43 1115.3 89.53 80.08
painting 5.85 9.18 5.29 7.08 4.47 5.85 6.37 28.73 25.75
rendering 429.13 626.43 364.54 367.73 349.33 367.73 427.43 26.99 24.14
SELECT_WIDGET_MENU_OPEN
scripting 1505.75 1652.08 1453.21 1509.42 2084.7 1509.42 1641.03 15.77 14.10
painting 11.03 14.75 8.53 10.69 13.45 11.03 11.69 20.87 18.73
rendering 556.65 690.76 533.22 520.75 635.81 556.65 587.44 12.44 11.12
SELECT_WIDGET_SELECT_OPTION
scripting 359.49 263.83 268.65 244.36 397.62 268.65 306.79 22.00 19.68
painting 6.42 4.57 6.53 3.6 4.15 4.57 5.05 26.53 23.76
rendering 13.77 17.56 14.62 16.38 23.89 16.38 17.24 23.20 20.77

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2420179809.
Commit: 6114139.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 1065.63 1102.83 2721.5 2388.41 1078.09 1102.83 1671.29 48.78 43.63
painting 8.09 14.67 8.23 7.18 9.86 8.23 9.61 31.11 27.89
rendering 430.36 424.39 421.82 426.63 426.35 426.35 425.91 0.74 0.66
BIND_TABLE_DATA
scripting 2558.93 2561.73 2277.01 2706.23 2158.29 2558.93 2452.44 9.23 8.26
painting 31.82 31.53 22.53 41.05 33.78 31.82 32.14 20.57 18.39
rendering 1147.33 1112.25 1041.71 1172.04 1145.58 1145.58 1123.78 4.50 4.02
CLICK_ON_TABLE_ROW
scripting 4552.13 4406.28 4674.86 4392.51 4388.77 4406.28 4482.91 2.83 2.53
painting 78.27 65.85 66.7 80.8 42.99 66.7 66.92 22.36 19.99
rendering 1329.4 1093.26 1439.5 1849.76 1260.46 1329.4 1394.48 20.35 18.20
UPDATE_POST_TITLE
scripting 4545.39 5179.38 4503.25 5522.35 5108.65 5108.65 4971.8 8.80 7.87
painting 46.45 49.97 30.59 35.18 25.35 35.18 37.51 27.83 24.90
rendering 618.96 630.72 582.65 567.31 614.41 614.41 602.81 4.42 3.95
OPEN_MODAL
scripting 2177.98 2558.03 4541.18 2091.81 4183.61 2558.03 3110.52 37.39 33.44
painting 26.29 20.35 32.31 17.61 44.26 26.29 28.16 37.75 33.77
rendering 688.76 686.13 667.41 662.13 656.33 667.41 672.15 2.16 1.93
CLOSE_MODAL
scripting 3433.65 2714.66 1150.66 1075.65 1224.6 1224.6 1919.84 56.53 50.56
painting 11.2 21.74 8.77 8 8.23 8.77 11.59 50.22 44.87
rendering 613.81 556.46 540.57 553.14 750.22 556.46 602.84 14.45 12.92
SELECT_WIDGET_MENU_OPEN
scripting 2147.8 2254.84 2184.77 1947.92 2014.75 2147.8 2110.02 5.96 5.33
painting 17.04 14.47 23.94 18.19 18.97 18.19 18.52 18.74 16.79
rendering 784.77 774.36 848.39 713.57 709.53 774.36 766.12 7.48 6.69
SELECT_WIDGET_SELECT_OPTION
scripting 341.32 365.45 357.35 468.59 362.87 362.87 379.12 13.42 12.01
painting 4.36 18.9 5.65 4.02 14.93 5.65 9.57 71.89 64.26
rendering 22.63 22.01 21.63 21.92 25.04 22.01 22.65 6.14 5.47

@mohanarpit mohanarpit merged commit 1a3eafb into release Jun 1, 2022
@mohanarpit mohanarpit deleted the fix/issue-14019 branch June 1, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tooluloope Tooluloope Awaiting requested review from Tooluloope

Assignees
No one assigned
Labels
App Viewers Pod This label assigns issues to the app viewers pod Bug Something isn't working Input Widget Low An issue that is neither critical nor breaks a user flow Papercut a trivially fixable usability bug Rich Text Editor Widget
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]-[62]:RTE error highlight includes the label element
4 participants
@techbhavin @shadabbuchh @Tooluloope @mohanarpit