Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Close insert modal for MongoDB and Google sheet after InsertQuery is executed for generated CRUD pages #14115

Merged
merged 1 commit into from
May 26, 2022
Merged

fix: Close insert modal for MongoDB and Google sheet after InsertQuery is executed for generated CRUD pages #14115

merged 1 commit into from
May 26, 2022

Conversation

abhvsn
Copy link
Contributor

@abhvsn abhvsn commented May 26, 2022

Description

Fixes close insert modal for MongoDB and Google sheet generated pages

@abhvsn abhvsn requested a review from Aishwarya-U-R May 26, 2022 08:01
@abhvsn
Copy link
Contributor Author

abhvsn commented May 26, 2022

/ok-to-test sha=efc86e4

@abhvsn abhvsn changed the title fix: Fixes close insert modal for MongoDB and Google sheet generated pages fix: Close insert modal for MongoDB and Google sheet after InsertQuery is executed for generated CRUD pages May 26, 2022
@github-actions github-actions bot added the Bug Something isn't working label May 26, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2389455417.
Workflow: Appsmith External Integration Test Workflow.
Commit: efc86e4.
PR: 14115.

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@vercel
Copy link

vercel bot commented May 26, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview May 26, 2022 at 8:18AM (UTC)

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2389455417.
Commit: efc86e4.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 654.12 944.64 952.78 647.57 740.61 740.61 787.94 19.20 17.18
painting 5.62 17.94 7.59 4.01 4.53 5.62 7.94 72.54 64.86
rendering 268.12 433.43 436.3 291.74 338.4 338.4 353.6 22.17 19.83
BIND_TABLE_DATA
scripting 2238.5 2212.67 2603.45 2307.33 2207.15 2238.5 2313.82 7.21 6.45
painting 10.2 19.83 20.87 14.11 16.66 16.66 16.33 26.58 23.82
rendering 651.76 1175.94 721.09 673.69 913.98 721.09 827.29 26.67 23.86
CLICK_ON_TABLE_ROW
scripting 1380.09 3352.04 1815.11 1602.92 2456.14 1815.11 2121.26 37.56 33.59
painting 15.24 31.16 16.94 24.19 41.17 24.19 25.74 41.57 37.18
rendering 256.49 1200.82 312.34 270.57 462.95 312.34 500.63 79.88 71.45
UPDATE_POST_TITLE
scripting 2658.98 3720.74 2449.58 3197.7 4228.6 3197.7 3251.12 22.67 20.27
painting 20.56 23.62 25.67 25.27 21.23 23.62 23.27 9.93 8.90
rendering 366.88 575.37 386.83 359.49 516.43 386.83 441 22.34 19.98
OPEN_MODAL
scripting 1248.88 1155.95 2534.75 1303.2 1613.73 1303.2 1571.3 35.98 32.18
painting 19.64 11.32 14.89 10.63 16.42 14.89 14.58 25.51 22.84
rendering 421.11 454.82 442.36 486.27 641.34 454.82 489.18 18.04 16.14
CLOSE_MODAL
scripting 636.88 2275.16 583.67 664.51 1072.59 664.51 1046.56 68.21 61.01
painting 9.58 5.89 5.79 6.46 12.62 6.46 8.07 36.93 33.09
rendering 370.09 453.88 346.52 410.12 617.76 410.12 439.67 24.47 21.89
SELECT_WIDGET_MENU_OPEN
scripting 1614.26 1489.78 1568.95 1567.76 1669.68 1568.95 1582.09 4.19 3.75
painting 7.71 9.38 21.84 12.16 12.8 12.16 12.78 42.80 38.26
rendering 566.93 549.28 553.05 604.21 624 566.93 579.49 5.70 5.10
SELECT_WIDGET_SELECT_OPTION
scripting 274.76 263.68 303.86 285.87 339.49 285.87 293.53 10.11 9.04
painting 3.85 3.61 7.62 7.1 7.72 7.1 5.98 34.62 30.94
rendering 21.85 17.66 24.94 19.71 23.79 21.85 21.59 13.71 12.27

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2389455417.
Commit: efc86e4.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 654.12 944.64 952.78 647.57 740.61 740.61 787.94 19.20 17.18
painting 5.62 17.94 7.59 4.01 4.53 5.62 7.94 72.54 64.86
rendering 268.12 433.43 436.3 291.74 338.4 338.4 353.6 22.17 19.83
BIND_TABLE_DATA
scripting 2238.5 2212.67 2603.45 2307.33 2207.15 2238.5 2313.82 7.21 6.45
painting 10.2 19.83 20.87 14.11 16.66 16.66 16.33 26.58 23.82
rendering 651.76 1175.94 721.09 673.69 913.98 721.09 827.29 26.67 23.86
CLICK_ON_TABLE_ROW
scripting 1380.09 3352.04 1815.11 1602.92 2456.14 1815.11 2121.26 37.56 33.59
painting 15.24 31.16 16.94 24.19 41.17 24.19 25.74 41.57 37.18
rendering 256.49 1200.82 312.34 270.57 462.95 312.34 500.63 79.88 71.45
UPDATE_POST_TITLE
scripting 2658.98 3720.74 2449.58 3197.7 4228.6 3197.7 3251.12 22.67 20.27
painting 20.56 23.62 25.67 25.27 21.23 23.62 23.27 9.93 8.90
rendering 366.88 575.37 386.83 359.49 516.43 386.83 441 22.34 19.98
OPEN_MODAL
scripting 1248.88 1155.95 2534.75 1303.2 1613.73 1303.2 1571.3 35.98 32.18
painting 19.64 11.32 14.89 10.63 16.42 14.89 14.58 25.51 22.84
rendering 421.11 454.82 442.36 486.27 641.34 454.82 489.18 18.04 16.14
CLOSE_MODAL
scripting 636.88 2275.16 583.67 664.51 1072.59 664.51 1046.56 68.21 61.01
painting 9.58 5.89 5.79 6.46 12.62 6.46 8.07 36.93 33.09
rendering 370.09 453.88 346.52 410.12 617.76 410.12 439.67 24.47 21.89
SELECT_WIDGET_MENU_OPEN
scripting 1614.26 1489.78 1568.95 1567.76 1669.68 1568.95 1582.09 4.19 3.75
painting 7.71 9.38 21.84 12.16 12.8 12.16 12.78 42.80 38.26
rendering 566.93 549.28 553.05 604.21 624 566.93 579.49 5.70 5.10
SELECT_WIDGET_SELECT_OPTION
scripting 274.76 263.68 303.86 285.87 339.49 285.87 293.53 10.11 9.04
painting 3.85 3.61 7.62 7.1 7.72 7.1 5.98 34.62 30.94
rendering 21.85 17.66 24.94 19.71 23.79 21.85 21.59 13.71 12.27

@abhvsn abhvsn self-assigned this May 26, 2022
@abhvsn abhvsn added the Team Managers Pod Issues that team managers care about for the security and efficiency of their teams label May 26, 2022
@abhvsn abhvsn merged commit 6c1e5ec into release May 26, 2022
@abhvsn abhvsn deleted the update-crud-template branch May 26, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aishwarya-U-R Aishwarya-U-R Aishwarya-U-R approved these changes

Assignees

@abhvsn abhvsn

Labels
Bug Something isn't working Team Managers Pod Issues that team managers care about for the security and efficiency of their teams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@abhvsn @Aishwarya-U-R @Nikhil-Nandagopal