Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upgrade Lombok package version to 1.18.22 to avoid build error #14080 #14156

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

subrata71
Copy link
Contributor

@subrata71 subrata71 commented May 30, 2022

Description

Seeing this error due to old lombok package version. We have updated the version in most of the pom files in an earlier release but few pom files still use the old version.
Ref: https://theappsmith.slack.com/archives/CPQNLFHTN/p1653413674448529

Fixes #14080

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manually running mvn clean compile results in build success

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@subrata71 subrata71 requested a review from sumitsum May 30, 2022 05:35
@welcome
Copy link

welcome bot commented May 30, 2022

Welcome to the Appsmith community! Thank you for your first pull request and making this project better. 🤗

@vercel
Copy link

vercel bot commented May 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview May 30, 2022 at 5:35AM (UTC)

@subrata71
Copy link
Contributor Author

/ok-to-test sha=6d0e804

@github-actions github-actions bot added Actions Pod Backend This marks the issue or pull request to reference server code BE Coders Pod Issues related to users writing code to fetch and update data Bug Something isn't working Good First Issue Good for newcomers High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage labels May 30, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2407079825.
Workflow: Appsmith External Integration Test Workflow.
Commit: 6d0e804.
PR: 14156.

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2407079825.
Commit: 6d0e804.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 655.08 797.74 738.53 876.86 2149.62 797.74 1043.57 59.76 53.45
painting 5.85 6.65 6.78 6.44 6.22 6.44 6.39 5.79 5.16
rendering 280.03 334.79 312.43 363.8 363.93 334.79 331 10.81 9.66
BIND_TABLE_DATA
scripting 2356.26 2272.26 2354.24 2249.12 2380.66 2354.24 2322.51 2.50 2.23
painting 27.13 14.63 21.64 18.72 17.62 18.72 19.95 23.71 21.20
rendering 1003.3 729.71 737.18 690.68 755.78 737.18 783.33 15.99 14.30
CLICK_ON_TABLE_ROW
scripting 1818.08 1588.72 2067.86 2145.34 1778.43 1818.08 1879.69 12.03 10.76
painting 13.6 13.04 15.73 21.91 16.03 15.73 16.06 21.92 19.61
rendering 346.1 298.82 397.2 339.19 316.87 339.19 339.64 10.96 9.80
UPDATE_POST_TITLE
scripting 2891.89 2536.4 3244.92 3090.94 3106.23 3090.94 2974.08 9.25 8.27
painting 18.57 18.34 29.5 36.88 34.03 29.5 27.46 31.46 28.11
rendering 392.1 385.49 432.87 419.09 508.35 419.09 427.58 11.49 10.28
OPEN_MODAL
scripting 1447.22 2801.37 3177.59 1178.33 1376.37 1447.22 1996.18 46.18 41.30
painting 13.45 12.58 24.84 20.07 12.27 13.45 16.64 33.53 30.05
rendering 555.18 486.68 505.83 429.96 504.69 504.69 496.47 9.08 8.12
CLOSE_MODAL
scripting 714.92 605.21 2390.11 833.31 778.03 778.03 1064.32 70.09 62.69
painting 14.29 4.65 6.68 5.93 7.26 6.68 7.76 48.71 43.56
rendering 381.75 354.02 419.66 428.14 414.84 414.84 399.68 7.76 6.94
SELECT_WIDGET_MENU_OPEN
scripting 1867.95 1540.49 1659.49 1682.26 1605.26 1659.49 1671.09 7.35 6.58
painting 10.61 11.71 12.45 12.49 10.98 11.71 11.65 7.30 6.52
rendering 645 574.7 610.92 604 547.86 604 596.5 6.19 5.54
SELECT_WIDGET_SELECT_OPTION
scripting 258.11 276.58 360.6 281.46 255.67 276.58 286.48 14.99 13.40
painting 3.64 3.44 4.45 2.88 2.8 3.44 3.44 19.48 17.44
rendering 19.75 20.58 27.25 18.44 17.5 19.75 20.7 18.60 16.62

@sumitsum sumitsum added the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label May 30, 2022
@sumitsum sumitsum enabled auto-merge (squash) May 30, 2022 07:36
@sumitsum
Copy link
Contributor

Skipping requires QA pipeline since it is a POM file change.

@sumitsum sumitsum merged commit 531f5f8 into release Jun 1, 2022
@sumitsum sumitsum deleted the fix/14080-upgrade-lombok branch June 1, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend This marks the issue or pull request to reference server code BE Coders Pod Issues related to users writing code to fetch and update data Bug Something isn't working Good First Issue Good for newcomers High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: seeing build error due to old lombok package version
2 participants