Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: switch group added check for inline width #14190

Merged
merged 5 commits into from
May 31, 2022
Merged

fix: switch group added check for inline width #14190

merged 5 commits into from
May 31, 2022

Conversation

techbhavin
Copy link
Contributor

@techbhavin techbhavin commented May 31, 2022 •
edited by github-actions bot

Description

In the SwitchGroup widget inline property is not working

Fixes #14185

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

⚪ Total coverage has not changed 
// Code coverage diff between base branch:release and head branch: bug/switch-group-inline
Status File % Stmts % Branch % Funcs % Lines
🟢 total 56.71 (0) 38.66 (-0.01) 36.23 (0.01) 56.96 (0)
🔴 app/client/src/utils/autocomplete/TernServer.ts 52.71 (-0.23) 40.83 (-0.84) 36.21 (0) 56.74 (-0.25)
🟢 app/client/src/widgets/SwitchWidget/component/index.tsx 97.56 (0.12) 70.59 (-1.29) 87.5 (1.79) 96.88 (0.11)

@techbhavin techbhavin added the App Viewers Pod This label assigns issues to the app viewers pod label May 31, 2022
@techbhavin techbhavin requested a review from jsartisan May 31, 2022 05:00
@vercel
Copy link

vercel bot commented May 31, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview May 31, 2022 at 3:14PM (UTC)

@github-actions github-actions bot added Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage Release Blocker This issue must be resolved before the release Switch Group Widget Issues related to Switch group Widget UI Building Pod labels May 31, 2022
@techbhavin
Copy link
Contributor Author

/ok-to-test sha=9998746

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2412754086.
Workflow: Appsmith External Integration Test Workflow.
Commit: 9998746.
PR: 14190.

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

jsartisan
jsartisan previously approved these changes May 31, 2022
View reviewed changes
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2412754086.
Commit: 9998746.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 1329.12 1341.5 1301.14 1249.58 1303.23 1303.23 1304.91 2.71 2.42
painting 23.05 34.44 28.05 10.85 16.91 23.05 22.66 40.73 36.41
rendering 528.05 628.24 482.24 503.56 487.65 503.56 525.95 11.39 10.19
BIND_TABLE_DATA
scripting 2947.88 2646.13 2266.73 2335.21 2174.04 2335.21 2474 12.88 11.52
painting 33.56 58.54 27.39 32.66 62.65 33.56 42.96 38.01 34.01
rendering 1252.59 975.03 1119.85 1030.03 1264.42 1119.85 1128.38 11.49 10.27
CLICK_ON_TABLE_ROW
scripting 4808.9 4981.74 4292.82 4752.23 5285.01 4808.9 4824.14 7.51 6.72
painting 44.71 64.48 60.27 69.81 100.37 64.48 67.93 30.05 26.87
rendering 1751.03 1913.72 1531.47 1578.2 1740.34 1740.34 1702.95 8.96 8.01
UPDATE_POST_TITLE
scripting 7432.57 6003.89 5253.39 6436.75 7528.99 6436.75 6531.12 14.78 13.22
painting 51.18 53.15 40.02 41.98 47.29 47.29 46.72 12.16 10.87
rendering 664.08 798.28 656.61 658.77 726.09 664.08 700.77 8.80 7.87
OPEN_MODAL
scripting 4287.17 2396.13 2513.79 2303.72 5159.22 2513.79 3332.01 39.28 35.14
painting 25.84 47.57 27.64 34.57 44.99 34.57 36.12 27.33 24.45
rendering 809.89 796.78 936.78 753.25 761.65 796.78 811.67 9.09 8.13
CLOSE_MODAL
scripting 1287.14 1424.71 1270.31 4321.01 1303.3 1303.3 1921.29 69.89 62.51
painting 13.84 10.12 12.17 11.07 14.62 12.17 12.36 15.13 13.51
rendering 597.26 657.51 703.29 721.71 688 688 673.55 7.23 6.47
SELECT_WIDGET_MENU_OPEN
scripting 2168.33 2222.33 2461.31 2515.24 2299.31 2299.31 2333.3 6.43 5.76
painting 21.19 19.61 17.76 13.96 18.5 18.5 18.2 14.84 13.30
rendering 829.83 839.04 908 981.91 852.11 852.11 882.18 7.20 6.44
SELECT_WIDGET_SELECT_OPTION
scripting 369.29 393.5 392.52 615.4 380.72 392.52 430.29 24.16 21.61
painting 4.34 8.68 5.25 8.37 3.45 5.25 6.02 39.53 35.38
rendering 21.52 26.32 24.05 21.92 21.74 21.92 23.11 8.91 7.96

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2412754086.
Commit: 9998746.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 1329.12 1341.5 1301.14 1249.58 1303.23 1303.23 1304.91 2.71 2.42
painting 23.05 34.44 28.05 10.85 16.91 23.05 22.66 40.73 36.41
rendering 528.05 628.24 482.24 503.56 487.65 503.56 525.95 11.39 10.19
BIND_TABLE_DATA
scripting 2947.88 2646.13 2266.73 2335.21 2174.04 2335.21 2474 12.88 11.52
painting 33.56 58.54 27.39 32.66 62.65 33.56 42.96 38.01 34.01
rendering 1252.59 975.03 1119.85 1030.03 1264.42 1119.85 1128.38 11.49 10.27
CLICK_ON_TABLE_ROW
scripting 4808.9 4981.74 4292.82 4752.23 5285.01 4808.9 4824.14 7.51 6.72
painting 44.71 64.48 60.27 69.81 100.37 64.48 67.93 30.05 26.87
rendering 1751.03 1913.72 1531.47 1578.2 1740.34 1740.34 1702.95 8.96 8.01
UPDATE_POST_TITLE
scripting 7432.57 6003.89 5253.39 6436.75 7528.99 6436.75 6531.12 14.78 13.22
painting 51.18 53.15 40.02 41.98 47.29 47.29 46.72 12.16 10.87
rendering 664.08 798.28 656.61 658.77 726.09 664.08 700.77 8.80 7.87
OPEN_MODAL
scripting 4287.17 2396.13 2513.79 2303.72 5159.22 2513.79 3332.01 39.28 35.14
painting 25.84 47.57 27.64 34.57 44.99 34.57 36.12 27.33 24.45
rendering 809.89 796.78 936.78 753.25 761.65 796.78 811.67 9.09 8.13
CLOSE_MODAL
scripting 1287.14 1424.71 1270.31 4321.01 1303.3 1303.3 1921.29 69.89 62.51
painting 13.84 10.12 12.17 11.07 14.62 12.17 12.36 15.13 13.51
rendering 597.26 657.51 703.29 721.71 688 688 673.55 7.23 6.47
SELECT_WIDGET_MENU_OPEN
scripting 2168.33 2222.33 2461.31 2515.24 2299.31 2299.31 2333.3 6.43 5.76
painting 21.19 19.61 17.76 13.96 18.5 18.5 18.2 14.84 13.30
rendering 829.83 839.04 908 981.91 852.11 852.11 882.18 7.20 6.44
SELECT_WIDGET_SELECT_OPTION
scripting 369.29 393.5 392.52 615.4 380.72 392.52 430.29 24.16 21.61
painting 4.34 8.68 5.25 8.37 3.45 5.25 6.02 39.53 35.38
rendering 21.52 26.32 24.05 21.92 21.74 21.92 23.11 8.91 7.96

@shadabbuchh
Copy link

This issue is fixed now. Tested it in DP.
The Switch Group abides by the Inline property. Also when initially dropped onto the canvas, the options appear next to each other.

https://images.zenhubusercontent.com/275993885/97fa631f-0eca-4863-84e9-cb2467df668e/screen_recording_2022_05_31_at_11_23_52_am.mov

Moving it to Done.

@Aishwarya-U-R
Copy link
Contributor

/ok-to-test sha=a7217a7

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2415057786.
Workflow: Appsmith External Integration Test Workflow.
Commit: a7217a7.
PR: 14190.

@somangshu somangshu requested a review from jsartisan May 31, 2022 12:57
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2415057786.
Commit: a7217a7.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 2093.82 2045.23 2009.01 2000.83 2116.47 2045.23 2053.07 2.49 2.22
painting 19.21 15.81 37.12 22.93 27.67 22.93 24.55 33.81 30.22
rendering 797.64 784.8 753.31 742.5 836.28 784.8 782.91 4.77 4.27
SELECT_WIDGET_SELECT_OPTION
scripting 348.09 329.85 339.51 368.33 380.32 348.09 353.22 5.88 5.25
painting 5.29 11.1 9.6 17.25 4.22 9.6 9.49 54.79 49.00
rendering 25.84 21.97 22.8 31.84 21.38 22.8 24.77 17.40 15.58

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2415057786.
Commit: a7217a7.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 2093.82 2045.23 2009.01 2000.83 2116.47 2045.23 2053.07 2.49 2.22
painting 19.21 15.81 37.12 22.93 27.67 22.93 24.55 33.81 30.22
rendering 797.64 784.8 753.31 742.5 836.28 784.8 782.91 4.77 4.27
SELECT_WIDGET_SELECT_OPTION
scripting 348.09 329.85 339.51 368.33 380.32 348.09 353.22 5.88 5.25
painting 5.29 11.1 9.6 17.25 4.22 9.6 9.49 54.79 49.00
rendering 25.84 21.97 22.8 31.84 21.38 22.8 24.77 17.40 15.58

@Aishwarya-U-R
Copy link
Contributor

/ok-to-test sha=4f08a1d

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2415426166.
Workflow: Appsmith External Integration Test Workflow.
Commit: 4f08a1d.
PR: 14190.

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2415426166.
Workflow: Appsmith External Integration Test Workflow.
Commit: 4f08a1d.
PR: 14190.

1 similar comment
@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2415426166.
Workflow: Appsmith External Integration Test Workflow.
Commit: 4f08a1d.
PR: 14190.

@Aishwarya-U-R
Copy link
Contributor

/ok-to-test sha=52c7bf7

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2415915447.
Workflow: Appsmith External Integration Test Workflow.
Commit: 52c7bf7.
PR: 14190.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2415915447.
Commit: 52c7bf7.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 2001.56 1951.85 1958.87 2085.1 2104.74 2001.56 2020.42 3.51 3.14
painting 23.44 18.26 21.36 12.96 14.78 18.26 18.16 24.12 21.53
rendering 733.43 748.84 732.92 734 807.65 734 751.37 4.28 3.83
SELECT_WIDGET_SELECT_OPTION
scripting 327.14 356.45 342.62 340.01 344.51 342.62 342.15 3.07 2.74
painting 10.3 6.29 5.25 5.64 8.68 6.29 7.23 30.01 26.83
rendering 22.1 21.75 23.32 21.2 21.88 21.88 22.05 3.54 3.17

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2415915447.
Commit: 52c7bf7.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 2001.56 1951.85 1958.87 2085.1 2104.74 2001.56 2020.42 3.51 3.14
painting 23.44 18.26 21.36 12.96 14.78 18.26 18.16 24.12 21.53
rendering 733.43 748.84 732.92 734 807.65 734 751.37 4.28 3.83
SELECT_WIDGET_SELECT_OPTION
scripting 327.14 356.45 342.62 340.01 344.51 342.62 342.15 3.07 2.74
painting 10.3 6.29 5.25 5.64 8.68 6.29 7.23 30.01 26.83
rendering 22.1 21.75 23.32 21.2 21.88 21.88 22.05 3.54 3.17

@rahulramesha rahulramesha merged commit 95e6b4f into release May 31, 2022
@rahulramesha rahulramesha deleted the bug/switch-group-inline branch May 31, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulramesha rahulramesha rahulramesha approved these changes

@jsartisan jsartisan Awaiting requested review from jsartisan

Assignees
No one assigned
Labels
App Viewers Pod This label assigns issues to the app viewers pod Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage Release Blocker This issue must be resolved before the release Switch Group Widget Issues related to Switch group Widget
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Switch group widget - Inline property not working
5 participants
@techbhavin @shadabbuchh @Aishwarya-U-R @jsartisan @rahulramesha